Uh oh!
There was an error while loading. Please reload this page.
Conversation
| futures = "0.1.31" | ||
| heck = "0.3.3" | ||
| http = "0.2.5" | ||
| http = "0.1.21" |
There was a problem hiding this comment.
Hmm. I should revert this.
| } | ||
| pub fn is_test_generated_data_allowed_to_escape_project_dir() -> bool { | ||
| is_env_variable_set("ALLOW_TEST_DATA_ESCAPE_PROJECT_DIR", "true") |
There was a problem hiding this comment.
Let's pour some more ideas if we can find a way around this.
| futures = "0.1.31" | ||
| heck = "0.3.3" | ||
| http = "0.2.5" | ||
| http = "0.1.21" |
| @@ -2048,19 +2050,16 @@ mod tests { | |||
| #[test] | |||
| fn get_modified_setup_tilde_in_config_file_path() { | |||
There was a problem hiding this comment.
I'm glad that you discovered this. Just my personal opinion, I'd be afraid of an application creating files in my computer outside the project directory.
A possible solution: Maybe use container provided by Docker.
| let _guard = EnvironmentGuard::new(); | ||
| let _clap_guard = ClapGuard::new(); | ||
| let home_dir = ensure_node_home_directory_exists( | ||
| let node_home_dir = ensure_node_home_directory_exists( |
There was a problem hiding this comment.
I'd prefer home_dir. Also, let's change the function name to also say, ensure_home_directory_exists.
| pub data: Vec<u8>, | ||
| } | ||
| pub fn make_node_base_dir_and_return_its_absolute_and_relative_path_to_os_home_dir( |
There was a problem hiding this comment.
You mentioned that "why it still exists?". I think you'd like to remove it and change the code inside tests if it's used there. Good Luck 👍
* GH-781: experimenting with a test utility * GH-781: task might be complete now * GH-781: debugging for windows * GH-781: trying to satisfy Win * GH-781: clippy * GH-781: removed bad solution for issue that now a new card was written for * GH-781: cargo.toml change * GH-781: review answered --------- Co-authored-by: Bert <Bert@Bert.com>
No description provided.