GH-605: Teach the PayableScanner on tx retries - #663

Merged

utkarshg6 merged 266 commits into

Sep 29, 2025

This pull request is big! We're only showing the most recent 250 commits

Commits on Jul 11, 2025

GH-605: ability to migrate transactions from the SentPayable Table to FailedPayable Table
utkarshg6
committed
6d14150
GH-605: add helper function join_with_separator
utkarshg6
committed
f84ecf9
GH-605: use join_with_separator inside failed_payable_dao
utkarshg6
committed
553f725
GH-605: use join_with_separator inside sent_payable_dao
utkarshg6
committed
d17b7fc
GH-605: use the HashSet instead of Vector for RetrieveCondition
utkarshg6
committed
5cdfb5c
GH-605: all good but insert_new_records_throws_error_when_two_txs_with_same_hash_are_present_in_the_input intermittently passes or fails
utkarshg6
committed
2325da6
GH-605: sort the inputs as the first thing
utkarshg6
committed
ec41f25

Commits on Jul 14, 2025

Commits on Jul 15, 2025

GH-605: add better logging
utkarshg6
committed
0715e9b
GH-605: further improvements in migrating failures
utkarshg6
committed
e068941
GH-605: add test retrieve_txs_by_hash_returns_only_existing_transactions
utkarshg6
committed
1c7314d
GH-605: clean implementation of payables migration
utkarshg6
committed
418cb73
GH-605: test passing after refactoring
utkarshg6
committed
7ae713a
GH-605: bit more refactoring
utkarshg6
committed
e6e3968
GH-605: some more; test still passing
utkarshg6
committed
9ac296e

Commits on Jul 16, 2025

GH-605: the left side of the finish scan is working properly
utkarshg6
committed
e36cf67

Commits on Jul 17, 2025

GH-605: payable_scanner_is_facing_failed_transactions_and_their_fingerprints_exist passes
utkarshg6
committed
4483879

Commits on Jul 19, 2025

GH-605: 2 panics are being tested
utkarshg6
committed
85a6b36
GH-605: add test payable_scanner_panics_after_migration_when_not_all_txs_were_found_in_db
utkarshg6
committed
4970ec7
GH-605: one more test is fixed
utkarshg6
committed
9b76297

Commits on Jul 20, 2025

GH-605: add TODOs after discussion
utkarshg6
committed
51357e9

Commits on Jul 21, 2025

Merge branch 'GH-598' into GH-605
utkarshg6
committed
7e4bf29

Commits on Jul 22, 2025

GH-605: introduce separate_batch_results() function
utkarshg6
committed
7f4582f
GH-605: more changes to finish_scan()
utkarshg6
committed
a9ba9d6
GH-605: compiling after further modifications
utkarshg6
committed
ffe3a95
GH-605: migration and refactoring
utkarshg6
committed
97dd8ee
GH-605: eliminate unnecessary code
utkarshg6
committed
d806b08
GH-605: Two tests passing
utkarshg6
committed
e9d5341
GH-605: more tests passing
utkarshg6
committed
2b73f65
GH-605: some more code changes
utkarshg6
committed
fa01dc1
GH-605: few more changes
utkarshg6
committed
32cc13a
GH-605: more testing
utkarshg6
committed
0cfe08f
GH-605: remove unnecessary code
utkarshg6
committed
7eebffd

Commits on Jul 23, 2025

GH-605: properly test generate_failed_payables
utkarshg6
committed
dda0635
GH-605: few more tests
utkarshg6
committed
8f55ee2

Commits on Jul 24, 2025

GH-605: write tests for handle_local_error
utkarshg6
committed
589dd5c
GH-605: tests for handle_batch_results
utkarshg6
committed
7aa4951
GH-605: test panicking cases for handle_batch_results
utkarshg6
committed
3f7df14
GH-605: add more tests for process_result()
utkarshg6
committed
5e9ab2e
GH-605: introduce the outcome in subsidiary fns
utkarshg6
committed
b3203ac
GH-605: remove unnecessary code from the payable_scanner
utkarshg6
committed
fea14ee
GH-605: fix test utility issue which was causing a lot of tests to fail
utkarshg6
committed
19790c9
GH-605: further refactoring and fixes
utkarshg6
committed
05796b1
GH-605: remove more unnecessary code
utkarshg6
committed
f111d2a
GH-605: bit more cleanup
utkarshg6
committed
f5b1a85
GH-605: add one more test for the flag
utkarshg6
committed
4fddf06
GH-605: new_calls_factories_properly is working again
utkarshg6
committed
e48ad5f
GH-605: fixed few more tests
utkarshg6
committed
80a13e8

Commits on Jul 25, 2025

GH-605: some minor changes
utkarshg6
committed
7d4cfb4
Merge branch 'GH-598' into GH-605
utkarshg6
committed
c2ce79c
GH-605: code modularization
utkarshg6
committed
a964eb4
GH-605: add ability to call the start_scan from the tests
utkarshg6
committed
0fd09d0
GH-605: add code for start_scan_for_retry_works
utkarshg6
committed
1bb1bf7
GH-605: all lines are tested
utkarshg6
committed
e73c1f7
GH-605: add more functionality to the test
utkarshg6
committed
c567ec3

Commits on Jul 27, 2025

GH-605: introduce retrieve condition for PayableDao
utkarshg6
committed
8cd763b
GH-605: ability to retrieve non pending payables by addresses
utkarshg6
committed
0727713
GH-605: add ability for start_scan() to fetch payables
utkarshg6
committed
6306d65
GH-605: the new payables are being generated
utkarshg6
committed
e9f870c
GH-605: add the case when transaction is being retried but no payable record was found
utkarshg6
committed
fac4059
GH-605: another refactor
utkarshg6
committed
274c060
GH-605: more refactoring
utkarshg6
committed
61c709c
GH-605: few renames
utkarshg6
committed
ea399b0
GH-605: further simplification of the code
utkarshg6
committed
26d704d

Commits on Jul 28, 2025

GH-605: cleanup in start_scan()
utkarshg6
committed
a109005
GH-605: add assertions for mocks
utkarshg6
committed
6f9638b
GH-605: use hashmap instead of vector
utkarshg6
committed
e61a064
GH-605: base for TxTemplate
utkarshg6
committed
8d66f76

Commits on Jul 29, 2025

GH-605: it has started to compile
utkarshg6
committed
a621374
GH-605: it has started to compile again
utkarshg6
committed
dff5548
GH-605: it has started to compile again and again
utkarshg6
committed
9fc8280
GH-605: migrate structures to the data_structures.rs file
utkarshg6
committed
4ef6ee6
GH-605: add more functionality to the data structure file
utkarshg6
committed
3247696
GH-605: introduce NewTxTemplates and RetryTxTemplates
utkarshg6
committed
dc4f867

Commits on Jul 30, 2025

GH-605: use Either in price_qualified_payables
utkarshg6
committed
0d81aad
GH-605: compiling again
utkarshg6
committed
4603a76
GH-605: returns_correct_priced_qualified_payables_for_retry_payable_scan started working
utkarshg6
committed
7996a66
GH-605: one more minor change
utkarshg6
committed
fa7c5cd
GH-605: some more changes
utkarshg6
committed
2e86b7b
GH-605: tests are working fine for new tx templates
utkarshg6
committed
b9f7ede
GH-605: log improvements is wip
utkarshg6
committed
7427d7c
GH-605: able to log for retry payables in a single go
utkarshg6
committed
a5dfd58
GH-605: two more test start to pass
utkarshg6
committed
f0b29f3
GH-605: all tests pass in agent_web3.rs
utkarshg6
committed
e86beb6
GH-605: add stronger assertions to agent_web3.rs
utkarshg6
committed
41d8c98

Commits on Jul 31, 2025

GH-605: add the TODO
utkarshg6
committed
bbf692d
GH-605: all tests pass in blockchain_interface_web3/mod.rs
utkarshg6
committed
6f7469d
GH-605: modularize NewTxTemplates and RetryTxTemplates
utkarshg6
committed
7035d80
GH-605: add ability to iterate over the NewTxTemplates and RetryTxTemplates
utkarshg6
committed
ba21894
GH-605: pre cleanup
utkarshg6
committed
87f564d
GH-605: tests passing in agent and blockchain interface
utkarshg6
committed
42ac352
GH-605: bit more refactoring
utkarshg6
committed
f8e52d8

Commits on Aug 1, 2025

Commits on Aug 3, 2025

GH-645: from_priced_retry_tx_templates starts to work
utkarshg6
committed
d4877c8
GH-645: a better algorithm using vectors
utkarshg6
committed
3805c0a
GH-605: add test for largest amount and more cleanup
utkarshg6
committed
5c4a4f1
GH-605: more ordering
utkarshg6
committed
2afc136
GH-605: implement nonce_range method
utkarshg6
committed
d17ebd9
GH-605: introduce make_signable_tx_template
utkarshg6
committed
58f1b56
GH-605: better logging for tx signing:
utkarshg6
committed
475c1c8
GH-605: remove clone on consuming wallet
utkarshg6
committed
69e028f
GH-605: improve logic of logging tx
utkarshg6
committed
2c315d8
GH-605: exp: return Tx instead of HashAndAmount in Futures
utkarshg6
committed
97a783c
GH-605: exp: replace Vec<IndividualBatchResult> to BatchResults
utkarshg6
committed
133e146
GH-605: exp: payment_procedure_result is a result now
utkarshg6
committed
348d864
GH-605: exp: Sending Error now holds all FailedTx
utkarshg6
committed
878b868
GH-605: exp: sending error is now being returned
utkarshg6
committed
f54582b
GH-605: exp: one test fixed in utils.rs
utkarshg6
committed
145230b
GH-605: exp: sending error is received up to the end
utkarshg6
committed
7536e62

Commits on Aug 4, 2025

GH-605: exp: new_payable_scan_finishes_as_expected works
utkarshg6
committed
2175e70
GH-605: exp: minor refactoring
utkarshg6
committed
95ea5aa
GH-605: exp: the errors are properly handled
utkarshg6
committed
fe41ce1
GH-605: exp: ability to retrieve txs by receiver addresess
utkarshg6
committed
9f82e14
GH-605: add ability to update after retries
utkarshg6
committed
58fd61f
GH-605: comment old code in Payable Scanner
utkarshg6
committed
053f17c
GH-605: remove a lot of code from the Payable Scanner's finish scan old code
utkarshg6
committed
bc1da9b
GH-605: fix one more test
utkarshg6
committed
04253f0

Commits on Aug 5, 2025

Commits on Aug 6, 2025

GH-605: remove unnecessary code
utkarshg6
committed
e544c06
GH-605: fixed todo!() in scanners/mod.rs
utkarshg6
committed
0fb693b
GH-605: fixed another todo!() in accountant/mod.rs
utkarshg6
committed
3e9a954
GH-605: eliminated last todo!()
utkarshg6
committed
e3618ee
Merge branch 'GH-598' into GH-605
utkarshg6
committed
1d779a3
GH-605: only tests related to PendingPayableScan are failing in Accountant
utkarshg6
committed
d67b33a
GH-605: migrate payable_scanner extension to payable_scanner
utkarshg6
committed
f6866ec
GH-605: cleanup in payable_scanner_extension
utkarshg6
committed
3e0faee
GH-605: more cleanup
utkarshg6
committed
8ac33b5
GH-605: migrate BlockchainAgentMock test utils
utkarshg6
committed
3d44055
GH-605: eliminate the test utils file from Payable Scanner Extension
utkarshg6
committed
a4f1d56
GH-605: migrate core functionality of extension to payable scanner
utkarshg6
committed
f8c5308
GH-605: payable_scanner_extension is history
utkarshg6
committed
ed8b963
GH-605: remove computed_gas_price from the RetryTxTemplate
utkarshg6
committed
7ba5e31
GH-605: refactor in test_utils
utkarshg6
committed
efb285b
GH-605: mark successfully retried txs as concluded
utkarshg6
committed
0dba0d6
GH-605: minor renaming
utkarshg6
committed
fe3af5e
GH-605: add a TODO
utkarshg6
committed
5d7302a
GH-605: minor log change
utkarshg6
committed
3c831ec
GH-605: OperationOutcome now provides which scanner to run
utkarshg6
committed
3658464

Commits on Aug 7, 2025

Commits on Aug 11, 2025

GH-605: fix one more test
utkarshg6
committed
a15468f
GH-605: cleanup and code migration
utkarshg6
committed
666755b
GH-605: another refactor
utkarshg6
committed
920bf31

Commits on Aug 12, 2025

GH-605: more refactoring
utkarshg6
committed
272d2d1
GH-605: more refactoring
utkarshg6
committed
f6bb58a
GH-605: minor rename
utkarshg6
committed
dae6750
GH-605: more renaming
utkarshg6
committed
efa59f3

Commits on Aug 13, 2025

GH-605: add crate-level attribute to test files
utkarshg6
committed
385777e

Commits on Aug 14, 2025

GH-605: test empty vectors in fn arguments
utkarshg6
committed
08ce789

Commits on Aug 15, 2025

GH-605: more changes in payable_scanner/mod.rs
utkarshg6
committed
a641b5f
GH-605: more cleanup in the start_scan
utkarshg6
committed
aeac1de
GH-605: introduce trait Transaction
utkarshg6
committed
860cb49

Commits on Aug 16, 2025

GH-605: write tests for empty vectors in batch results
utkarshg6
committed
bbf271d
GH-605: mark logs with failed txs as WARN
utkarshg6
committed
29a0d66
GH-605: panics are tested better
utkarshg6
committed
88998a7
GH-605: rename non_pending_payables
utkarshg6
committed
773ca7d
GH-605: use references on SentPayables wherever possible
utkarshg6
committed
68f6e99
GH-605: migrate payment adjuster code to a new file
utkarshg6
committed
0721c30
GH-605: add log while handling initial templates msg
utkarshg6
committed
5b948a7

Commits on Aug 17, 2025

Commits on Aug 22, 2025

Merge branch 'GH-598' into GH-605-pre-review
utkarshg6
committed
02fb7e0
GH-605: add test for iterator
utkarshg6
committed
6d4df87
GH-605: fix more tests
utkarshg6
committed
ba5fa0d
GH-605: remove all TODOs
utkarshg6
committed
6402474
GH-605: add copuright lines at the top of the files
utkarshg6
committed
d10dcc9
GH-605: rename OperationOutcome to NextScanToRun
utkarshg6
committed
f7e2bb0
GH-605: more fixes with renames
utkarshg6
committed
6d3ed4d

Commits on Aug 24, 2025

GH-605: schedule next scan is well tested
utkarshg6
committed
7b16efd
GH-605: pre review changes
utkarshg6
committed
928d136

Commits on Sep 11, 2025

GH-605: review changes
utkarshg6
committed
093d7de
GH-605: eliminate new_fingerprints_recipient
utkarshg6
committed
2fd4bcc
GH-605: add commit hash to TODO
utkarshg6
committed
44be81d
GH-605: add TODOs for GH-703
utkarshg6
committed
cc7da7a
GH-605: refactor out the failed_tx
utkarshg6
committed
d666e53
GH-605: more review changes
utkarshg6
committed
2450508
GH-605: more refactoring of sql values
utkarshg6
committed
bb1a67d
GH-605: further fixes
utkarshg6
committed
074a40b
GH-605: more changes
utkarshg6
committed
070123a

Commits on Sep 12, 2025

GH-605: change it to retrieved_payables
utkarshg6
committed
52034fb
GH-605: rename to determine_next_scan_to_run
utkarshg6
committed
8f63153
GH-605: more changes
utkarshg6
committed
1c2d773
GH-605: improve the TODO
utkarshg6
committed
e851f34

Commits on Sep 16, 2025

GH-605: add TODO for the test
utkarshg6
committed
24396b1

Commits on Sep 18, 2025

GH-605: more and more changes
utkarshg6
committed
d2fd9cd
GH-605: bit more refactoring
utkarshg6
committed
52411c9
GH-605: bit more changes
utkarshg6
committed
398bdd9
GH-605: changing to & works
utkarshg6
committed
e044dc4
GH-605: further changes
utkarshg6
committed
8227dc8
GH-605: more TODOs
utkarshg6
committed
ff6e400

Commits on Sep 19, 2025

GH-605: derive Copy for PayableScanType
utkarshg6
committed
dc863ef
GH-605: add scan_type function
utkarshg6
committed
9fd9ee7
GH-605: comment out unused code in test
utkarshg6
committed
9ba398e
GH-605: refactor the code a bit
utkarshg6
committed
80711d4
GH-605: refactor signable_tx_templates_can_be_created_from_priced_retry_tx_templates
utkarshg6
committed
4ac6418
GH-605: the helper functions have more realistic args name
utkarshg6
committed
83d6155
GH-605: more refactoring of signable_tx_templates_can_be_created_from_priced_retry_tx_templates
utkarshg6
committed
141d10a
GH-605: more refactored changes
utkarshg6
committed
4f91045
GH-605: further refactoring changes
utkarshg6
committed
896f7d0
GH-605: handle_batch_results has been renamed
utkarshg6
committed
18e0a54

Commits on Sep 20, 2025

GH-605: few more changes
utkarshg6
committed
cf0938a
GH-605: few more changes
utkarshg6
committed
9308d37

Commits on Sep 22, 2025

GH-605: Review 4
utkarshg6
committed
73395d8
GH-605: Bug bot error
utkarshg6
committed
7522708

Commits on Sep 23, 2025

GH-605: Just merged; 567 errors
utkarshg6
committed
e7c7716

Commits on Sep 24, 2025

GH-605: reduced errors to 97
utkarshg6
committed
794d23a
GH-605: only 37 errors remaining
utkarshg6
committed
655830d

Commits on Sep 25, 2025

GH-605: only 5 errors remaining
utkarshg6
committed
06106f7
GH-605: only 2 errors remaining
utkarshg6
committed
8947136
GH-605: all errors gone
utkarshg6
committed
b2df759
GH-605: tests in sent_payable_dao are passing
utkarshg6
committed
2828f80

Commits on Sep 26, 2025

GH-605: all tests pass in payable scanner
utkarshg6
committed
9a51af4
GH-605: fix most of the clippy warnings
utkarshg6
committed
663c30e
GH-605: fix more of these problems
utkarshg6
committed
6c84f82
GH-605: write test for the ordering of ValidationStatus
utkarshg6
committed
2f07581
GH-605: implement ordering for ValidationStatus
utkarshg6
committed
d6b8592
GH-605: comment out unused code
utkarshg6
committed
5838a52
GH-605: more changes fixed
utkarshg6
committed
eab920d
GH-605: more fixing
utkarshg6
committed
2cbdffe
GH-605: interim commit
Bert
authored and
Bert
committed
62f3542

Commits on Sep 27, 2025

GH-605: all tests in Node passing
Bert
authored and
Bert
committed
97f54c8

Commits on Sep 28, 2025

GH-605: last todo removed
Bert
authored and
Bert
committed
d94d5cb
GH-605: fixed poor test coverage
Bert
authored and
Bert
committed
b82e3d2
GH-605: free of unnecessary boilerplate code - erased manual impls for PartialOrd and Ord
Bert
authored and
Bert
committed
76a857c

Commits on Sep 29, 2025

GH-605: continuous impovement -- Ord and little refactoring
Bert
authored and
Bert
committed
b9ad935
GH-605: CI except MNT just fine
Bert
authored and
Bert
committed
00f0223
GH-605: MNT fixed
Bert
authored and
Bert
committed
15a4de1
GH-605: small correction
Bert
authored and
Bert
committed
02d98fb