Uh oh!
There was an error while loading. Please reload this page.
GH-623: Direct Node to pick new public key on the command line - #679
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 14. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Uh oh!
There was an error while loading. Please reload this page.
Note
Medium Risk
Touches startup configuration and persistent key selection logic; incorrect handling could cause nodes to fail to start or unexpectedly rotate identity keys, though changes are gated behind a new explicit flag and covered by tests.
Overview
Adds
--new-public-key(andMASQ_NEW_PUBLIC_KEY/config-file support) to let operators explicitly reuse the previously stored public key (off) or force generation and persistence of a new one (on) during startup.Plumbs this flag through bootstrapping/config parsing (
BootstrapperConfig.new_public_key_opt, sharedOnOffenum, setup reporter UI defaults) and updates cryptographic key initialization to honor the choice, including hard-fail cases whenoffis requested but no prior key or--db-passwordis available.Integration tests were refreshed to use
www.testingmcafeesites.comendpoints/content and improved a bookkeeping assertion for clearer mismatch diagnostics; additionally, config init now returns structured errors on unknown CLI args, and.gitignorenow ignores JetBrains Copilot files.Written by Cursor Bugbot for commit 1bc0c90. This will update automatically on new commits. Configure here.