Skip to content

Populate registries after you do load a pickle file - #24

Open
ambujpawar wants to merge 7 commits into
MBrouns:mainfrom
ambujpawar:main
Open

ambujpawar wants to merge 7 commits into
MBrouns:mainfrom
ambujpawar:main

Conversation

@ambujpawar

@ambujpawar ambujpawar commented Aug 11, 2022

Copy link
Copy Markdown
  • Add new to the SimpleImputer
  • This enables us to populate registries as pickle.loads does not call init of a class
  • Modify test to check just the name of metrics instead of complete metrics

Closes #10

NOTE: This code only solves issues with Imputer. For failing tests while preprocessing please check #23

@MBrouns

MBrouns commented Aug 14, 2022

Copy link
Copy Markdown
Owner

Looks good! If possible I'd like the changes for both this and #23 in the same PR. Also, I think the __init__ implementation is now unnecessary. Could you check whether it can be removed?

@ambujpawar

Copy link
Copy Markdown
Author

Yes, you are right. dunder init is no longer needed.

Changelogs:

@ambujpawar ambujpawar closed this Aug 14, 2022
@ambujpawar ambujpawar reopened this Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pickle.load doesn't call __init__ which causes our registry to not be populated

3 participants