Uh oh!
There was an error while loading. Please reload this page.
✨ feat: replace native confirm() dialogs with @mind-studio/ui AlertDialog - #19
Merged
Merged
Conversation
…alog Vault delete confirmation and ItemEditor discard-unsaved-changes prompt now use the themed AlertDialog instead of blocking window.confirm(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces two blocking
window.confirm()calls in the Vault app with the themed@mind-studio/uiAlertDialog.Changes
src/apps/vault/index.tsx): the destructive delete trigger now opens a declarative "Delete item?" AlertDialog. The actual deletion lives inconfirmDelete(wired to the "Delete" action), preserving all existing state updates.src/apps/vault/ItemEditor.tsx): closing the editor while dirty now opens a "Discard unsaved changes?" AlertDialog instead ofconfirm(). The original close behavior was extracted intoproceedClose, shared by both the not-dirty path and the "Discard" action; "Keep editing" just dismisses.Gates
npm run lint— clean (pre-existing warnings only)npm run typecheck— passnpm run test— pass (no test files)🤖 Generated with Claude Code