Skip to content

Add design document for climatology classes - #205

Closed
xylar wants to merge 1 commit into
MPAS-Dev:developfrom
xylar:design_doc_climatology_classes
Closed

Add design document for climatology classes#205
xylar wants to merge 1 commit into
MPAS-Dev:developfrom
xylar:design_doc_climatology_classes

Conversation

@xylar

@xylar xylar commented Jun 9, 2017

Copy link
Copy Markdown
Collaborator

A design document describing the transition from functions to classes in the climatology module.

@milenaveneziani

Copy link
Copy Markdown
Collaborator

I think we should review this and #206, #209 next, right?

@xylar

xylar commented Jun 13, 2017

Copy link
Copy Markdown
Collaborator Author

Yes, that's right. I won't have much time to respond because I'm at a meeting over the next 3 days but would appreciate your comments whenever you have time.

@milenaveneziani

Copy link
Copy Markdown
Collaborator

Hi @xylar: sorry for the delay on this, I came back from vacation yesterday.
Unfortunately I don't have enough time to go into the details of this. My main concern, as usual, is whether this implementation would cause a significant increase in complexity, making it harder for a potential contributor to actually contribute with new analysis scripts.
@pwolfram: I know you are also busy with other things, but do you have any general comments or major concerns?

@milenaveneziani

Copy link
Copy Markdown
Collaborator

I see now that this PR and #206, #209 are meant to explain the changes made in #204.

@milenaveneziani

Copy link
Copy Markdown
Collaborator

ok, I went through the 3 design documents (fairly quickly) and now I understand the ideas and motivation for these. It is, though, a bit too high-level python for me to grasp fully, so I would suggest for @pwolfram and @vanroekel to take a look too when they get a chance (otherwise these design documents are a bit wasted.. :).
One quick question: did you test the pre-requisite tasks in batch mode as well?

@xylar

xylar commented Jul 18, 2017

Copy link
Copy Markdown
Collaborator Author

@milenaveneziani, yes, I did check the prerequisite tasks with parallel tasks as well. That's actually a major cause of the complexity of prerequisite tasks. A given task can only be launched when its prerequisites are completed and that is obviously more complicated to keep track of with parallel tasks.

@xylar

xylar commented Jul 18, 2017

Copy link
Copy Markdown
Collaborator Author

My main concern, as usual, is whether this implementation would cause a significant increase in complexity, making it harder for a potential contributor to actually contribute with new analysis scripts.

I'm always interested in getting feedback on simpler alternatives to the approaches I've taken. I think we need to figure out how to make it easier to make contributions to this repo, though, given that I seem to be the only person with significant time to put into its development and there isn't even enough time to review my PRs or design documents.

@xylar

xylar commented Aug 13, 2017

Copy link
Copy Markdown
Collaborator Author

We are probably not going to go with this design solution.

@xylar xylar closed this Aug 13, 2017
@xylar
xylar deleted the design_doc_climatology_classes branch April 30, 2018 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants