Skip to content

Fix first file for time series - #291

Merged
xylar merged 1 commit into
MPAS-Dev:developfrom
xylar:fix_time_series_first_year
Dec 21, 2017
Merged

Fix first file for time series#291
xylar merged 1 commit into
MPAS-Dev:developfrom
xylar:fix_time_series_first_year

Conversation

@xylar

@xylar xylar commented Dec 21, 2017

Copy link
Copy Markdown
Collaborator

This merge makes the range of files printed in the log ignore the first year if it is not in the requested range, even though it gets added to allow anomaly computations.

This merge makes the range of files printed in the log ignore the
first year if it is not in the requested range, even though it gets
added to allow anomaly computations.
@xylar xylar added the clean up label Dec 21, 2017
@xylar xylar self-assigned this Dec 21, 2017
@xylar

xylar commented Dec 21, 2017

Copy link
Copy Markdown
Collaborator Author

@milenaveneziani, I think you can just approve this one by inspection. I have confirmed in a small test (running with time series computed over years 2 to 5 for the QU240 test case) that the expected output is now produced:

Computing MPAS time series from first year plus files:
    mpaso.hist.am.timeSeriesStatsMonthly.0002-01-01.nc through
    mpaso.hist.am.timeSeriesStatsMonthly.0005-12-01.nc

@milenaveneziani milenaveneziani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xylar.

@milenaveneziani

Copy link
Copy Markdown
Collaborator

oh, forgot to mention: the same happens in mpas_climatology. Could you please make the same change there?

@milenaveneziani

Copy link
Copy Markdown
Collaborator

Here:

self.inputFiles = self.historyStreams.readpath(
streamName, startDate=startDate, endDate=endDate,
calendar=self.calendar)

@xylar

xylar commented Dec 21, 2017

Copy link
Copy Markdown
Collaborator Author

@milenaveneziani, are you quite sure? The climatology shouldn't add the first year to the input files so there's no reason I can see why the list of input files wouldn't be correct. I'll check for myself.

@xylar

xylar commented Dec 21, 2017

Copy link
Copy Markdown
Collaborator Author

I see the expected output for climatologies, e.g.:

Computing MPAS climatologies from files:
    mpaso.hist.am.timeSeriesStatsMonthly.0002-01-01.nc through
    mpaso.hist.am.timeSeriesStatsMonthly.0005-12-01.nc

when I request years 2-50 (but only 1-5 are available).

@milenaveneziani

Copy link
Copy Markdown
Collaborator

hmm, I thought I had seen a similar message with the climos. Never mind. Thanks for addressing this so quickly.

@xylar
xylar merged commit e85ad9a into MPAS-Dev:develop Dec 21, 2017
@xylar
xylar deleted the fix_time_series_first_year branch December 21, 2017 15:29
@xylar

xylar commented Dec 21, 2017

Copy link
Copy Markdown
Collaborator Author

Thanks for the quick review.

@xylar xylar mentioned this pull request Jan 26, 2018
xylar added a commit that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants