sonar: fix mechanical and new-code issues (batch 1) - #396
Merged
Conversation
- OverflowArena.TryReuseFreeBlock: the while loop could only ever run once (S1751 BUG); replaced with an equivalent single-attempt if - Table.CRUD legacy delete purge helpers: remove unused pkCol parameter (S1172) and the redundant null-forgiving operator (S8969); transactional delete buffer loop uses Where (S3267); remove null-forgiving in relocation guard (S8969) - Database.Core: CanonicalDeleteStatementsParsed is static (S2325); tests updated to static access - FixedWidthRecordLayoutTests: Assert.False instead of Assert.Equal(false, ...) (S2701)
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First batch against the SonarCloud new-code issues on master (73 total):
Validated: SharpCoreDB.Tests 1777/0, CQRS 64/0.
Remaining (mostly S3776 cognitive-complexity on pre-existing large methods, 16-107) and mechanical items in benchmark/tests are tracked for follow-up batches.