sonar: fix remaining mechanical issues (batch 5) - #401
Merged
Conversation
- HashIndex: remove redundant null-forgiving operator (S8969) - Table.CRUD: oldHashKeys snapshot via LINQ (S3267); extract whole-file PK-order pre-pass into IsFilePkOrderedUpTo (S1199) - Database.Batch/Storage.Append/benchmark: reword explanatory comments flagged as S125 (mark prose as intentional) - benchmark: NOSONAR:S2068 for throwaway local bench credential
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth batch against the SonarCloud new-code dashboard (28 open -> 21, all remaining are S3776 cognitive-complexity):
Validated: SharpCoreDB.Tests 1777/0, CQRS 64/0, both benchmark and test projects build.