Parse Constants - #54

Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom
Zintixx:constants
Sep 27, 2025
Merged

Parse Constants#54
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom
Zintixx:constants

Conversation

@Zintixx

@ZintixxZintixx commented Sep 27, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Summary by CodeRabbit

  • New Features
    • Added support to parse and expose server table constants, enabling access to constant keys from constants data.
  • Tests
    • Added test coverage for constants parsing.
  • Chores
    • Bumped package version to 2.3.3.

@coderabbitai

coderabbitaiBot commented Sep 27, 2025•
edited
Loading

Copy link
Copy Markdown

Walkthrough

Adds constants parsing to ServerTableParser via a new XmlSerializer and ParseConstants() method, updates tests to cover it, and bumps the package version in the project file.

Changes

Cohort / File(s)Summary
Versioning
Maple2.File.Parser/Maple2.File.Parser.csproj		Incremented NuGet PackageVersion from 2.3.2 to 2.3.3.
Parser Core
Maple2.File.Parser/ServerTableParser.cs		Added a private XmlSerializer field for Constants, initialized in constructor; introduced public ParseConstants() yielding (string Key, Constants.Key key) from constants.xml.
Tests
Maple2.File.Tests/ServerTableParserTest.cs		Added using for Maple2.File.Parser.Xml.Table and new TestConstants() to exercise ParseConstants().

Sequence Diagram(s)

sequenceDiagram
participant Client
participant ServerTableParser
participant FS as constants.xml
participant XS as XmlSerializer(Constants)
Client->>ServerTableParser: ParseConstants()
ServerTableParser->>FS: Open/read constants.xml
ServerTableParser->>XS: Deserialize(stream)
XS-->>ServerTableParser: Constants data
loop for each entry in data.v
ServerTableParser-->>Client: yield (Key, Constants.Key)
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • AngeloTadeucci

Poem

A nibble of constants, a hop through the xml,
I twitch my whiskers—new keys start to swell.
Serializer warmed, the tuples align,
Tests thump approval in rhythmic time.
Version hopped forward, 2.3.3’s tune—
Carrots for all, we’ll parse by the moon! 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title “Parse Constants” directly reflects the primary change introduced by the pull request, namely the addition of a new ParseConstants method and constants parsing logic. It is concise and specific, allowing a reviewer to immediately grasp the main feature without extraneous detail. The title avoids vague wording and focuses on the core functionality added. It captures the essence of the change in a single clear phrase.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba88efa and cd815b4.

📒 Files selected for processing (3)
  • Maple2.File.Parser/Maple2.File.Parser.csproj (1 hunks)
  • Maple2.File.Parser/ServerTableParser.cs (4 hunks)
  • Maple2.File.Tests/ServerTableParserTest.cs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-09T04:13:28.776Z
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2.File#36
File: Maple2.File.Tests/TableParserTest.cs:777-783
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the 'Maple2.File' project, tests are designed to ensure methods can be called without errors; do not suggest adding assertions or validations in test methods.

Applied to files:

  • Maple2.File.Tests/ServerTableParserTest.cs
🧬 Code graph analysis (2)
Maple2.File.Tests/ServerTableParserTest.cs (2)
Maple2.File.Parser/ServerTableParser.cs (2)
  • ServerTableParser (21-705)
  • ServerTableParser (63-112)
Maple2.File.Tests/TestUtils.cs (2)
  • TestUtils (11-52)
  • TestUtils (19-43)
Maple2.File.Parser/ServerTableParser.cs (3)
Maple2.File.Parser/TableParser.cs (16)
  • IEnumerable (214-222)
  • IEnumerable (224-232)
  • IEnumerable (234-242)
  • IEnumerable (244-252)
  • IEnumerable (254-264)
  • IEnumerable (266-278)
  • IEnumerable (280-288)
  • IEnumerable (290-298)
  • IEnumerable (300-308)
  • IEnumerable (310-318)
  • IEnumerable (320-328)
  • IEnumerable (330-338)
  • IEnumerable (340-348)
  • IEnumerable (350-364)
  • IEnumerable (366-374)
  • IEnumerable (376-384)
Maple2.File.Parser/Tools/Sanitizer.cs (2)
  • Sanitizer (5-105)
  • RemoveEmpty (85-87)
Maple2.File.IO/M2dReader.cs (2)
  • GetString (64-67)
  • XmlReader (43-45)
🔇 Additional comments (3)
Maple2.File.Parser/Maple2.File.Parser.csproj (1)

16-16: Version bump aligns with new parser surface.

Incrementing to 2.3.3 keeps the package version in step with the new public ParseConstants() entry point.

Maple2.File.Parser/ServerTableParser.cs (1)

695-704: ParseConstants mirrors existing parsing patterns.

Using the shared sanitizer + XmlSerializer pipeline keeps the constants reader consistent with other table parsers, and exposing both key text and the raw model provides flexibility downstream.

Maple2.File.Tests/ServerTableParserTest.cs (1)

440-447: New constant smoke test matches our existing pattern.

Iterating ParseConstants() without extra assertions follows the project’s convention for verifying parser coverage. Based on learnings.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AngeloTadeucci
AngeloTadeucci merged commit 328356c into MS2Community:masterSep 27, 2025
3 checks passed
@coderabbitaicoderabbitaiBot mentioned this pull request Apr 27, 2026
Merged
@coderabbitaicoderabbitaiBot mentioned this pull request Aug 5, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AngeloTadeucciAngeloTadeucciAngeloTadeucci approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zintixx@AngeloTadeucci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Parse Constants - #54
Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Sep 27, 2025
Merged
Parse Constants#54
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Conversation
@Zintixx
@ZintixxZintixx
commented
Sep 27, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary by CodeRabbit
  • New Features
    • Added support to parse and expose server table constants, enabling access to constant keys from constants data.
  • Tests
    • Added test coverage for constants parsing.
  • Chores
    • Bumped package version to 2.3.3.
@coderabbitai
coderabbitaiBot
commented
Sep 27, 2025•

edited

Loading

Copy link


Copy Markdown

Walkthrough
Adds constants parsing to ServerTableParser via a new XmlSerializer and ParseConstants() method, updates tests to cover it, and bumps the package version in the project file.
Changes
Cohort / File(s)Summary
Versioning
Maple2.File.Parser/Maple2.File.Parser.csproj		Incremented NuGet PackageVersion from 2.3.2 to 2.3.3.
Parser Core
Maple2.File.Parser/ServerTableParser.cs		Added a private XmlSerializer field for Constants, initialized in constructor; introduced public ParseConstants() yielding (string Key, Constants.Key key) from constants.xml.
Tests
Maple2.File.Tests/ServerTableParserTest.cs		Added using for Maple2.File.Parser.Xml.Table and new TestConstants() to exercise ParseConstants().
Sequence Diagram(s)
sequenceDiagram
participant Client
participant ServerTableParser
participant FS as constants.xml
participant XS as XmlSerializer(Constants)
Client->>ServerTableParser: ParseConstants()
ServerTableParser->>FS: Open/read constants.xml
ServerTableParser->>XS: Deserialize(stream)
XS-->>ServerTableParser: Constants data
loop for each entry in data.v
ServerTableParser-->>Client: yield (Key, Constants.Key)
end

Loading
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
  • AngeloTadeucci
Poem
A nibble of constants, a hop through the xml,

I twitch my whiskers—new keys start to swell.

Serializer warmed, the tuples align,

Tests thump approval in rhythmic time.

Version hopped forward, 2.3.3’s tune—

Carrots for all, we’ll parse by the moon! 🥕🐇
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title “Parse Constants” directly reflects the primary change introduced by the pull request, namely the addition of a new ParseConstants method and constants parsing logic. It is concise and specific, allowing a reviewer to immediately grasp the main feature without extraneous detail. The title avoids vague wording and focuses on the core functionality added. It captures the essence of the change in a single clear phrase.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between ba88efa and cd815b4.
📒 Files selected for processing (3)
  • Maple2.File.Parser/Maple2.File.Parser.csproj (1 hunks)
  • Maple2.File.Parser/ServerTableParser.cs (4 hunks)
  • Maple2.File.Tests/ServerTableParserTest.cs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-09T04:13:28.776Z
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2.File#36
File: Maple2.File.Tests/TableParserTest.cs:777-783
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the 'Maple2.File' project, tests are designed to ensure methods can be called without errors; do not suggest adding assertions or validations in test methods.

Applied to files:
  • Maple2.File.Tests/ServerTableParserTest.cs
🧬 Code graph analysis (2)
Maple2.File.Tests/ServerTableParserTest.cs (2)
Maple2.File.Parser/ServerTableParser.cs (2)
  • ServerTableParser (21-705)
  • ServerTableParser (63-112)
Maple2.File.Tests/TestUtils.cs (2)
  • TestUtils (11-52)
  • TestUtils (19-43)
Maple2.File.Parser/ServerTableParser.cs (3)
Maple2.File.Parser/TableParser.cs (16)
  • IEnumerable (214-222)
  • IEnumerable (224-232)
  • IEnumerable (234-242)
  • IEnumerable (244-252)
  • IEnumerable (254-264)
  • IEnumerable (266-278)
  • IEnumerable (280-288)
  • IEnumerable (290-298)
  • IEnumerable (300-308)
  • IEnumerable (310-318)
  • IEnumerable (320-328)
  • IEnumerable (330-338)
  • IEnumerable (340-348)
  • IEnumerable (350-364)
  • IEnumerable (366-374)
  • IEnumerable (376-384)
Maple2.File.Parser/Tools/Sanitizer.cs (2)
  • Sanitizer (5-105)
  • RemoveEmpty (85-87)
Maple2.File.IO/M2dReader.cs (2)
  • GetString (64-67)
  • XmlReader (43-45)
🔇 Additional comments (3)
Maple2.File.Parser/Maple2.File.Parser.csproj (1)
16-16: Version bump aligns with new parser surface.
Incrementing to 2.3.3 keeps the package version in step with the new public ParseConstants() entry point.
Maple2.File.Parser/ServerTableParser.cs (1)
695-704: ParseConstants mirrors existing parsing patterns.
Using the shared sanitizer + XmlSerializer pipeline keeps the constants reader consistent with other table parsers, and exposing both key text and the raw model provides flexibility downstream.
Maple2.File.Tests/ServerTableParserTest.cs (1)
440-447: New constant smoke test matches our existing pattern.
Iterating ParseConstants() without extra assertions follows the project’s convention for verifying parser coverage. Based on learnings.
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@AngeloTadeucci
AngeloTadeucci
merged commit 328356c
into
MS2Community:masterSep 27, 2025

3 checks passed

@coderabbitaicoderabbitaiBot
mentioned this pull request
Apr 27, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 5, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AngeloTadeucciAngeloTadeucciAngeloTadeucci approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Zintixx@AngeloTadeucci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Parse Constants - #54
Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Sep 27, 2025
Merged
Parse Constants#54
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Conversation
@Zintixx
@ZintixxZintixx
commented
Sep 27, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary by CodeRabbit
  • New Features
    • Added support to parse and expose server table constants, enabling access to constant keys from constants data.
  • Tests
    • Added test coverage for constants parsing.
  • Chores
    • Bumped package version to 2.3.3.
@coderabbitai
coderabbitaiBot
commented
Sep 27, 2025•

edited

Loading

Copy link


Copy Markdown

Walkthrough
Adds constants parsing to ServerTableParser via a new XmlSerializer and ParseConstants() method, updates tests to cover it, and bumps the package version in the project file.
Changes
Cohort / File(s)Summary
Versioning
Maple2.File.Parser/Maple2.File.Parser.csproj		Incremented NuGet PackageVersion from 2.3.2 to 2.3.3.
Parser Core
Maple2.File.Parser/ServerTableParser.cs		Added a private XmlSerializer field for Constants, initialized in constructor; introduced public ParseConstants() yielding (string Key, Constants.Key key) from constants.xml.
Tests
Maple2.File.Tests/ServerTableParserTest.cs		Added using for Maple2.File.Parser.Xml.Table and new TestConstants() to exercise ParseConstants().
Sequence Diagram(s)
sequenceDiagram
participant Client
participant ServerTableParser
participant FS as constants.xml
participant XS as XmlSerializer(Constants)
Client->>ServerTableParser: ParseConstants()
ServerTableParser->>FS: Open/read constants.xml
ServerTableParser->>XS: Deserialize(stream)
XS-->>ServerTableParser: Constants data
loop for each entry in data.v
ServerTableParser-->>Client: yield (Key, Constants.Key)
end

Loading
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
  • AngeloTadeucci
Poem
A nibble of constants, a hop through the xml,

I twitch my whiskers—new keys start to swell.

Serializer warmed, the tuples align,

Tests thump approval in rhythmic time.

Version hopped forward, 2.3.3’s tune—

Carrots for all, we’ll parse by the moon! 🥕🐇
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title “Parse Constants” directly reflects the primary change introduced by the pull request, namely the addition of a new ParseConstants method and constants parsing logic. It is concise and specific, allowing a reviewer to immediately grasp the main feature without extraneous detail. The title avoids vague wording and focuses on the core functionality added. It captures the essence of the change in a single clear phrase.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between ba88efa and cd815b4.
📒 Files selected for processing (3)
  • Maple2.File.Parser/Maple2.File.Parser.csproj (1 hunks)
  • Maple2.File.Parser/ServerTableParser.cs (4 hunks)
  • Maple2.File.Tests/ServerTableParserTest.cs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-09T04:13:28.776Z
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2.File#36
File: Maple2.File.Tests/TableParserTest.cs:777-783
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the 'Maple2.File' project, tests are designed to ensure methods can be called without errors; do not suggest adding assertions or validations in test methods.

Applied to files:
  • Maple2.File.Tests/ServerTableParserTest.cs
🧬 Code graph analysis (2)
Maple2.File.Tests/ServerTableParserTest.cs (2)
Maple2.File.Parser/ServerTableParser.cs (2)
  • ServerTableParser (21-705)
  • ServerTableParser (63-112)
Maple2.File.Tests/TestUtils.cs (2)
  • TestUtils (11-52)
  • TestUtils (19-43)
Maple2.File.Parser/ServerTableParser.cs (3)
Maple2.File.Parser/TableParser.cs (16)
  • IEnumerable (214-222)
  • IEnumerable (224-232)
  • IEnumerable (234-242)
  • IEnumerable (244-252)
  • IEnumerable (254-264)
  • IEnumerable (266-278)
  • IEnumerable (280-288)
  • IEnumerable (290-298)
  • IEnumerable (300-308)
  • IEnumerable (310-318)
  • IEnumerable (320-328)
  • IEnumerable (330-338)
  • IEnumerable (340-348)
  • IEnumerable (350-364)
  • IEnumerable (366-374)
  • IEnumerable (376-384)
Maple2.File.Parser/Tools/Sanitizer.cs (2)
  • Sanitizer (5-105)
  • RemoveEmpty (85-87)
Maple2.File.IO/M2dReader.cs (2)
  • GetString (64-67)
  • XmlReader (43-45)
🔇 Additional comments (3)
Maple2.File.Parser/Maple2.File.Parser.csproj (1)
16-16: Version bump aligns with new parser surface.
Incrementing to 2.3.3 keeps the package version in step with the new public ParseConstants() entry point.
Maple2.File.Parser/ServerTableParser.cs (1)
695-704: ParseConstants mirrors existing parsing patterns.
Using the shared sanitizer + XmlSerializer pipeline keeps the constants reader consistent with other table parsers, and exposing both key text and the raw model provides flexibility downstream.
Maple2.File.Tests/ServerTableParserTest.cs (1)
440-447: New constant smoke test matches our existing pattern.
Iterating ParseConstants() without extra assertions follows the project’s convention for verifying parser coverage. Based on learnings.
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@AngeloTadeucci
AngeloTadeucci
merged commit 328356c
into
MS2Community:masterSep 27, 2025

3 checks passed

@coderabbitaicoderabbitaiBot
mentioned this pull request
Apr 27, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 5, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AngeloTadeucciAngeloTadeucciAngeloTadeucci approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Zintixx@AngeloTadeucci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Parse Constants - #54
Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Sep 27, 2025
Merged
Parse Constants#54
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Conversation
@Zintixx
@ZintixxZintixx
commented
Sep 27, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary by CodeRabbit
  • New Features
    • Added support to parse and expose server table constants, enabling access to constant keys from constants data.
  • Tests
    • Added test coverage for constants parsing.
  • Chores
    • Bumped package version to 2.3.3.
@coderabbitai
coderabbitaiBot
commented
Sep 27, 2025•

edited

Loading

Copy link


Copy Markdown

Walkthrough
Adds constants parsing to ServerTableParser via a new XmlSerializer and ParseConstants() method, updates tests to cover it, and bumps the package version in the project file.
Changes
Cohort / File(s)Summary
Versioning
Maple2.File.Parser/Maple2.File.Parser.csproj		Incremented NuGet PackageVersion from 2.3.2 to 2.3.3.
Parser Core
Maple2.File.Parser/ServerTableParser.cs		Added a private XmlSerializer field for Constants, initialized in constructor; introduced public ParseConstants() yielding (string Key, Constants.Key key) from constants.xml.
Tests
Maple2.File.Tests/ServerTableParserTest.cs		Added using for Maple2.File.Parser.Xml.Table and new TestConstants() to exercise ParseConstants().
Sequence Diagram(s)
sequenceDiagram
participant Client
participant ServerTableParser
participant FS as constants.xml
participant XS as XmlSerializer(Constants)
Client->>ServerTableParser: ParseConstants()
ServerTableParser->>FS: Open/read constants.xml
ServerTableParser->>XS: Deserialize(stream)
XS-->>ServerTableParser: Constants data
loop for each entry in data.v
ServerTableParser-->>Client: yield (Key, Constants.Key)
end

Loading
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
  • AngeloTadeucci
Poem
A nibble of constants, a hop through the xml,

I twitch my whiskers—new keys start to swell.

Serializer warmed, the tuples align,

Tests thump approval in rhythmic time.

Version hopped forward, 2.3.3’s tune—

Carrots for all, we’ll parse by the moon! 🥕🐇
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title “Parse Constants” directly reflects the primary change introduced by the pull request, namely the addition of a new ParseConstants method and constants parsing logic. It is concise and specific, allowing a reviewer to immediately grasp the main feature without extraneous detail. The title avoids vague wording and focuses on the core functionality added. It captures the essence of the change in a single clear phrase.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between ba88efa and cd815b4.
📒 Files selected for processing (3)
  • Maple2.File.Parser/Maple2.File.Parser.csproj (1 hunks)
  • Maple2.File.Parser/ServerTableParser.cs (4 hunks)
  • Maple2.File.Tests/ServerTableParserTest.cs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-09T04:13:28.776Z
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2.File#36
File: Maple2.File.Tests/TableParserTest.cs:777-783
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the 'Maple2.File' project, tests are designed to ensure methods can be called without errors; do not suggest adding assertions or validations in test methods.

Applied to files:
  • Maple2.File.Tests/ServerTableParserTest.cs
🧬 Code graph analysis (2)
Maple2.File.Tests/ServerTableParserTest.cs (2)
Maple2.File.Parser/ServerTableParser.cs (2)
  • ServerTableParser (21-705)
  • ServerTableParser (63-112)
Maple2.File.Tests/TestUtils.cs (2)
  • TestUtils (11-52)
  • TestUtils (19-43)
Maple2.File.Parser/ServerTableParser.cs (3)
Maple2.File.Parser/TableParser.cs (16)
  • IEnumerable (214-222)
  • IEnumerable (224-232)
  • IEnumerable (234-242)
  • IEnumerable (244-252)
  • IEnumerable (254-264)
  • IEnumerable (266-278)
  • IEnumerable (280-288)
  • IEnumerable (290-298)
  • IEnumerable (300-308)
  • IEnumerable (310-318)
  • IEnumerable (320-328)
  • IEnumerable (330-338)
  • IEnumerable (340-348)
  • IEnumerable (350-364)
  • IEnumerable (366-374)
  • IEnumerable (376-384)
Maple2.File.Parser/Tools/Sanitizer.cs (2)
  • Sanitizer (5-105)
  • RemoveEmpty (85-87)
Maple2.File.IO/M2dReader.cs (2)
  • GetString (64-67)
  • XmlReader (43-45)
🔇 Additional comments (3)
Maple2.File.Parser/Maple2.File.Parser.csproj (1)
16-16: Version bump aligns with new parser surface.
Incrementing to 2.3.3 keeps the package version in step with the new public ParseConstants() entry point.
Maple2.File.Parser/ServerTableParser.cs (1)
695-704: ParseConstants mirrors existing parsing patterns.
Using the shared sanitizer + XmlSerializer pipeline keeps the constants reader consistent with other table parsers, and exposing both key text and the raw model provides flexibility downstream.
Maple2.File.Tests/ServerTableParserTest.cs (1)
440-447: New constant smoke test matches our existing pattern.
Iterating ParseConstants() without extra assertions follows the project’s convention for verifying parser coverage. Based on learnings.
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@AngeloTadeucci
AngeloTadeucci
merged commit 328356c
into
MS2Community:masterSep 27, 2025

3 checks passed

@coderabbitaicoderabbitaiBot
mentioned this pull request
Apr 27, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 5, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AngeloTadeucciAngeloTadeucciAngeloTadeucci approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Zintixx@AngeloTadeucci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Parse Constants - #54
Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Sep 27, 2025
Merged
Parse Constants#54
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Conversation
@Zintixx
@ZintixxZintixx
commented
Sep 27, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary by CodeRabbit
  • New Features
    • Added support to parse and expose server table constants, enabling access to constant keys from constants data.
  • Tests
    • Added test coverage for constants parsing.
  • Chores
    • Bumped package version to 2.3.3.
@coderabbitai
coderabbitaiBot
commented
Sep 27, 2025•

edited

Loading

Copy link


Copy Markdown

Walkthrough
Adds constants parsing to ServerTableParser via a new XmlSerializer and ParseConstants() method, updates tests to cover it, and bumps the package version in the project file.
Changes
Cohort / File(s)Summary
Versioning
Maple2.File.Parser/Maple2.File.Parser.csproj		Incremented NuGet PackageVersion from 2.3.2 to 2.3.3.
Parser Core
Maple2.File.Parser/ServerTableParser.cs		Added a private XmlSerializer field for Constants, initialized in constructor; introduced public ParseConstants() yielding (string Key, Constants.Key key) from constants.xml.
Tests
Maple2.File.Tests/ServerTableParserTest.cs		Added using for Maple2.File.Parser.Xml.Table and new TestConstants() to exercise ParseConstants().
Sequence Diagram(s)
sequenceDiagram
participant Client
participant ServerTableParser
participant FS as constants.xml
participant XS as XmlSerializer(Constants)
Client->>ServerTableParser: ParseConstants()
ServerTableParser->>FS: Open/read constants.xml
ServerTableParser->>XS: Deserialize(stream)
XS-->>ServerTableParser: Constants data
loop for each entry in data.v
ServerTableParser-->>Client: yield (Key, Constants.Key)
end

Loading
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
  • AngeloTadeucci
Poem
A nibble of constants, a hop through the xml,

I twitch my whiskers—new keys start to swell.

Serializer warmed, the tuples align,

Tests thump approval in rhythmic time.

Version hopped forward, 2.3.3’s tune—

Carrots for all, we’ll parse by the moon! 🥕🐇
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title “Parse Constants” directly reflects the primary change introduced by the pull request, namely the addition of a new ParseConstants method and constants parsing logic. It is concise and specific, allowing a reviewer to immediately grasp the main feature without extraneous detail. The title avoids vague wording and focuses on the core functionality added. It captures the essence of the change in a single clear phrase.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between ba88efa and cd815b4.
📒 Files selected for processing (3)
  • Maple2.File.Parser/Maple2.File.Parser.csproj (1 hunks)
  • Maple2.File.Parser/ServerTableParser.cs (4 hunks)
  • Maple2.File.Tests/ServerTableParserTest.cs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-09T04:13:28.776Z
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2.File#36
File: Maple2.File.Tests/TableParserTest.cs:777-783
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the 'Maple2.File' project, tests are designed to ensure methods can be called without errors; do not suggest adding assertions or validations in test methods.

Applied to files:
  • Maple2.File.Tests/ServerTableParserTest.cs
🧬 Code graph analysis (2)
Maple2.File.Tests/ServerTableParserTest.cs (2)
Maple2.File.Parser/ServerTableParser.cs (2)
  • ServerTableParser (21-705)
  • ServerTableParser (63-112)
Maple2.File.Tests/TestUtils.cs (2)
  • TestUtils (11-52)
  • TestUtils (19-43)
Maple2.File.Parser/ServerTableParser.cs (3)
Maple2.File.Parser/TableParser.cs (16)
  • IEnumerable (214-222)
  • IEnumerable (224-232)
  • IEnumerable (234-242)
  • IEnumerable (244-252)
  • IEnumerable (254-264)
  • IEnumerable (266-278)
  • IEnumerable (280-288)
  • IEnumerable (290-298)
  • IEnumerable (300-308)
  • IEnumerable (310-318)
  • IEnumerable (320-328)
  • IEnumerable (330-338)
  • IEnumerable (340-348)
  • IEnumerable (350-364)
  • IEnumerable (366-374)
  • IEnumerable (376-384)
Maple2.File.Parser/Tools/Sanitizer.cs (2)
  • Sanitizer (5-105)
  • RemoveEmpty (85-87)
Maple2.File.IO/M2dReader.cs (2)
  • GetString (64-67)
  • XmlReader (43-45)
🔇 Additional comments (3)
Maple2.File.Parser/Maple2.File.Parser.csproj (1)
16-16: Version bump aligns with new parser surface.
Incrementing to 2.3.3 keeps the package version in step with the new public ParseConstants() entry point.
Maple2.File.Parser/ServerTableParser.cs (1)
695-704: ParseConstants mirrors existing parsing patterns.
Using the shared sanitizer + XmlSerializer pipeline keeps the constants reader consistent with other table parsers, and exposing both key text and the raw model provides flexibility downstream.
Maple2.File.Tests/ServerTableParserTest.cs (1)
440-447: New constant smoke test matches our existing pattern.
Iterating ParseConstants() without extra assertions follows the project’s convention for verifying parser coverage. Based on learnings.
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@AngeloTadeucci
AngeloTadeucci
merged commit 328356c
into
MS2Community:masterSep 27, 2025

3 checks passed

@coderabbitaicoderabbitaiBot
mentioned this pull request
Apr 27, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 5, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AngeloTadeucciAngeloTadeucciAngeloTadeucci approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Zintixx@AngeloTadeucci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Parse Constants - #54
Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Sep 27, 2025
Merged
Parse Constants#54
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Conversation
@Zintixx
@ZintixxZintixx
commented
Sep 27, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary by CodeRabbit
  • New Features
    • Added support to parse and expose server table constants, enabling access to constant keys from constants data.
  • Tests
    • Added test coverage for constants parsing.
  • Chores
    • Bumped package version to 2.3.3.
@coderabbitai
coderabbitaiBot
commented
Sep 27, 2025•

edited

Loading

Copy link


Copy Markdown

Walkthrough
Adds constants parsing to ServerTableParser via a new XmlSerializer and ParseConstants() method, updates tests to cover it, and bumps the package version in the project file.
Changes
Cohort / File(s)Summary
Versioning
Maple2.File.Parser/Maple2.File.Parser.csproj		Incremented NuGet PackageVersion from 2.3.2 to 2.3.3.
Parser Core
Maple2.File.Parser/ServerTableParser.cs		Added a private XmlSerializer field for Constants, initialized in constructor; introduced public ParseConstants() yielding (string Key, Constants.Key key) from constants.xml.
Tests
Maple2.File.Tests/ServerTableParserTest.cs		Added using for Maple2.File.Parser.Xml.Table and new TestConstants() to exercise ParseConstants().
Sequence Diagram(s)
sequenceDiagram
participant Client
participant ServerTableParser
participant FS as constants.xml
participant XS as XmlSerializer(Constants)
Client->>ServerTableParser: ParseConstants()
ServerTableParser->>FS: Open/read constants.xml
ServerTableParser->>XS: Deserialize(stream)
XS-->>ServerTableParser: Constants data
loop for each entry in data.v
ServerTableParser-->>Client: yield (Key, Constants.Key)
end

Loading
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
  • AngeloTadeucci
Poem
A nibble of constants, a hop through the xml,

I twitch my whiskers—new keys start to swell.

Serializer warmed, the tuples align,

Tests thump approval in rhythmic time.

Version hopped forward, 2.3.3’s tune—

Carrots for all, we’ll parse by the moon! 🥕🐇
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title “Parse Constants” directly reflects the primary change introduced by the pull request, namely the addition of a new ParseConstants method and constants parsing logic. It is concise and specific, allowing a reviewer to immediately grasp the main feature without extraneous detail. The title avoids vague wording and focuses on the core functionality added. It captures the essence of the change in a single clear phrase.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between ba88efa and cd815b4.
📒 Files selected for processing (3)
  • Maple2.File.Parser/Maple2.File.Parser.csproj (1 hunks)
  • Maple2.File.Parser/ServerTableParser.cs (4 hunks)
  • Maple2.File.Tests/ServerTableParserTest.cs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-09T04:13:28.776Z
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2.File#36
File: Maple2.File.Tests/TableParserTest.cs:777-783
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the 'Maple2.File' project, tests are designed to ensure methods can be called without errors; do not suggest adding assertions or validations in test methods.

Applied to files:
  • Maple2.File.Tests/ServerTableParserTest.cs
🧬 Code graph analysis (2)
Maple2.File.Tests/ServerTableParserTest.cs (2)
Maple2.File.Parser/ServerTableParser.cs (2)
  • ServerTableParser (21-705)
  • ServerTableParser (63-112)
Maple2.File.Tests/TestUtils.cs (2)
  • TestUtils (11-52)
  • TestUtils (19-43)
Maple2.File.Parser/ServerTableParser.cs (3)
Maple2.File.Parser/TableParser.cs (16)
  • IEnumerable (214-222)
  • IEnumerable (224-232)
  • IEnumerable (234-242)
  • IEnumerable (244-252)
  • IEnumerable (254-264)
  • IEnumerable (266-278)
  • IEnumerable (280-288)
  • IEnumerable (290-298)
  • IEnumerable (300-308)
  • IEnumerable (310-318)
  • IEnumerable (320-328)
  • IEnumerable (330-338)
  • IEnumerable (340-348)
  • IEnumerable (350-364)
  • IEnumerable (366-374)
  • IEnumerable (376-384)
Maple2.File.Parser/Tools/Sanitizer.cs (2)
  • Sanitizer (5-105)
  • RemoveEmpty (85-87)
Maple2.File.IO/M2dReader.cs (2)
  • GetString (64-67)
  • XmlReader (43-45)
🔇 Additional comments (3)
Maple2.File.Parser/Maple2.File.Parser.csproj (1)
16-16: Version bump aligns with new parser surface.
Incrementing to 2.3.3 keeps the package version in step with the new public ParseConstants() entry point.
Maple2.File.Parser/ServerTableParser.cs (1)
695-704: ParseConstants mirrors existing parsing patterns.
Using the shared sanitizer + XmlSerializer pipeline keeps the constants reader consistent with other table parsers, and exposing both key text and the raw model provides flexibility downstream.
Maple2.File.Tests/ServerTableParserTest.cs (1)
440-447: New constant smoke test matches our existing pattern.
Iterating ParseConstants() without extra assertions follows the project’s convention for verifying parser coverage. Based on learnings.
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@AngeloTadeucci
AngeloTadeucci
merged commit 328356c
into
MS2Community:masterSep 27, 2025

3 checks passed

@coderabbitaicoderabbitaiBot
mentioned this pull request
Apr 27, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 5, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AngeloTadeucciAngeloTadeucciAngeloTadeucci approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Zintixx@AngeloTadeucci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Parse Constants - #54
Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Sep 27, 2025
Merged
Parse Constants#54
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Conversation
@Zintixx
@ZintixxZintixx
commented
Sep 27, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary by CodeRabbit
  • New Features
    • Added support to parse and expose server table constants, enabling access to constant keys from constants data.
  • Tests
    • Added test coverage for constants parsing.
  • Chores
    • Bumped package version to 2.3.3.
@coderabbitai
coderabbitaiBot
commented
Sep 27, 2025•

edited

Loading

Copy link


Copy Markdown

Walkthrough
Adds constants parsing to ServerTableParser via a new XmlSerializer and ParseConstants() method, updates tests to cover it, and bumps the package version in the project file.
Changes
Cohort / File(s)Summary
Versioning
Maple2.File.Parser/Maple2.File.Parser.csproj		Incremented NuGet PackageVersion from 2.3.2 to 2.3.3.
Parser Core
Maple2.File.Parser/ServerTableParser.cs		Added a private XmlSerializer field for Constants, initialized in constructor; introduced public ParseConstants() yielding (string Key, Constants.Key key) from constants.xml.
Tests
Maple2.File.Tests/ServerTableParserTest.cs		Added using for Maple2.File.Parser.Xml.Table and new TestConstants() to exercise ParseConstants().
Sequence Diagram(s)
sequenceDiagram
participant Client
participant ServerTableParser
participant FS as constants.xml
participant XS as XmlSerializer(Constants)
Client->>ServerTableParser: ParseConstants()
ServerTableParser->>FS: Open/read constants.xml
ServerTableParser->>XS: Deserialize(stream)
XS-->>ServerTableParser: Constants data
loop for each entry in data.v
ServerTableParser-->>Client: yield (Key, Constants.Key)
end

Loading
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
  • AngeloTadeucci
Poem
A nibble of constants, a hop through the xml,

I twitch my whiskers—new keys start to swell.

Serializer warmed, the tuples align,

Tests thump approval in rhythmic time.

Version hopped forward, 2.3.3’s tune—

Carrots for all, we’ll parse by the moon! 🥕🐇
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title “Parse Constants” directly reflects the primary change introduced by the pull request, namely the addition of a new ParseConstants method and constants parsing logic. It is concise and specific, allowing a reviewer to immediately grasp the main feature without extraneous detail. The title avoids vague wording and focuses on the core functionality added. It captures the essence of the change in a single clear phrase.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between ba88efa and cd815b4.
📒 Files selected for processing (3)
  • Maple2.File.Parser/Maple2.File.Parser.csproj (1 hunks)
  • Maple2.File.Parser/ServerTableParser.cs (4 hunks)
  • Maple2.File.Tests/ServerTableParserTest.cs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-09T04:13:28.776Z
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2.File#36
File: Maple2.File.Tests/TableParserTest.cs:777-783
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the 'Maple2.File' project, tests are designed to ensure methods can be called without errors; do not suggest adding assertions or validations in test methods.

Applied to files:
  • Maple2.File.Tests/ServerTableParserTest.cs
🧬 Code graph analysis (2)
Maple2.File.Tests/ServerTableParserTest.cs (2)
Maple2.File.Parser/ServerTableParser.cs (2)
  • ServerTableParser (21-705)
  • ServerTableParser (63-112)
Maple2.File.Tests/TestUtils.cs (2)
  • TestUtils (11-52)
  • TestUtils (19-43)
Maple2.File.Parser/ServerTableParser.cs (3)
Maple2.File.Parser/TableParser.cs (16)
  • IEnumerable (214-222)
  • IEnumerable (224-232)
  • IEnumerable (234-242)
  • IEnumerable (244-252)
  • IEnumerable (254-264)
  • IEnumerable (266-278)
  • IEnumerable (280-288)
  • IEnumerable (290-298)
  • IEnumerable (300-308)
  • IEnumerable (310-318)
  • IEnumerable (320-328)
  • IEnumerable (330-338)
  • IEnumerable (340-348)
  • IEnumerable (350-364)
  • IEnumerable (366-374)
  • IEnumerable (376-384)
Maple2.File.Parser/Tools/Sanitizer.cs (2)
  • Sanitizer (5-105)
  • RemoveEmpty (85-87)
Maple2.File.IO/M2dReader.cs (2)
  • GetString (64-67)
  • XmlReader (43-45)
🔇 Additional comments (3)
Maple2.File.Parser/Maple2.File.Parser.csproj (1)
16-16: Version bump aligns with new parser surface.
Incrementing to 2.3.3 keeps the package version in step with the new public ParseConstants() entry point.
Maple2.File.Parser/ServerTableParser.cs (1)
695-704: ParseConstants mirrors existing parsing patterns.
Using the shared sanitizer + XmlSerializer pipeline keeps the constants reader consistent with other table parsers, and exposing both key text and the raw model provides flexibility downstream.
Maple2.File.Tests/ServerTableParserTest.cs (1)
440-447: New constant smoke test matches our existing pattern.
Iterating ParseConstants() without extra assertions follows the project’s convention for verifying parser coverage. Based on learnings.
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@AngeloTadeucci
AngeloTadeucci
merged commit 328356c
into
MS2Community:masterSep 27, 2025

3 checks passed

@coderabbitaicoderabbitaiBot
mentioned this pull request
Apr 27, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 5, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AngeloTadeucciAngeloTadeucciAngeloTadeucci approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Zintixx@AngeloTadeucci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Parse Constants - #54
Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Sep 27, 2025
Merged
Parse Constants#54
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom 
Zintixx:constants
Conversation
@Zintixx
@ZintixxZintixx
commented
Sep 27, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Summary by CodeRabbit
  • New Features
    • Added support to parse and expose server table constants, enabling access to constant keys from constants data.
  • Tests
    • Added test coverage for constants parsing.
  • Chores
    • Bumped package version to 2.3.3.
@coderabbitai
coderabbitaiBot
commented
Sep 27, 2025•

edited

Loading

Copy link


Copy Markdown

Walkthrough
Adds constants parsing to ServerTableParser via a new XmlSerializer and ParseConstants() method, updates tests to cover it, and bumps the package version in the project file.
Changes
Cohort / File(s)Summary
Versioning
Maple2.File.Parser/Maple2.File.Parser.csproj		Incremented NuGet PackageVersion from 2.3.2 to 2.3.3.
Parser Core
Maple2.File.Parser/ServerTableParser.cs		Added a private XmlSerializer field for Constants, initialized in constructor; introduced public ParseConstants() yielding (string Key, Constants.Key key) from constants.xml.
Tests
Maple2.File.Tests/ServerTableParserTest.cs		Added using for Maple2.File.Parser.Xml.Table and new TestConstants() to exercise ParseConstants().
Sequence Diagram(s)
sequenceDiagram
participant Client
participant ServerTableParser
participant FS as constants.xml
participant XS as XmlSerializer(Constants)
Client->>ServerTableParser: ParseConstants()
ServerTableParser->>FS: Open/read constants.xml
ServerTableParser->>XS: Deserialize(stream)
XS-->>ServerTableParser: Constants data
loop for each entry in data.v
ServerTableParser-->>Client: yield (Key, Constants.Key)
end

Loading
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
  • AngeloTadeucci
Poem
A nibble of constants, a hop through the xml,

I twitch my whiskers—new keys start to swell.

Serializer warmed, the tuples align,

Tests thump approval in rhythmic time.

Version hopped forward, 2.3.3’s tune—

Carrots for all, we’ll parse by the moon! 🥕🐇
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title “Parse Constants” directly reflects the primary change introduced by the pull request, namely the addition of a new ParseConstants method and constants parsing logic. It is concise and specific, allowing a reviewer to immediately grasp the main feature without extraneous detail. The title avoids vague wording and focuses on the core functionality added. It captures the essence of the change in a single clear phrase.
✨ Finishing touches
  •  📝 Generate Docstrings
🧪 Generate unit tests
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between ba88efa and cd815b4.
📒 Files selected for processing (3)
  • Maple2.File.Parser/Maple2.File.Parser.csproj (1 hunks)
  • Maple2.File.Parser/ServerTableParser.cs (4 hunks)
  • Maple2.File.Tests/ServerTableParserTest.cs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-09T04:13:28.776Z
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2.File#36
File: Maple2.File.Tests/TableParserTest.cs:777-783
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the 'Maple2.File' project, tests are designed to ensure methods can be called without errors; do not suggest adding assertions or validations in test methods.

Applied to files:
  • Maple2.File.Tests/ServerTableParserTest.cs
🧬 Code graph analysis (2)
Maple2.File.Tests/ServerTableParserTest.cs (2)
Maple2.File.Parser/ServerTableParser.cs (2)
  • ServerTableParser (21-705)
  • ServerTableParser (63-112)
Maple2.File.Tests/TestUtils.cs (2)
  • TestUtils (11-52)
  • TestUtils (19-43)
Maple2.File.Parser/ServerTableParser.cs (3)
Maple2.File.Parser/TableParser.cs (16)
  • IEnumerable (214-222)
  • IEnumerable (224-232)
  • IEnumerable (234-242)
  • IEnumerable (244-252)
  • IEnumerable (254-264)
  • IEnumerable (266-278)
  • IEnumerable (280-288)
  • IEnumerable (290-298)
  • IEnumerable (300-308)
  • IEnumerable (310-318)
  • IEnumerable (320-328)
  • IEnumerable (330-338)
  • IEnumerable (340-348)
  • IEnumerable (350-364)
  • IEnumerable (366-374)
  • IEnumerable (376-384)
Maple2.File.Parser/Tools/Sanitizer.cs (2)
  • Sanitizer (5-105)
  • RemoveEmpty (85-87)
Maple2.File.IO/M2dReader.cs (2)
  • GetString (64-67)
  • XmlReader (43-45)
🔇 Additional comments (3)
Maple2.File.Parser/Maple2.File.Parser.csproj (1)
16-16: Version bump aligns with new parser surface.
Incrementing to 2.3.3 keeps the package version in step with the new public ParseConstants() entry point.
Maple2.File.Parser/ServerTableParser.cs (1)
695-704: ParseConstants mirrors existing parsing patterns.
Using the shared sanitizer + XmlSerializer pipeline keeps the constants reader consistent with other table parsers, and exposing both key text and the raw model provides flexibility downstream.
Maple2.File.Tests/ServerTableParserTest.cs (1)
440-447: New constant smoke test matches our existing pattern.
Iterating ParseConstants() without extra assertions follows the project’s convention for verifying parser coverage. Based on learnings.
Tip
👮 Agentic pre-merge checks are now available in preview!
Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
Please see the documentation for more information.
Example:
reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"mode: "warning"instructions: | Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).
Please share your feedback with us on this Discord post.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@AngeloTadeucci
AngeloTadeucci
merged commit 328356c
into
MS2Community:masterSep 27, 2025

3 checks passed

@coderabbitaicoderabbitaiBot
mentioned this pull request
Apr 27, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 5, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AngeloTadeucciAngeloTadeucciAngeloTadeucci approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Zintixx@AngeloTadeucci