Uh oh!
There was an error while loading. Please reload this page.
Parse table/reactor.xml and table/reactorstate.xml - #82
Merged
Conversation
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
`table/reactor.xml` and `table/reactorstate.xml` had no type here, so any
consumer that needs to look up which GameEvent a reactor id belongs to
(Maple2's `<gameEvent eventType="reactor">` gate flows through
`reactor.gameEventId`) would have to hand-roll an `XmlDocument` walk.
- `Xml/Table/Reactor.cs`: `ReactorRoot` locale-filtered by `id` (same row
appears once per locale), then attributes `id`, `reactDistance`,
`reactorStateList`, `connectedEffect`, `gameEventId`, `rewardItemListXml`,
`reactTimeMSec` (defaults 15000), `reactAnimation`, `createAnimation`.
`reactorStateList` and `rewardItemListXml` stay strings on purpose:
the former is `"[100, 101, 102, 103]"` (M2dArray chokes on the `[]`),
the latter is an escaped `<items><v .../></items>` fragment.
- `Xml/Table/ReactorState.cs`: `id`, `type` (connect/sleep/reward),
`nextTimeSec`, `expireTimeSec`, `kfmName`, `startAni`, `idleAni`,
`actionStringKey`, plus a nested `CondItem { code, consume }` element.
Only `connect` states carry a populated `<condItem>`; others self-close.
- `TableParser` gets `ParseReactor()` and `ParseReactorState()` matching
the other `Parse*` methods.
- `PackageVersion` 2.4.21 -> 2.4.22.
`dotnet build` clean. All 150 TableParserTest cases pass, including the
two new ones (`TestReactor`, `TestReactorState`).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>Zintixxforce-pushed
the
parse-reactor-xml
branch
from
August 31, 2026 00:03
aa9057b to
7d0a703CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
table/reactor.xmlandtable/reactorstate.xmlhad no type here, so any consumer that needs to look up which GameEvent a reactor id belongs to (Maple2's<gameEvent eventType="reactor">gate flows throughreactor.gameEventId) would have to hand-roll anXmlDocumentwalk.Xml/Table/Reactor.cs:ReactorRootlocale-filtered byid(same row appears once per locale), then attributesid,reactDistance,reactorStateList,connectedEffect,gameEventId,rewardItemListXml,reactTimeMSec(defaults 15000),reactAnimation,createAnimation.reactorStateListandrewardItemListXmlstay strings on purpose: the former is"[100, 101, 102, 103]"(M2dArray chokes on the[]), the latter is an escaped<items><v .../></items>fragment.Xml/Table/ReactorState.cs:id,type(connect/sleep/reward),nextTimeSec,expireTimeSec,kfmName,startAni,idleAni,actionStringKey, plus a nestedCondItem { code, consume }element. Onlyconnectstates carry a populated<condItem>; others self-close.TableParsergetsParseReactor()andParseReactorState()matching the otherParse*methods.PackageVersion2.4.23 → 2.4.24.Verification
dotnet buildclean. Both new tests (TestReactor,TestReactorState) pass. The one pre-existing failure inTableParserTest(TestFieldMetaData) is from #81 and unrelated to this PR — it looks fortable/na/fieldmetadata.xmlwhich isn't in myMS2_DATA_FOLDER; all 148 other tests pass alongside the two new ones.🤖 Generated with Claude Code