Feat: Implement simpleUiObjects - #535

Merged
AngeloTadeucci merged 1 commit into
masterfrom
extractors
Jul 9, 2025
Merged

Feat: Implement simpleUiObjects#535
AngeloTadeucci merged 1 commit into
masterfrom
extractors

Conversation

@AngeloTadeucci

@AngeloTadeucciAngeloTadeucci commented Jul 9, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

This pr covers interactables like extractors in fields

Summary by CodeRabbit

  • New Features

    • Added support for multiplying a Vector3B by a float, returning a scaled Vector3.

  • Refactor

    • Improved performance and clarity in map entity processing by caching enumerables and enhancing mapping logic.
    • Streamlined NPC removal checks for better code readability.
    • Renamed variables for clarity in the file ingestion process.

  • Style

    • Enhanced coordinate command output to display player position, Vector3B representation, and block center on separate lines for improved readability.

@AngeloTadeucci@gitbutler-client
Feat: Implement simpleUiObjects
72e7e12
This pr covers interactables like extractors in fields
@coderabbitai

coderabbitaiBot commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes introduce a refactor to entity mapping in MapEntityMapper.cs, enhance vector operations in Vector3B, update coordinate output in CoordCommand.cs, adjust NPC existence checks in FieldManager.State.cs, and rename a parser variable in Program.cs. No public API signatures are altered.

Changes

File(s)Change Summary
Maple2.File.Ingest/Mapper/MapEntityMapper.csRefactored ParseMap to cache entities, replaced loops, and added a missing yield for IMS2SimpleUiObject.
Maple2.File.Ingest/Program.csRenamed parser variable to xBlockParser and updated references accordingly.
Maple2.Model/Common/Vector.csAdded multiplication operator overload for Vector3B with float, returning a Vector3.
Maple2.Server.Game/Commands/CoordCommand.csEnhanced coordinate output: added Vector3B and block center calculations in output.
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.csModified RemoveNpc to perform existence checks using discard variables instead of storing NPC instance.

Sequence Diagram(s)

sequenceDiagram
participant Player
participant CoordCommand
participant Vector3B
participant Console
Player->>CoordCommand: Invoke Handle (no coordinates)
CoordCommand->>Vector3B: Convert position to Vector3B
CoordCommand->>Vector3B: Multiply by block size (compute center)
CoordCommand->>Console: Output position, Vector3B, center
Loading

Possibly related PRs

  • AngeloTadeucci/Maple2#434: Also modifies ParseMap in MapEntityMapper.cs, focusing on waypoint flags; both change entity handling logic.
  • AngeloTadeucci/Maple2#521: Alters the RemoveNpc method, changing parameter types and scheduling logic; both touch the same method.
  • AngeloTadeucci/Maple2#359: Removes handling of a specific entity type in ParseMap; both modify entity handling logic in the same method.

Poem

A rabbit hopped through code anew,
Refactoring loops as rabbits do.
Vectors scaled and outputs clear,
NPCs checked with less to fear.
With every hop, the code refined—
A carrot earned for all aligned!
🥕

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6874acd and 72e7e12.

📒 Files selected for processing (5)
  • Maple2.File.Ingest/Mapper/MapEntityMapper.cs (3 hunks)
  • Maple2.File.Ingest/Program.cs (1 hunks)
  • Maple2.Model/Common/Vector.cs (1 hunks)
  • Maple2.Server.Game/Commands/CoordCommand.cs (1 hunks)
  • Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Maple2.Model/Common/Vector.cs (2)
Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.

Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-09-30T04:20:44.252Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.
🧬 Code Graph Analysis (1)
Maple2.Model/Common/Vector.cs (2)
Maple2.Model/Game/User/Home.cs (1)
  • Vector3 (129-149)
Maple2.Server.Game/Model/Field/Entity/FieldMobSpawn.cs (1)
  • Vector3 (180-184)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: format
🔇 Additional comments (6)
Maple2.Model/Common/Vector.cs (1)

43-44: LGTM! Well-implemented multiplication operator.

The operator correctly scales each component of the Vector3B by the float multiplier and returns a Vector3. This enhances the coordinate handling capabilities as demonstrated in the CoordCommand usage.

Maple2.File.Ingest/Program.cs (1)

225-229: Good naming improvement for clarity.

The variable renaming from parser to xBlockParser makes the code more readable and self-documenting. All references have been consistently updated.

Maple2.File.Ingest/Mapper/MapEntityMapper.cs (2)

28-29: Good performance optimization to prevent multiple enumeration.

Caching the entities enumerable to an array prevents multiple enumeration issues and improves performance. The cached array is correctly used in subsequent loops.

60-62: Critical fix: Added missing yield return for SimpleUiObject.

The missing yield return statement for IMS2SimpleUiObject has been properly added, ensuring these entities are correctly returned from the method. This aligns with the PR objective of implementing interactable objects.

Maple2.Server.Game/Commands/CoordCommand.cs (1)

39-42: Enhanced coordinate output with improved formatting.

The addition of Vector3B conversion and block center calculation using the new multiplication operator provides more comprehensive coordinate information. The multi-line output format improves readability and debugging capability.

Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1)

753-753: Good use of discard variables for existence check.

The change from capturing NPC instances to using discard variables (_) makes the code intent clearer - this check only verifies existence rather than needing the actual NPC object. The removal logic later in the method properly handles NPC retrieval and disposal.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AngeloTadeucci
AngeloTadeucci merged commit 44f4135 into masterJul 9, 2025
@AngeloTadeucci
AngeloTadeucci deleted the extractors branch July 9, 2025 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AngeloTadeucci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Feat: Implement simpleUiObjects - #535

Merged
AngeloTadeucci merged 1 commit into
masterfrom
extractors
Jul 9, 2025
Merged

Feat: Implement simpleUiObjects#535
AngeloTadeucci merged 1 commit into
masterfrom
extractors

Conversation

@AngeloTadeucci

@AngeloTadeucciAngeloTadeucci commented Jul 9, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

This pr covers interactables like extractors in fields

Summary by CodeRabbit

  • New Features

    • Added support for multiplying a Vector3B by a float, returning a scaled Vector3.

  • Refactor

    • Improved performance and clarity in map entity processing by caching enumerables and enhancing mapping logic.
    • Streamlined NPC removal checks for better code readability.
    • Renamed variables for clarity in the file ingestion process.

  • Style

    • Enhanced coordinate command output to display player position, Vector3B representation, and block center on separate lines for improved readability.

@AngeloTadeucci@gitbutler-client
Feat: Implement simpleUiObjects
72e7e12
This pr covers interactables like extractors in fields
@coderabbitai

coderabbitaiBot commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes introduce a refactor to entity mapping in MapEntityMapper.cs, enhance vector operations in Vector3B, update coordinate output in CoordCommand.cs, adjust NPC existence checks in FieldManager.State.cs, and rename a parser variable in Program.cs. No public API signatures are altered.

Changes

File(s)Change Summary
Maple2.File.Ingest/Mapper/MapEntityMapper.csRefactored ParseMap to cache entities, replaced loops, and added a missing yield for IMS2SimpleUiObject.
Maple2.File.Ingest/Program.csRenamed parser variable to xBlockParser and updated references accordingly.
Maple2.Model/Common/Vector.csAdded multiplication operator overload for Vector3B with float, returning a Vector3.
Maple2.Server.Game/Commands/CoordCommand.csEnhanced coordinate output: added Vector3B and block center calculations in output.
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.csModified RemoveNpc to perform existence checks using discard variables instead of storing NPC instance.

Sequence Diagram(s)

sequenceDiagram
participant Player
participant CoordCommand
participant Vector3B
participant Console
Player->>CoordCommand: Invoke Handle (no coordinates)
CoordCommand->>Vector3B: Convert position to Vector3B
CoordCommand->>Vector3B: Multiply by block size (compute center)
CoordCommand->>Console: Output position, Vector3B, center
Loading

Possibly related PRs

  • AngeloTadeucci/Maple2#434: Also modifies ParseMap in MapEntityMapper.cs, focusing on waypoint flags; both change entity handling logic.
  • AngeloTadeucci/Maple2#521: Alters the RemoveNpc method, changing parameter types and scheduling logic; both touch the same method.
  • AngeloTadeucci/Maple2#359: Removes handling of a specific entity type in ParseMap; both modify entity handling logic in the same method.

Poem

A rabbit hopped through code anew,
Refactoring loops as rabbits do.
Vectors scaled and outputs clear,
NPCs checked with less to fear.
With every hop, the code refined—
A carrot earned for all aligned!
🥕

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6874acd and 72e7e12.

📒 Files selected for processing (5)
  • Maple2.File.Ingest/Mapper/MapEntityMapper.cs (3 hunks)
  • Maple2.File.Ingest/Program.cs (1 hunks)
  • Maple2.Model/Common/Vector.cs (1 hunks)
  • Maple2.Server.Game/Commands/CoordCommand.cs (1 hunks)
  • Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Maple2.Model/Common/Vector.cs (2)
Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.

Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-09-30T04:20:44.252Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.
🧬 Code Graph Analysis (1)
Maple2.Model/Common/Vector.cs (2)
Maple2.Model/Game/User/Home.cs (1)
  • Vector3 (129-149)
Maple2.Server.Game/Model/Field/Entity/FieldMobSpawn.cs (1)
  • Vector3 (180-184)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: format
🔇 Additional comments (6)
Maple2.Model/Common/Vector.cs (1)

43-44: LGTM! Well-implemented multiplication operator.

The operator correctly scales each component of the Vector3B by the float multiplier and returns a Vector3. This enhances the coordinate handling capabilities as demonstrated in the CoordCommand usage.

Maple2.File.Ingest/Program.cs (1)

225-229: Good naming improvement for clarity.

The variable renaming from parser to xBlockParser makes the code more readable and self-documenting. All references have been consistently updated.

Maple2.File.Ingest/Mapper/MapEntityMapper.cs (2)

28-29: Good performance optimization to prevent multiple enumeration.

Caching the entities enumerable to an array prevents multiple enumeration issues and improves performance. The cached array is correctly used in subsequent loops.

60-62: Critical fix: Added missing yield return for SimpleUiObject.

The missing yield return statement for IMS2SimpleUiObject has been properly added, ensuring these entities are correctly returned from the method. This aligns with the PR objective of implementing interactable objects.

Maple2.Server.Game/Commands/CoordCommand.cs (1)

39-42: Enhanced coordinate output with improved formatting.

The addition of Vector3B conversion and block center calculation using the new multiplication operator provides more comprehensive coordinate information. The multi-line output format improves readability and debugging capability.

Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1)

753-753: Good use of discard variables for existence check.

The change from capturing NPC instances to using discard variables (_) makes the code intent clearer - this check only verifies existence rather than needing the actual NPC object. The removal logic later in the method properly handles NPC retrieval and disposal.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AngeloTadeucci
AngeloTadeucci merged commit 44f4135 into masterJul 9, 2025
@AngeloTadeucci
AngeloTadeucci deleted the extractors branch July 9, 2025 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AngeloTadeucci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Feat: Implement simpleUiObjects - #535

Merged
AngeloTadeucci merged 1 commit into
masterfrom
extractors
Jul 9, 2025
Merged

Feat: Implement simpleUiObjects#535
AngeloTadeucci merged 1 commit into
masterfrom
extractors

Conversation

@AngeloTadeucci

@AngeloTadeucciAngeloTadeucci commented Jul 9, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

This pr covers interactables like extractors in fields

Summary by CodeRabbit

  • New Features

    • Added support for multiplying a Vector3B by a float, returning a scaled Vector3.

  • Refactor

    • Improved performance and clarity in map entity processing by caching enumerables and enhancing mapping logic.
    • Streamlined NPC removal checks for better code readability.
    • Renamed variables for clarity in the file ingestion process.

  • Style

    • Enhanced coordinate command output to display player position, Vector3B representation, and block center on separate lines for improved readability.

@AngeloTadeucci@gitbutler-client
Feat: Implement simpleUiObjects
72e7e12
This pr covers interactables like extractors in fields
@coderabbitai

coderabbitaiBot commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes introduce a refactor to entity mapping in MapEntityMapper.cs, enhance vector operations in Vector3B, update coordinate output in CoordCommand.cs, adjust NPC existence checks in FieldManager.State.cs, and rename a parser variable in Program.cs. No public API signatures are altered.

Changes

File(s)Change Summary
Maple2.File.Ingest/Mapper/MapEntityMapper.csRefactored ParseMap to cache entities, replaced loops, and added a missing yield for IMS2SimpleUiObject.
Maple2.File.Ingest/Program.csRenamed parser variable to xBlockParser and updated references accordingly.
Maple2.Model/Common/Vector.csAdded multiplication operator overload for Vector3B with float, returning a Vector3.
Maple2.Server.Game/Commands/CoordCommand.csEnhanced coordinate output: added Vector3B and block center calculations in output.
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.csModified RemoveNpc to perform existence checks using discard variables instead of storing NPC instance.

Sequence Diagram(s)

sequenceDiagram
participant Player
participant CoordCommand
participant Vector3B
participant Console
Player->>CoordCommand: Invoke Handle (no coordinates)
CoordCommand->>Vector3B: Convert position to Vector3B
CoordCommand->>Vector3B: Multiply by block size (compute center)
CoordCommand->>Console: Output position, Vector3B, center
Loading

Possibly related PRs

  • AngeloTadeucci/Maple2#434: Also modifies ParseMap in MapEntityMapper.cs, focusing on waypoint flags; both change entity handling logic.
  • AngeloTadeucci/Maple2#521: Alters the RemoveNpc method, changing parameter types and scheduling logic; both touch the same method.
  • AngeloTadeucci/Maple2#359: Removes handling of a specific entity type in ParseMap; both modify entity handling logic in the same method.

Poem

A rabbit hopped through code anew,
Refactoring loops as rabbits do.
Vectors scaled and outputs clear,
NPCs checked with less to fear.
With every hop, the code refined—
A carrot earned for all aligned!
🥕

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6874acd and 72e7e12.

📒 Files selected for processing (5)
  • Maple2.File.Ingest/Mapper/MapEntityMapper.cs (3 hunks)
  • Maple2.File.Ingest/Program.cs (1 hunks)
  • Maple2.Model/Common/Vector.cs (1 hunks)
  • Maple2.Server.Game/Commands/CoordCommand.cs (1 hunks)
  • Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Maple2.Model/Common/Vector.cs (2)
Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.

Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-09-30T04:20:44.252Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.
🧬 Code Graph Analysis (1)
Maple2.Model/Common/Vector.cs (2)
Maple2.Model/Game/User/Home.cs (1)
  • Vector3 (129-149)
Maple2.Server.Game/Model/Field/Entity/FieldMobSpawn.cs (1)
  • Vector3 (180-184)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: format
🔇 Additional comments (6)
Maple2.Model/Common/Vector.cs (1)

43-44: LGTM! Well-implemented multiplication operator.

The operator correctly scales each component of the Vector3B by the float multiplier and returns a Vector3. This enhances the coordinate handling capabilities as demonstrated in the CoordCommand usage.

Maple2.File.Ingest/Program.cs (1)

225-229: Good naming improvement for clarity.

The variable renaming from parser to xBlockParser makes the code more readable and self-documenting. All references have been consistently updated.

Maple2.File.Ingest/Mapper/MapEntityMapper.cs (2)

28-29: Good performance optimization to prevent multiple enumeration.

Caching the entities enumerable to an array prevents multiple enumeration issues and improves performance. The cached array is correctly used in subsequent loops.

60-62: Critical fix: Added missing yield return for SimpleUiObject.

The missing yield return statement for IMS2SimpleUiObject has been properly added, ensuring these entities are correctly returned from the method. This aligns with the PR objective of implementing interactable objects.

Maple2.Server.Game/Commands/CoordCommand.cs (1)

39-42: Enhanced coordinate output with improved formatting.

The addition of Vector3B conversion and block center calculation using the new multiplication operator provides more comprehensive coordinate information. The multi-line output format improves readability and debugging capability.

Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1)

753-753: Good use of discard variables for existence check.

The change from capturing NPC instances to using discard variables (_) makes the code intent clearer - this check only verifies existence rather than needing the actual NPC object. The removal logic later in the method properly handles NPC retrieval and disposal.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AngeloTadeucci
AngeloTadeucci merged commit 44f4135 into masterJul 9, 2025
@AngeloTadeucci
AngeloTadeucci deleted the extractors branch July 9, 2025 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AngeloTadeucci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Feat: Implement simpleUiObjects - #535

Merged
AngeloTadeucci merged 1 commit into
masterfrom
extractors
Jul 9, 2025
Merged

Feat: Implement simpleUiObjects#535
AngeloTadeucci merged 1 commit into
masterfrom
extractors

Conversation

@AngeloTadeucci

@AngeloTadeucciAngeloTadeucci commented Jul 9, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

This pr covers interactables like extractors in fields

Summary by CodeRabbit

  • New Features

    • Added support for multiplying a Vector3B by a float, returning a scaled Vector3.

  • Refactor

    • Improved performance and clarity in map entity processing by caching enumerables and enhancing mapping logic.
    • Streamlined NPC removal checks for better code readability.
    • Renamed variables for clarity in the file ingestion process.

  • Style

    • Enhanced coordinate command output to display player position, Vector3B representation, and block center on separate lines for improved readability.

@AngeloTadeucci@gitbutler-client
Feat: Implement simpleUiObjects
72e7e12
This pr covers interactables like extractors in fields
@coderabbitai

coderabbitaiBot commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes introduce a refactor to entity mapping in MapEntityMapper.cs, enhance vector operations in Vector3B, update coordinate output in CoordCommand.cs, adjust NPC existence checks in FieldManager.State.cs, and rename a parser variable in Program.cs. No public API signatures are altered.

Changes

File(s)Change Summary
Maple2.File.Ingest/Mapper/MapEntityMapper.csRefactored ParseMap to cache entities, replaced loops, and added a missing yield for IMS2SimpleUiObject.
Maple2.File.Ingest/Program.csRenamed parser variable to xBlockParser and updated references accordingly.
Maple2.Model/Common/Vector.csAdded multiplication operator overload for Vector3B with float, returning a Vector3.
Maple2.Server.Game/Commands/CoordCommand.csEnhanced coordinate output: added Vector3B and block center calculations in output.
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.csModified RemoveNpc to perform existence checks using discard variables instead of storing NPC instance.

Sequence Diagram(s)

sequenceDiagram
participant Player
participant CoordCommand
participant Vector3B
participant Console
Player->>CoordCommand: Invoke Handle (no coordinates)
CoordCommand->>Vector3B: Convert position to Vector3B
CoordCommand->>Vector3B: Multiply by block size (compute center)
CoordCommand->>Console: Output position, Vector3B, center
Loading

Possibly related PRs

  • AngeloTadeucci/Maple2#434: Also modifies ParseMap in MapEntityMapper.cs, focusing on waypoint flags; both change entity handling logic.
  • AngeloTadeucci/Maple2#521: Alters the RemoveNpc method, changing parameter types and scheduling logic; both touch the same method.
  • AngeloTadeucci/Maple2#359: Removes handling of a specific entity type in ParseMap; both modify entity handling logic in the same method.

Poem

A rabbit hopped through code anew,
Refactoring loops as rabbits do.
Vectors scaled and outputs clear,
NPCs checked with less to fear.
With every hop, the code refined—
A carrot earned for all aligned!
🥕

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6874acd and 72e7e12.

📒 Files selected for processing (5)
  • Maple2.File.Ingest/Mapper/MapEntityMapper.cs (3 hunks)
  • Maple2.File.Ingest/Program.cs (1 hunks)
  • Maple2.Model/Common/Vector.cs (1 hunks)
  • Maple2.Server.Game/Commands/CoordCommand.cs (1 hunks)
  • Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Maple2.Model/Common/Vector.cs (2)
Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.

Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-09-30T04:20:44.252Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.
🧬 Code Graph Analysis (1)
Maple2.Model/Common/Vector.cs (2)
Maple2.Model/Game/User/Home.cs (1)
  • Vector3 (129-149)
Maple2.Server.Game/Model/Field/Entity/FieldMobSpawn.cs (1)
  • Vector3 (180-184)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: format
🔇 Additional comments (6)
Maple2.Model/Common/Vector.cs (1)

43-44: LGTM! Well-implemented multiplication operator.

The operator correctly scales each component of the Vector3B by the float multiplier and returns a Vector3. This enhances the coordinate handling capabilities as demonstrated in the CoordCommand usage.

Maple2.File.Ingest/Program.cs (1)

225-229: Good naming improvement for clarity.

The variable renaming from parser to xBlockParser makes the code more readable and self-documenting. All references have been consistently updated.

Maple2.File.Ingest/Mapper/MapEntityMapper.cs (2)

28-29: Good performance optimization to prevent multiple enumeration.

Caching the entities enumerable to an array prevents multiple enumeration issues and improves performance. The cached array is correctly used in subsequent loops.

60-62: Critical fix: Added missing yield return for SimpleUiObject.

The missing yield return statement for IMS2SimpleUiObject has been properly added, ensuring these entities are correctly returned from the method. This aligns with the PR objective of implementing interactable objects.

Maple2.Server.Game/Commands/CoordCommand.cs (1)

39-42: Enhanced coordinate output with improved formatting.

The addition of Vector3B conversion and block center calculation using the new multiplication operator provides more comprehensive coordinate information. The multi-line output format improves readability and debugging capability.

Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1)

753-753: Good use of discard variables for existence check.

The change from capturing NPC instances to using discard variables (_) makes the code intent clearer - this check only verifies existence rather than needing the actual NPC object. The removal logic later in the method properly handles NPC retrieval and disposal.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AngeloTadeucci
AngeloTadeucci merged commit 44f4135 into masterJul 9, 2025
@AngeloTadeucci
AngeloTadeucci deleted the extractors branch July 9, 2025 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AngeloTadeucci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Feat: Implement simpleUiObjects - #535

Merged
AngeloTadeucci merged 1 commit into
masterfrom
extractors
Jul 9, 2025
Merged

Feat: Implement simpleUiObjects#535
AngeloTadeucci merged 1 commit into
masterfrom
extractors

Conversation

@AngeloTadeucci

@AngeloTadeucciAngeloTadeucci commented Jul 9, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

This pr covers interactables like extractors in fields

Summary by CodeRabbit

  • New Features

    • Added support for multiplying a Vector3B by a float, returning a scaled Vector3.

  • Refactor

    • Improved performance and clarity in map entity processing by caching enumerables and enhancing mapping logic.
    • Streamlined NPC removal checks for better code readability.
    • Renamed variables for clarity in the file ingestion process.

  • Style

    • Enhanced coordinate command output to display player position, Vector3B representation, and block center on separate lines for improved readability.

@AngeloTadeucci@gitbutler-client
Feat: Implement simpleUiObjects
72e7e12
This pr covers interactables like extractors in fields
@coderabbitai

coderabbitaiBot commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes introduce a refactor to entity mapping in MapEntityMapper.cs, enhance vector operations in Vector3B, update coordinate output in CoordCommand.cs, adjust NPC existence checks in FieldManager.State.cs, and rename a parser variable in Program.cs. No public API signatures are altered.

Changes

File(s)Change Summary
Maple2.File.Ingest/Mapper/MapEntityMapper.csRefactored ParseMap to cache entities, replaced loops, and added a missing yield for IMS2SimpleUiObject.
Maple2.File.Ingest/Program.csRenamed parser variable to xBlockParser and updated references accordingly.
Maple2.Model/Common/Vector.csAdded multiplication operator overload for Vector3B with float, returning a Vector3.
Maple2.Server.Game/Commands/CoordCommand.csEnhanced coordinate output: added Vector3B and block center calculations in output.
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.csModified RemoveNpc to perform existence checks using discard variables instead of storing NPC instance.

Sequence Diagram(s)

sequenceDiagram
participant Player
participant CoordCommand
participant Vector3B
participant Console
Player->>CoordCommand: Invoke Handle (no coordinates)
CoordCommand->>Vector3B: Convert position to Vector3B
CoordCommand->>Vector3B: Multiply by block size (compute center)
CoordCommand->>Console: Output position, Vector3B, center
Loading

Possibly related PRs

  • AngeloTadeucci/Maple2#434: Also modifies ParseMap in MapEntityMapper.cs, focusing on waypoint flags; both change entity handling logic.
  • AngeloTadeucci/Maple2#521: Alters the RemoveNpc method, changing parameter types and scheduling logic; both touch the same method.
  • AngeloTadeucci/Maple2#359: Removes handling of a specific entity type in ParseMap; both modify entity handling logic in the same method.

Poem

A rabbit hopped through code anew,
Refactoring loops as rabbits do.
Vectors scaled and outputs clear,
NPCs checked with less to fear.
With every hop, the code refined—
A carrot earned for all aligned!
🥕

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6874acd and 72e7e12.

📒 Files selected for processing (5)
  • Maple2.File.Ingest/Mapper/MapEntityMapper.cs (3 hunks)
  • Maple2.File.Ingest/Program.cs (1 hunks)
  • Maple2.Model/Common/Vector.cs (1 hunks)
  • Maple2.Server.Game/Commands/CoordCommand.cs (1 hunks)
  • Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Maple2.Model/Common/Vector.cs (2)
Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.

Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-09-30T04:20:44.252Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.
🧬 Code Graph Analysis (1)
Maple2.Model/Common/Vector.cs (2)
Maple2.Model/Game/User/Home.cs (1)
  • Vector3 (129-149)
Maple2.Server.Game/Model/Field/Entity/FieldMobSpawn.cs (1)
  • Vector3 (180-184)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: format
🔇 Additional comments (6)
Maple2.Model/Common/Vector.cs (1)

43-44: LGTM! Well-implemented multiplication operator.

The operator correctly scales each component of the Vector3B by the float multiplier and returns a Vector3. This enhances the coordinate handling capabilities as demonstrated in the CoordCommand usage.

Maple2.File.Ingest/Program.cs (1)

225-229: Good naming improvement for clarity.

The variable renaming from parser to xBlockParser makes the code more readable and self-documenting. All references have been consistently updated.

Maple2.File.Ingest/Mapper/MapEntityMapper.cs (2)

28-29: Good performance optimization to prevent multiple enumeration.

Caching the entities enumerable to an array prevents multiple enumeration issues and improves performance. The cached array is correctly used in subsequent loops.

60-62: Critical fix: Added missing yield return for SimpleUiObject.

The missing yield return statement for IMS2SimpleUiObject has been properly added, ensuring these entities are correctly returned from the method. This aligns with the PR objective of implementing interactable objects.

Maple2.Server.Game/Commands/CoordCommand.cs (1)

39-42: Enhanced coordinate output with improved formatting.

The addition of Vector3B conversion and block center calculation using the new multiplication operator provides more comprehensive coordinate information. The multi-line output format improves readability and debugging capability.

Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1)

753-753: Good use of discard variables for existence check.

The change from capturing NPC instances to using discard variables (_) makes the code intent clearer - this check only verifies existence rather than needing the actual NPC object. The removal logic later in the method properly handles NPC retrieval and disposal.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AngeloTadeucci
AngeloTadeucci merged commit 44f4135 into masterJul 9, 2025
@AngeloTadeucci
AngeloTadeucci deleted the extractors branch July 9, 2025 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AngeloTadeucci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Feat: Implement simpleUiObjects - #535

Merged
AngeloTadeucci merged 1 commit into
masterfrom
extractors
Jul 9, 2025
Merged

Feat: Implement simpleUiObjects#535
AngeloTadeucci merged 1 commit into
masterfrom
extractors

Conversation

@AngeloTadeucci

@AngeloTadeucciAngeloTadeucci commented Jul 9, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

This pr covers interactables like extractors in fields

Summary by CodeRabbit

  • New Features

    • Added support for multiplying a Vector3B by a float, returning a scaled Vector3.

  • Refactor

    • Improved performance and clarity in map entity processing by caching enumerables and enhancing mapping logic.
    • Streamlined NPC removal checks for better code readability.
    • Renamed variables for clarity in the file ingestion process.

  • Style

    • Enhanced coordinate command output to display player position, Vector3B representation, and block center on separate lines for improved readability.

@AngeloTadeucci@gitbutler-client
Feat: Implement simpleUiObjects
72e7e12
This pr covers interactables like extractors in fields
@coderabbitai

coderabbitaiBot commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes introduce a refactor to entity mapping in MapEntityMapper.cs, enhance vector operations in Vector3B, update coordinate output in CoordCommand.cs, adjust NPC existence checks in FieldManager.State.cs, and rename a parser variable in Program.cs. No public API signatures are altered.

Changes

File(s)Change Summary
Maple2.File.Ingest/Mapper/MapEntityMapper.csRefactored ParseMap to cache entities, replaced loops, and added a missing yield for IMS2SimpleUiObject.
Maple2.File.Ingest/Program.csRenamed parser variable to xBlockParser and updated references accordingly.
Maple2.Model/Common/Vector.csAdded multiplication operator overload for Vector3B with float, returning a Vector3.
Maple2.Server.Game/Commands/CoordCommand.csEnhanced coordinate output: added Vector3B and block center calculations in output.
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.csModified RemoveNpc to perform existence checks using discard variables instead of storing NPC instance.

Sequence Diagram(s)

sequenceDiagram
participant Player
participant CoordCommand
participant Vector3B
participant Console
Player->>CoordCommand: Invoke Handle (no coordinates)
CoordCommand->>Vector3B: Convert position to Vector3B
CoordCommand->>Vector3B: Multiply by block size (compute center)
CoordCommand->>Console: Output position, Vector3B, center
Loading

Possibly related PRs

  • AngeloTadeucci/Maple2#434: Also modifies ParseMap in MapEntityMapper.cs, focusing on waypoint flags; both change entity handling logic.
  • AngeloTadeucci/Maple2#521: Alters the RemoveNpc method, changing parameter types and scheduling logic; both touch the same method.
  • AngeloTadeucci/Maple2#359: Removes handling of a specific entity type in ParseMap; both modify entity handling logic in the same method.

Poem

A rabbit hopped through code anew,
Refactoring loops as rabbits do.
Vectors scaled and outputs clear,
NPCs checked with less to fear.
With every hop, the code refined—
A carrot earned for all aligned!
🥕

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6874acd and 72e7e12.

📒 Files selected for processing (5)
  • Maple2.File.Ingest/Mapper/MapEntityMapper.cs (3 hunks)
  • Maple2.File.Ingest/Program.cs (1 hunks)
  • Maple2.Model/Common/Vector.cs (1 hunks)
  • Maple2.Server.Game/Commands/CoordCommand.cs (1 hunks)
  • Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Maple2.Model/Common/Vector.cs (2)
Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.

Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-09-30T04:20:44.252Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.
🧬 Code Graph Analysis (1)
Maple2.Model/Common/Vector.cs (2)
Maple2.Model/Game/User/Home.cs (1)
  • Vector3 (129-149)
Maple2.Server.Game/Model/Field/Entity/FieldMobSpawn.cs (1)
  • Vector3 (180-184)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: format
🔇 Additional comments (6)
Maple2.Model/Common/Vector.cs (1)

43-44: LGTM! Well-implemented multiplication operator.

The operator correctly scales each component of the Vector3B by the float multiplier and returns a Vector3. This enhances the coordinate handling capabilities as demonstrated in the CoordCommand usage.

Maple2.File.Ingest/Program.cs (1)

225-229: Good naming improvement for clarity.

The variable renaming from parser to xBlockParser makes the code more readable and self-documenting. All references have been consistently updated.

Maple2.File.Ingest/Mapper/MapEntityMapper.cs (2)

28-29: Good performance optimization to prevent multiple enumeration.

Caching the entities enumerable to an array prevents multiple enumeration issues and improves performance. The cached array is correctly used in subsequent loops.

60-62: Critical fix: Added missing yield return for SimpleUiObject.

The missing yield return statement for IMS2SimpleUiObject has been properly added, ensuring these entities are correctly returned from the method. This aligns with the PR objective of implementing interactable objects.

Maple2.Server.Game/Commands/CoordCommand.cs (1)

39-42: Enhanced coordinate output with improved formatting.

The addition of Vector3B conversion and block center calculation using the new multiplication operator provides more comprehensive coordinate information. The multi-line output format improves readability and debugging capability.

Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1)

753-753: Good use of discard variables for existence check.

The change from capturing NPC instances to using discard variables (_) makes the code intent clearer - this check only verifies existence rather than needing the actual NPC object. The removal logic later in the method properly handles NPC retrieval and disposal.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AngeloTadeucci
AngeloTadeucci merged commit 44f4135 into masterJul 9, 2025
@AngeloTadeucci
AngeloTadeucci deleted the extractors branch July 9, 2025 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AngeloTadeucci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Feat: Implement simpleUiObjects - #535

Merged
AngeloTadeucci merged 1 commit into
masterfrom
extractors
Jul 9, 2025
Merged

Feat: Implement simpleUiObjects#535
AngeloTadeucci merged 1 commit into
masterfrom
extractors

Conversation

@AngeloTadeucci

@AngeloTadeucciAngeloTadeucci commented Jul 9, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

This pr covers interactables like extractors in fields

Summary by CodeRabbit

  • New Features

    • Added support for multiplying a Vector3B by a float, returning a scaled Vector3.

  • Refactor

    • Improved performance and clarity in map entity processing by caching enumerables and enhancing mapping logic.
    • Streamlined NPC removal checks for better code readability.
    • Renamed variables for clarity in the file ingestion process.

  • Style

    • Enhanced coordinate command output to display player position, Vector3B representation, and block center on separate lines for improved readability.

@AngeloTadeucci@gitbutler-client
Feat: Implement simpleUiObjects
72e7e12
This pr covers interactables like extractors in fields
@coderabbitai

coderabbitaiBot commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes introduce a refactor to entity mapping in MapEntityMapper.cs, enhance vector operations in Vector3B, update coordinate output in CoordCommand.cs, adjust NPC existence checks in FieldManager.State.cs, and rename a parser variable in Program.cs. No public API signatures are altered.

Changes

File(s)Change Summary
Maple2.File.Ingest/Mapper/MapEntityMapper.csRefactored ParseMap to cache entities, replaced loops, and added a missing yield for IMS2SimpleUiObject.
Maple2.File.Ingest/Program.csRenamed parser variable to xBlockParser and updated references accordingly.
Maple2.Model/Common/Vector.csAdded multiplication operator overload for Vector3B with float, returning a Vector3.
Maple2.Server.Game/Commands/CoordCommand.csEnhanced coordinate output: added Vector3B and block center calculations in output.
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.csModified RemoveNpc to perform existence checks using discard variables instead of storing NPC instance.

Sequence Diagram(s)

sequenceDiagram
participant Player
participant CoordCommand
participant Vector3B
participant Console
Player->>CoordCommand: Invoke Handle (no coordinates)
CoordCommand->>Vector3B: Convert position to Vector3B
CoordCommand->>Vector3B: Multiply by block size (compute center)
CoordCommand->>Console: Output position, Vector3B, center
Loading

Possibly related PRs

  • AngeloTadeucci/Maple2#434: Also modifies ParseMap in MapEntityMapper.cs, focusing on waypoint flags; both change entity handling logic.
  • AngeloTadeucci/Maple2#521: Alters the RemoveNpc method, changing parameter types and scheduling logic; both touch the same method.
  • AngeloTadeucci/Maple2#359: Removes handling of a specific entity type in ParseMap; both modify entity handling logic in the same method.

Poem

A rabbit hopped through code anew,
Refactoring loops as rabbits do.
Vectors scaled and outputs clear,
NPCs checked with less to fear.
With every hop, the code refined—
A carrot earned for all aligned!
🥕

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6874acd and 72e7e12.

📒 Files selected for processing (5)
  • Maple2.File.Ingest/Mapper/MapEntityMapper.cs (3 hunks)
  • Maple2.File.Ingest/Program.cs (1 hunks)
  • Maple2.Model/Common/Vector.cs (1 hunks)
  • Maple2.Server.Game/Commands/CoordCommand.cs (1 hunks)
  • Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Maple2.Model/Common/Vector.cs (2)
Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.

Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-09-30T04:20:44.252Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.
🧬 Code Graph Analysis (1)
Maple2.Model/Common/Vector.cs (2)
Maple2.Model/Game/User/Home.cs (1)
  • Vector3 (129-149)
Maple2.Server.Game/Model/Field/Entity/FieldMobSpawn.cs (1)
  • Vector3 (180-184)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: format
🔇 Additional comments (6)
Maple2.Model/Common/Vector.cs (1)

43-44: LGTM! Well-implemented multiplication operator.

The operator correctly scales each component of the Vector3B by the float multiplier and returns a Vector3. This enhances the coordinate handling capabilities as demonstrated in the CoordCommand usage.

Maple2.File.Ingest/Program.cs (1)

225-229: Good naming improvement for clarity.

The variable renaming from parser to xBlockParser makes the code more readable and self-documenting. All references have been consistently updated.

Maple2.File.Ingest/Mapper/MapEntityMapper.cs (2)

28-29: Good performance optimization to prevent multiple enumeration.

Caching the entities enumerable to an array prevents multiple enumeration issues and improves performance. The cached array is correctly used in subsequent loops.

60-62: Critical fix: Added missing yield return for SimpleUiObject.

The missing yield return statement for IMS2SimpleUiObject has been properly added, ensuring these entities are correctly returned from the method. This aligns with the PR objective of implementing interactable objects.

Maple2.Server.Game/Commands/CoordCommand.cs (1)

39-42: Enhanced coordinate output with improved formatting.

The addition of Vector3B conversion and block center calculation using the new multiplication operator provides more comprehensive coordinate information. The multi-line output format improves readability and debugging capability.

Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1)

753-753: Good use of discard variables for existence check.

The change from capturing NPC instances to using discard variables (_) makes the code intent clearer - this check only verifies existence rather than needing the actual NPC object. The removal logic later in the method properly handles NPC retrieval and disposal.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AngeloTadeucci
AngeloTadeucci merged commit 44f4135 into masterJul 9, 2025
@AngeloTadeucci
AngeloTadeucci deleted the extractors branch July 9, 2025 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AngeloTadeucci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Feat: Implement simpleUiObjects - #535

Merged
AngeloTadeucci merged 1 commit into
masterfrom
extractors
Jul 9, 2025
Merged

Feat: Implement simpleUiObjects#535
AngeloTadeucci merged 1 commit into
masterfrom
extractors

Conversation

@AngeloTadeucci

@AngeloTadeucciAngeloTadeucci commented Jul 9, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

This pr covers interactables like extractors in fields

Summary by CodeRabbit

  • New Features

    • Added support for multiplying a Vector3B by a float, returning a scaled Vector3.

  • Refactor

    • Improved performance and clarity in map entity processing by caching enumerables and enhancing mapping logic.
    • Streamlined NPC removal checks for better code readability.
    • Renamed variables for clarity in the file ingestion process.

  • Style

    • Enhanced coordinate command output to display player position, Vector3B representation, and block center on separate lines for improved readability.

@AngeloTadeucci@gitbutler-client
Feat: Implement simpleUiObjects
72e7e12
This pr covers interactables like extractors in fields
@coderabbitai

coderabbitaiBot commented Jul 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes introduce a refactor to entity mapping in MapEntityMapper.cs, enhance vector operations in Vector3B, update coordinate output in CoordCommand.cs, adjust NPC existence checks in FieldManager.State.cs, and rename a parser variable in Program.cs. No public API signatures are altered.

Changes

File(s)Change Summary
Maple2.File.Ingest/Mapper/MapEntityMapper.csRefactored ParseMap to cache entities, replaced loops, and added a missing yield for IMS2SimpleUiObject.
Maple2.File.Ingest/Program.csRenamed parser variable to xBlockParser and updated references accordingly.
Maple2.Model/Common/Vector.csAdded multiplication operator overload for Vector3B with float, returning a Vector3.
Maple2.Server.Game/Commands/CoordCommand.csEnhanced coordinate output: added Vector3B and block center calculations in output.
Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.csModified RemoveNpc to perform existence checks using discard variables instead of storing NPC instance.

Sequence Diagram(s)

sequenceDiagram
participant Player
participant CoordCommand
participant Vector3B
participant Console
Player->>CoordCommand: Invoke Handle (no coordinates)
CoordCommand->>Vector3B: Convert position to Vector3B
CoordCommand->>Vector3B: Multiply by block size (compute center)
CoordCommand->>Console: Output position, Vector3B, center
Loading

Possibly related PRs

  • AngeloTadeucci/Maple2#434: Also modifies ParseMap in MapEntityMapper.cs, focusing on waypoint flags; both change entity handling logic.
  • AngeloTadeucci/Maple2#521: Alters the RemoveNpc method, changing parameter types and scheduling logic; both touch the same method.
  • AngeloTadeucci/Maple2#359: Removes handling of a specific entity type in ParseMap; both modify entity handling logic in the same method.

Poem

A rabbit hopped through code anew,
Refactoring loops as rabbits do.
Vectors scaled and outputs clear,
NPCs checked with less to fear.
With every hop, the code refined—
A carrot earned for all aligned!
🥕

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6874acd and 72e7e12.

📒 Files selected for processing (5)
  • Maple2.File.Ingest/Mapper/MapEntityMapper.cs (3 hunks)
  • Maple2.File.Ingest/Program.cs (1 hunks)
  • Maple2.Model/Common/Vector.cs (1 hunks)
  • Maple2.Server.Game/Commands/CoordCommand.cs (1 hunks)
  • Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Maple2.Model/Common/Vector.cs (2)
Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.

Learnt from: mettaursp
PR: AngeloTadeucci/Maple2#270
File: Maple2.Tools/VectorMath/Transform.cs:92-94
Timestamp: 2024-09-30T04:20:44.252Z
Learning: In the `Transform.Scale` setter in `Maple2.Tools/VectorMath/Transform.cs`, the axes are normalized and directly scaled without considering the original scale, as it's no longer a factor after normalization.
🧬 Code Graph Analysis (1)
Maple2.Model/Common/Vector.cs (2)
Maple2.Model/Game/User/Home.cs (1)
  • Vector3 (129-149)
Maple2.Server.Game/Model/Field/Entity/FieldMobSpawn.cs (1)
  • Vector3 (180-184)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: build
  • GitHub Check: format
🔇 Additional comments (6)
Maple2.Model/Common/Vector.cs (1)

43-44: LGTM! Well-implemented multiplication operator.

The operator correctly scales each component of the Vector3B by the float multiplier and returns a Vector3. This enhances the coordinate handling capabilities as demonstrated in the CoordCommand usage.

Maple2.File.Ingest/Program.cs (1)

225-229: Good naming improvement for clarity.

The variable renaming from parser to xBlockParser makes the code more readable and self-documenting. All references have been consistently updated.

Maple2.File.Ingest/Mapper/MapEntityMapper.cs (2)

28-29: Good performance optimization to prevent multiple enumeration.

Caching the entities enumerable to an array prevents multiple enumeration issues and improves performance. The cached array is correctly used in subsequent loops.

60-62: Critical fix: Added missing yield return for SimpleUiObject.

The missing yield return statement for IMS2SimpleUiObject has been properly added, ensuring these entities are correctly returned from the method. This aligns with the PR objective of implementing interactable objects.

Maple2.Server.Game/Commands/CoordCommand.cs (1)

39-42: Enhanced coordinate output with improved formatting.

The addition of Vector3B conversion and block center calculation using the new multiplication operator provides more comprehensive coordinate information. The multi-line output format improves readability and debugging capability.

Maple2.Server.Game/Manager/Field/FieldManager/FieldManager.State.cs (1)

753-753: Good use of discard variables for existence check.

The change from capturing NPC instances to using discard variables (_) makes the code intent clearer - this check only verifies existence rather than needing the actual NPC object. The removal logic later in the method properly handles NPC retrieval and disposal.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AngeloTadeucci
AngeloTadeucci merged commit 44f4135 into masterJul 9, 2025
@AngeloTadeucci
AngeloTadeucci deleted the extractors branch July 9, 2025 10:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AngeloTadeucci