refactor: update GuildHandler to use core PacketHandler base class - #552

Merged
AngeloTadeucci merged 1 commit into
masterfrom
guild-handler
Jul 23, 2025
Merged

refactor: update GuildHandler to use core PacketHandler base class#552
AngeloTadeucci merged 1 commit into
masterfrom
guild-handler

Conversation

@AngeloTadeucci

@AngeloTadeucciAngeloTadeucci commented Jul 23, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor
    • Updated internal structure for handling guild-related actions, with no impact on user-facing functionality.

@coderabbitai

coderabbitaiBot commented Jul 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The GuildHandler class was updated to inherit from PacketHandler<GameSession> instead of FieldPacketHandler, with corresponding changes to the import statements. No other modifications were made to the class or its methods.

Changes

File(s)Change Summary
Maple2.Server.Game/PacketHandlers/GuildHandler.csChanged base class from FieldPacketHandler to PacketHandler<GameSession>; updated import statements accordingly.

Sequence Diagram(s)

sequenceDiagram
participant Client
participant GameSession
participant GuildHandler
Client->>GameSession: Sends packet
GameSession->>GuildHandler: Dispatches packet to handler
GuildHandler-->>GameSession: Processes with PacketHandler<GameSession> logic
Loading

Estimated code review effort

1 (~2 minutes)

Possibly related PRs

Suggested reviewers

  • Zintixx

Poem

A handler hopped from field to game,
Inheriting a brand new name.
Guilds now handled, neat and quick,
With PacketHandler’s clever trick.
A single change, a tiny leap—
But even small hops count for sheep! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d54ce3 and ebf50ea.

📒 Files selected for processing (1)
  • Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)

Learnt from: AngeloTadeucci
PR: #199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: #199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.

🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)

Learnt from: AngeloTadeucci
PR: #199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: #199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: build
🔇 Additional comments (2)
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)

9-9: LGTM! Import updated to support core PacketHandler base class.

The import change correctly reflects the refactoring objective to use the core PacketHandler infrastructure.

18-18: LGTM – No further changes needed

The switch from FieldPacketHandler to PacketHandler<GameSession> in GuildHandler is correct: Guild packets aren’t field-specific, so they should use the core handler directly. All other handlers under PacketHandlers/Field/ still extend the specialized FieldPacketHandler (which itself inherits PacketHandler<GameSession>) and should remain unchanged.

  • GuildHandler: ✅ now extends PacketHandler<GameSession>
  • Field-scoped handlers: ✅ correctly extend FieldPacketHandler for shared field logic

No additional refactoring is required.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AngeloTadeucci
AngeloTadeucci merged commit 053f8e5 into masterJul 23, 2025
4 checks passed
@AngeloTadeucci
AngeloTadeucci deleted the guild-handler branch July 23, 2025 16:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZintixxZintixxZintixx approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AngeloTadeucci@Zintixx
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
refactor: update GuildHandler to use core PacketHandler base class - #552
Merged
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Jul 23, 2025
Merged
refactor: update GuildHandler to use core PacketHandler base class#552
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Conversation
@AngeloTadeucci
@AngeloTadeucciAngeloTadeucci
commented
Jul 23, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Updated internal structure for handling guild-related actions, with no impact on user-facing functionality.
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The GuildHandler class was updated to inherit from PacketHandler<GameSession> instead of FieldPacketHandler, with corresponding changes to the import statements. No other modifications were made to the class or its methods.
Changes
File(s)Change Summary
Maple2.Server.Game/PacketHandlers/GuildHandler.csChanged base class from FieldPacketHandler to PacketHandler<GameSession>; updated import statements accordingly.
Sequence Diagram(s)
sequenceDiagram
participant Client
participant GameSession
participant GuildHandler
Client->>GameSession: Sends packet
GameSession->>GuildHandler: Dispatches packet to handler
GuildHandler-->>GameSession: Processes with PacketHandler<GameSession> logic

Loading
Estimated code review effort
1 (~2 minutes)
Possibly related PRs
Suggested reviewers
  • Zintixx
Poem
A handler hopped from field to game,

Inheriting a brand new name.

Guilds now handled, neat and quick,

With PacketHandler’s clever trick.

A single change, a tiny leap—

But even small hops count for sheep! 🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 9d54ce3 and ebf50ea.
📒 Files selected for processing (1)
  • Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: build
🔇 Additional comments (2)
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
9-9: LGTM! Import updated to support core PacketHandler base class.
The import change correctly reflects the refactoring objective to use the core PacketHandler infrastructure.
18-18: LGTM – No further changes needed
The switch from FieldPacketHandler to PacketHandler<GameSession> in GuildHandler is correct: Guild packets aren’t field-specific, so they should use the core handler directly. All other handlers under PacketHandlers/Field/ still extend the specialized FieldPacketHandler (which itself inherits PacketHandler<GameSession>) and should remain unchanged.
  • GuildHandler: ✅ now extends PacketHandler<GameSession>
  • Field-scoped handlers: ✅ correctly extend FieldPacketHandler for shared field logic
No additional refactoring is required.
✨ Finishing Touches
  •  📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@AngeloTadeucci
AngeloTadeucci
merged commit 053f8e5
into
masterJul 23, 2025

4 checks passed

@AngeloTadeucci
AngeloTadeucci
deleted the

guild-handler

branch
July 23, 2025 16:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ZintixxZintixxZintixx approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@AngeloTadeucci@Zintixx

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: update GuildHandler to use core PacketHandler base class - #552
Merged
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Jul 23, 2025
Merged
refactor: update GuildHandler to use core PacketHandler base class#552
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Conversation
@AngeloTadeucci
@AngeloTadeucciAngeloTadeucci
commented
Jul 23, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Updated internal structure for handling guild-related actions, with no impact on user-facing functionality.
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The GuildHandler class was updated to inherit from PacketHandler<GameSession> instead of FieldPacketHandler, with corresponding changes to the import statements. No other modifications were made to the class or its methods.
Changes
File(s)Change Summary
Maple2.Server.Game/PacketHandlers/GuildHandler.csChanged base class from FieldPacketHandler to PacketHandler<GameSession>; updated import statements accordingly.
Sequence Diagram(s)
sequenceDiagram
participant Client
participant GameSession
participant GuildHandler
Client->>GameSession: Sends packet
GameSession->>GuildHandler: Dispatches packet to handler
GuildHandler-->>GameSession: Processes with PacketHandler<GameSession> logic

Loading
Estimated code review effort
1 (~2 minutes)
Possibly related PRs
Suggested reviewers
  • Zintixx
Poem
A handler hopped from field to game,

Inheriting a brand new name.

Guilds now handled, neat and quick,

With PacketHandler’s clever trick.

A single change, a tiny leap—

But even small hops count for sheep! 🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 9d54ce3 and ebf50ea.
📒 Files selected for processing (1)
  • Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: build
🔇 Additional comments (2)
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
9-9: LGTM! Import updated to support core PacketHandler base class.
The import change correctly reflects the refactoring objective to use the core PacketHandler infrastructure.
18-18: LGTM – No further changes needed
The switch from FieldPacketHandler to PacketHandler<GameSession> in GuildHandler is correct: Guild packets aren’t field-specific, so they should use the core handler directly. All other handlers under PacketHandlers/Field/ still extend the specialized FieldPacketHandler (which itself inherits PacketHandler<GameSession>) and should remain unchanged.
  • GuildHandler: ✅ now extends PacketHandler<GameSession>
  • Field-scoped handlers: ✅ correctly extend FieldPacketHandler for shared field logic
No additional refactoring is required.
✨ Finishing Touches
  •  📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@AngeloTadeucci
AngeloTadeucci
merged commit 053f8e5
into
masterJul 23, 2025

4 checks passed

@AngeloTadeucci
AngeloTadeucci
deleted the

guild-handler

branch
July 23, 2025 16:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ZintixxZintixxZintixx approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@AngeloTadeucci@Zintixx

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: update GuildHandler to use core PacketHandler base class - #552
Merged
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Jul 23, 2025
Merged
refactor: update GuildHandler to use core PacketHandler base class#552
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Conversation
@AngeloTadeucci
@AngeloTadeucciAngeloTadeucci
commented
Jul 23, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Updated internal structure for handling guild-related actions, with no impact on user-facing functionality.
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The GuildHandler class was updated to inherit from PacketHandler<GameSession> instead of FieldPacketHandler, with corresponding changes to the import statements. No other modifications were made to the class or its methods.
Changes
File(s)Change Summary
Maple2.Server.Game/PacketHandlers/GuildHandler.csChanged base class from FieldPacketHandler to PacketHandler<GameSession>; updated import statements accordingly.
Sequence Diagram(s)
sequenceDiagram
participant Client
participant GameSession
participant GuildHandler
Client->>GameSession: Sends packet
GameSession->>GuildHandler: Dispatches packet to handler
GuildHandler-->>GameSession: Processes with PacketHandler<GameSession> logic

Loading
Estimated code review effort
1 (~2 minutes)
Possibly related PRs
Suggested reviewers
  • Zintixx
Poem
A handler hopped from field to game,

Inheriting a brand new name.

Guilds now handled, neat and quick,

With PacketHandler’s clever trick.

A single change, a tiny leap—

But even small hops count for sheep! 🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 9d54ce3 and ebf50ea.
📒 Files selected for processing (1)
  • Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: build
🔇 Additional comments (2)
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
9-9: LGTM! Import updated to support core PacketHandler base class.
The import change correctly reflects the refactoring objective to use the core PacketHandler infrastructure.
18-18: LGTM – No further changes needed
The switch from FieldPacketHandler to PacketHandler<GameSession> in GuildHandler is correct: Guild packets aren’t field-specific, so they should use the core handler directly. All other handlers under PacketHandlers/Field/ still extend the specialized FieldPacketHandler (which itself inherits PacketHandler<GameSession>) and should remain unchanged.
  • GuildHandler: ✅ now extends PacketHandler<GameSession>
  • Field-scoped handlers: ✅ correctly extend FieldPacketHandler for shared field logic
No additional refactoring is required.
✨ Finishing Touches
  •  📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@AngeloTadeucci
AngeloTadeucci
merged commit 053f8e5
into
masterJul 23, 2025

4 checks passed

@AngeloTadeucci
AngeloTadeucci
deleted the

guild-handler

branch
July 23, 2025 16:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ZintixxZintixxZintixx approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@AngeloTadeucci@Zintixx

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
refactor: update GuildHandler to use core PacketHandler base class - #552
Merged
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Jul 23, 2025
Merged
refactor: update GuildHandler to use core PacketHandler base class#552
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Conversation
@AngeloTadeucci
@AngeloTadeucciAngeloTadeucci
commented
Jul 23, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Updated internal structure for handling guild-related actions, with no impact on user-facing functionality.
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The GuildHandler class was updated to inherit from PacketHandler<GameSession> instead of FieldPacketHandler, with corresponding changes to the import statements. No other modifications were made to the class or its methods.
Changes
File(s)Change Summary
Maple2.Server.Game/PacketHandlers/GuildHandler.csChanged base class from FieldPacketHandler to PacketHandler<GameSession>; updated import statements accordingly.
Sequence Diagram(s)
sequenceDiagram
participant Client
participant GameSession
participant GuildHandler
Client->>GameSession: Sends packet
GameSession->>GuildHandler: Dispatches packet to handler
GuildHandler-->>GameSession: Processes with PacketHandler<GameSession> logic

Loading
Estimated code review effort
1 (~2 minutes)
Possibly related PRs
Suggested reviewers
  • Zintixx
Poem
A handler hopped from field to game,

Inheriting a brand new name.

Guilds now handled, neat and quick,

With PacketHandler’s clever trick.

A single change, a tiny leap—

But even small hops count for sheep! 🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 9d54ce3 and ebf50ea.
📒 Files selected for processing (1)
  • Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: build
🔇 Additional comments (2)
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
9-9: LGTM! Import updated to support core PacketHandler base class.
The import change correctly reflects the refactoring objective to use the core PacketHandler infrastructure.
18-18: LGTM – No further changes needed
The switch from FieldPacketHandler to PacketHandler<GameSession> in GuildHandler is correct: Guild packets aren’t field-specific, so they should use the core handler directly. All other handlers under PacketHandlers/Field/ still extend the specialized FieldPacketHandler (which itself inherits PacketHandler<GameSession>) and should remain unchanged.
  • GuildHandler: ✅ now extends PacketHandler<GameSession>
  • Field-scoped handlers: ✅ correctly extend FieldPacketHandler for shared field logic
No additional refactoring is required.
✨ Finishing Touches
  •  📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@AngeloTadeucci
AngeloTadeucci
merged commit 053f8e5
into
masterJul 23, 2025

4 checks passed

@AngeloTadeucci
AngeloTadeucci
deleted the

guild-handler

branch
July 23, 2025 16:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ZintixxZintixxZintixx approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@AngeloTadeucci@Zintixx

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: update GuildHandler to use core PacketHandler base class - #552
Merged
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Jul 23, 2025
Merged
refactor: update GuildHandler to use core PacketHandler base class#552
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Conversation
@AngeloTadeucci
@AngeloTadeucciAngeloTadeucci
commented
Jul 23, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Updated internal structure for handling guild-related actions, with no impact on user-facing functionality.
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The GuildHandler class was updated to inherit from PacketHandler<GameSession> instead of FieldPacketHandler, with corresponding changes to the import statements. No other modifications were made to the class or its methods.
Changes
File(s)Change Summary
Maple2.Server.Game/PacketHandlers/GuildHandler.csChanged base class from FieldPacketHandler to PacketHandler<GameSession>; updated import statements accordingly.
Sequence Diagram(s)
sequenceDiagram
participant Client
participant GameSession
participant GuildHandler
Client->>GameSession: Sends packet
GameSession->>GuildHandler: Dispatches packet to handler
GuildHandler-->>GameSession: Processes with PacketHandler<GameSession> logic

Loading
Estimated code review effort
1 (~2 minutes)
Possibly related PRs
Suggested reviewers
  • Zintixx
Poem
A handler hopped from field to game,

Inheriting a brand new name.

Guilds now handled, neat and quick,

With PacketHandler’s clever trick.

A single change, a tiny leap—

But even small hops count for sheep! 🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 9d54ce3 and ebf50ea.
📒 Files selected for processing (1)
  • Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: build
🔇 Additional comments (2)
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
9-9: LGTM! Import updated to support core PacketHandler base class.
The import change correctly reflects the refactoring objective to use the core PacketHandler infrastructure.
18-18: LGTM – No further changes needed
The switch from FieldPacketHandler to PacketHandler<GameSession> in GuildHandler is correct: Guild packets aren’t field-specific, so they should use the core handler directly. All other handlers under PacketHandlers/Field/ still extend the specialized FieldPacketHandler (which itself inherits PacketHandler<GameSession>) and should remain unchanged.
  • GuildHandler: ✅ now extends PacketHandler<GameSession>
  • Field-scoped handlers: ✅ correctly extend FieldPacketHandler for shared field logic
No additional refactoring is required.
✨ Finishing Touches
  •  📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@AngeloTadeucci
AngeloTadeucci
merged commit 053f8e5
into
masterJul 23, 2025

4 checks passed

@AngeloTadeucci
AngeloTadeucci
deleted the

guild-handler

branch
July 23, 2025 16:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ZintixxZintixxZintixx approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@AngeloTadeucci@Zintixx

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
refactor: update GuildHandler to use core PacketHandler base class - #552
Merged
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Jul 23, 2025
Merged
refactor: update GuildHandler to use core PacketHandler base class#552
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Conversation
@AngeloTadeucci
@AngeloTadeucciAngeloTadeucci
commented
Jul 23, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Updated internal structure for handling guild-related actions, with no impact on user-facing functionality.
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The GuildHandler class was updated to inherit from PacketHandler<GameSession> instead of FieldPacketHandler, with corresponding changes to the import statements. No other modifications were made to the class or its methods.
Changes
File(s)Change Summary
Maple2.Server.Game/PacketHandlers/GuildHandler.csChanged base class from FieldPacketHandler to PacketHandler<GameSession>; updated import statements accordingly.
Sequence Diagram(s)
sequenceDiagram
participant Client
participant GameSession
participant GuildHandler
Client->>GameSession: Sends packet
GameSession->>GuildHandler: Dispatches packet to handler
GuildHandler-->>GameSession: Processes with PacketHandler<GameSession> logic

Loading
Estimated code review effort
1 (~2 minutes)
Possibly related PRs
Suggested reviewers
  • Zintixx
Poem
A handler hopped from field to game,

Inheriting a brand new name.

Guilds now handled, neat and quick,

With PacketHandler’s clever trick.

A single change, a tiny leap—

But even small hops count for sheep! 🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 9d54ce3 and ebf50ea.
📒 Files selected for processing (1)
  • Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: build
🔇 Additional comments (2)
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
9-9: LGTM! Import updated to support core PacketHandler base class.
The import change correctly reflects the refactoring objective to use the core PacketHandler infrastructure.
18-18: LGTM – No further changes needed
The switch from FieldPacketHandler to PacketHandler<GameSession> in GuildHandler is correct: Guild packets aren’t field-specific, so they should use the core handler directly. All other handlers under PacketHandlers/Field/ still extend the specialized FieldPacketHandler (which itself inherits PacketHandler<GameSession>) and should remain unchanged.
  • GuildHandler: ✅ now extends PacketHandler<GameSession>
  • Field-scoped handlers: ✅ correctly extend FieldPacketHandler for shared field logic
No additional refactoring is required.
✨ Finishing Touches
  •  📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@AngeloTadeucci
AngeloTadeucci
merged commit 053f8e5
into
masterJul 23, 2025

4 checks passed

@AngeloTadeucci
AngeloTadeucci
deleted the

guild-handler

branch
July 23, 2025 16:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ZintixxZintixxZintixx approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@AngeloTadeucci@Zintixx

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
refactor: update GuildHandler to use core PacketHandler base class - #552
Merged
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Jul 23, 2025
Merged
refactor: update GuildHandler to use core PacketHandler base class#552
AngeloTadeucci merged 1 commit into
masterfrom 
guild-handler
Conversation
@AngeloTadeucci
@AngeloTadeucciAngeloTadeucci
commented
Jul 23, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Collaborator
Summary by CodeRabbit
  • Refactor
    • Updated internal structure for handling guild-related actions, with no impact on user-facing functionality.
@coderabbitai
coderabbitaiBot
commented
Jul 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The GuildHandler class was updated to inherit from PacketHandler<GameSession> instead of FieldPacketHandler, with corresponding changes to the import statements. No other modifications were made to the class or its methods.
Changes
File(s)Change Summary
Maple2.Server.Game/PacketHandlers/GuildHandler.csChanged base class from FieldPacketHandler to PacketHandler<GameSession>; updated import statements accordingly.
Sequence Diagram(s)
sequenceDiagram
participant Client
participant GameSession
participant GuildHandler
Client->>GameSession: Sends packet
GameSession->>GuildHandler: Dispatches packet to handler
GuildHandler-->>GameSession: Processes with PacketHandler<GameSession> logic

Loading
Estimated code review effort
1 (~2 minutes)
Possibly related PRs
Suggested reviewers
  • Zintixx
Poem
A handler hopped from field to game,

Inheriting a brand new name.

Guilds now handled, neat and quick,

With PacketHandler’s clever trick.

A single change, a tiny leap—

But even small hops count for sheep! 🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 9d54ce3 and ebf50ea.
📒 Files selected for processing (1)
  • Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-10-09T04:13:28.776Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#199
File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0
Timestamp: 2024-07-12T04:31:25.376Z
Learning: Packets can't ever be null inside the `Handle` function of packet handlers in the repository.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-10-09T04:13:28.776Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Learnt from: AngeloTadeucci
PR: AngeloTadeucci/Maple2#239
File: Maple2.Server.Game/Session/GameSession.State.cs:26-27
Timestamp: 2024-09-19T04:27:27.320Z
Learning: In `GameSession` class, fields are public. When adding new fields to this class, they should be public for consistency.

Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-10-09T04:13:28.776Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
Learnt from: AngeloTadeucci

PR: #199

File: Maple2.Server.Game/PacketHandlers/FileHandler.cs:0-0

Timestamp: 2024-07-12T04:31:25.376Z

Learning: Packets can't ever be null inside the Handle function of packet handlers in the repository.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: build
🔇 Additional comments (2)
Maple2.Server.Game/PacketHandlers/GuildHandler.cs (2)
9-9: LGTM! Import updated to support core PacketHandler base class.
The import change correctly reflects the refactoring objective to use the core PacketHandler infrastructure.
18-18: LGTM – No further changes needed
The switch from FieldPacketHandler to PacketHandler<GameSession> in GuildHandler is correct: Guild packets aren’t field-specific, so they should use the core handler directly. All other handlers under PacketHandlers/Field/ still extend the specialized FieldPacketHandler (which itself inherits PacketHandler<GameSession>) and should remain unchanged.
  • GuildHandler: ✅ now extends PacketHandler<GameSession>
  • Field-scoped handlers: ✅ correctly extend FieldPacketHandler for shared field logic
No additional refactoring is required.
✨ Finishing Touches
  •  📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@AngeloTadeucci
AngeloTadeucci
merged commit 053f8e5
into
masterJul 23, 2025

4 checks passed

@AngeloTadeucci
AngeloTadeucci
deleted the

guild-handler

branch
July 23, 2025 16:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ZintixxZintixxZintixx approved these changes
@coderabbitaicoderabbitai[bot]coderabbitai[bot] approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@AngeloTadeucci@Zintixx