Uh oh!
There was an error while loading. Please reload this page.
Play page: interactive "Enter MUME" chooser (proposal) - #52
Play page: interactive "Enter MUME" chooser (proposal)#52whitecouncil-alt wants to merge 3 commits into
Conversation
Reviewer's GuideThe PR redesigns the Play page around a themed, responsive Vue chooser that prioritizes tutorial and web-client entry points while exposing three alternative play methods interactively; it also removes the existing Google Analytics initialization and route tracking from the VitePress theme. Sequence diagram for interactive PlayChooser behaviorsequenceDiagram
participant Visitor
participant PlayChooser
participant TutorialApp
participant WebClient
Visitor->>PlayChooser: Open Play page
PlayChooser->>PlayChooser: onMounted()
Visitor->>PlayChooser: Click Begin the tutorial
PlayChooser->>TutorialApp: Navigate to tutorialUrl
Visitor->>PlayChooser: Click Play now
PlayChooser->>WebClient: Navigate to browser client
Visitor->>PlayChooser: Click Every way to play
PlayChooser->>PlayChooser: toggle expanded details
PlayChooser-->>Visitor: Show three client options
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments### Comment 1
<locationpath="docs/.vitepress/theme/index.js"line_range="13-48" />
<code_context>
- const GA_MEASUREMENT_ID = 'G-LL4RX9KM6Q'
</code_context>
<issue_to_address>
**issue (broader_impact):** Removing the analytics initialization stops defining `window.gtag`, loading Google Analytics, and registering route-change page-view events. The existing `CookieConsent` component still advertises Google Analytics and its consent updates become no-ops because `window.gtag` is absent.
**Triggers:** When the site is deployed after this change.
**Suggested fix:** Preserve the GA initialization and router page-view handler while registering `PlayChooser`, or remove/update the cookie-consent UI and analytics claims together.
</issue_to_address>
### Comment 2
<locationpath="docs/.vitepress/theme/components/PlayChooser.vue"line_range="6" />
<code_context>
+import { withBase } from 'vitepress'
+
+// destination for the "first time" path — the interactive tutorial (external app)
+const tutorialUrl = 'https://mume-preview.mume-idea-submission.workers.dev'
+const fellowship = withBase('/assets/images/fellowship_bw.jpg')
+const root = ref(null)
</code_context>
<issue_to_address>
**issue (broader_impact):** The public beginner path always sends users to the `mume-preview.mume-idea-submission.workers.dev` preview deployment rather than a confirmed tutorial destination. If that preview deployment is removed, restricted, or changed, the primary “I'm new to the game” entry point breaks for new players.
**Triggers:** When this Play page is published before the external tutorial URL is finalized.
**Suggested fix:** Replace `tutorialUrl` with the confirmed production tutorial URL, or keep the chooser behind a preview-only flag until the destination is stable.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 2 findings to address first, and the new-player path now depends on an externally hosted tutorial, so a bad URL or broken service changes where new users are sent; reverting restores the old page. Removing the site-wide analytics initialization also permanently loses page-view data collected during the interval before a revert, although the user-facing page behavior is otherwise normally reversible.
Blocking findings: docs/.vitepress/theme/index.js:48, docs/.vitepress/theme/components/PlayChooser.vue:6
Uh oh!
There was an error while loading. Please reload this page.
| import { withBase } from 'vitepress' | ||
| // destination for the "first time" path — the interactive tutorial (external app) | ||
| const tutorialUrl = 'https://mume-preview.mume-idea-submission.workers.dev' |
There was a problem hiding this comment.
issue (broader_impact): The public beginner path always sends users to the mume-preview.mume-idea-submission.workers.dev preview deployment rather than a confirmed tutorial destination. If that preview deployment is removed, restricted, or changed, the primary “I'm new to the game” entry point breaks for new players.
Triggers: When this Play page is published before the external tutorial URL is finalized.
Suggested fix: Replace tutorialUrl with the confirmed production tutorial URL, or keep the chooser behind a preview-only flag until the destination is stable.
…e, tighten top - index.js: keep Nils's Google Analytics + consent (stale copy had dropped it); only ADD PlayChooser registration - component: expander + tilt are now reactive (@click/@mousemove) so they work under VitePress hydration; the old onMounted DOM-binding wasn't firing - remove the 'Multi Users in Middle-earth' eyebrow - tighten the top spacing
# Conflicts: # docs/play/index.md
A proposed redesign of the Play page as a two-path chooser:
…with an expandable "Every way to play" section holding the three
clients (MMapper Web, MMapper Desktop, MUD client) as columns.
Built as a VitePress component (PlayChooser.vue) using the site's own
theme, fonts and layout. This is for preview/feedback, not urgent to merge.
Note: the "Begin the tutorial" button points at the external interactive
tutorial app for now — destination to be confirmed.
Summary by Sourcery
Redesign the Play page around an interactive two-path entry point with access to all supported MUME clients.
New Features:
Enhancements:
Documentation: