Restructure MUME Wiki for Newbie Onboarding - #46
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's GuideThe PR introduces a Quick Start onboarding gateway, routes site navigation toward it, restructures the guides into progressive learning tiers, and refreshes core command/help pages with current syntax, cross-links, and beginner-focused callouts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 3 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/pages/Death.md" line_range="12" />
<code_context>
+Dying is a normal part of learning MUME:
+- **Retrieving Gear**: Return to your `corpse` and type `get all corpse`.
+- **Ask for Help**: If you died in a dangerous area, use `narrate` or `tell` to ask friendly players for help. Experienced players are happy to escort you back!
+- **Newbie Kits**: Good-aligned characters below level 6 receive a free newbie kit on re-login after death.
+For more first-hour survival tips, see the [**Quick Start Guide**](./Quick_Start.md).
+:::
</code_context>
<issue_to_address>
**issue:** The tip tells new players that good-aligned characters below level 6 receive a free newbie kit on re-login after death, but newbie kits are granted by praying to the Ainur and asking an immortal; they are not automatically supplied on re-login.
**Triggers:** When a new player dies and logs back in expecting the promised automatic kit.
**Suggested fix:** State that eligible Free People characters can request another kit after death by praying to the Ainur, rather than promising an automatic re-login kit.
```suggestion
- **Newbie Kits**: Eligible Free People characters below level 6 can request another newbie kit after death by praying to the Ainur and asking an immortal.
```
</issue_to_address>
### Comment 2
<location path="docs/pages/Quick_Start.md" line_range="143" />
<code_context>
+Death is a learning experience in MUME, not the end of your adventure!
+
+1. **Your Body Becomes a Corpse**:
+ When you die, your worn and carried equipment stays on your `corpse` at the location where you fell.
+2. **Re-appearing in Mandos or Town**:
+ You will reappear safely in a starter hall or town.
</code_context>
<issue_to_address>
**issue:** The guide states that worn and carried equipment stays on a corpse whenever the player dies, but death-trap deaths do not provide a recoverable corpse and existing death guidance also warns that equipment can be taken before the player returns.
**Triggers:** When a new player dies in a death trap or returns after another player or creature has removed items.
**Suggested fix:** Qualify this with the death-trap exception and explain that corpse recovery is not guaranteed.
```suggestion
In most cases, your worn and carried equipment stays on your `corpse` at the location where you fell, but death-trap deaths do not leave a recoverable corpse, and corpse recovery is not guaranteed.
```
</issue_to_address>
### Comment 3
<location path="docs/pages/Quick_Start.md" line_range="67" />
<code_context>
+| View worn gear | **`equipment`** | `eq` | Displays items currently worn or held. |
+| View carried gear | **`inventory`** | `i` | Displays items inside your bags or hands. |
+| Hold a weapon | **`wield`** | `wield sword` | Wields a weapon in your hand. |
+| Draw / Sheathe | **`draw`** / **`sheathe`** | `draw sheath` / `sheathe` | Draws or sheathes a weapon (requires a sheath/scabbard). |
+| Wear armor | **`wear`** | `wear shield` / `wear all` | Wears clothing, armor, or shields. |
+| Belt items | **`wear`** | `wear lantern belt` | Attaches lanterns, flasks, or pouches to your belt. |
</code_context>
<issue_to_address>
**nitpick:** The equipment table says drawing or sheathing requires a sheath/scabbard, but `draw` also supports drawing bows worn across the back and weapons directly from inventory, so the requirement incorrectly tells players those valid uses are unavailable.
**Triggers:** When a new player tries to draw a bow or an unsheathed weapon from inventory.
**Suggested fix:** Say that a sheath is needed for sheathed weapons, while bows and inventory weapons can also be drawn directly.
```suggestion
| Draw / Sheathe | **`draw`** / **`sheathe`** | `draw sheath` / `sheathe` | Draws or sheathes a weapon; a sheath is needed for sheathed weapons, while bows and inventory weapons can also be drawn directly. |
```
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: docs/pages/Death.md:12, docs/pages/Quick_Start.md:143
Sourcery withdrew this approval because it has stopped reviewing this pull request.
|
Sourcery has withdrawn its approval of this pull request. It auto-reviews a pull request 5 times, and this push is past that limit, so the approval no longer reflects code Sourcery has read. Comment |
This change restructures the MUME wiki to address student survey feedback and streamline onboarding for first-time MUD players. Key improvements include:
Quick_Start.md): Created a dedicated onboarding gateway with a First 15 Minutes Checklist (change wimpy 15,change spam fight on), a tutorial inventory warning, categorized command tables (give [item] [person],draw/sheathe,wear,eat/drink,ask <NPC> <topic>,order), death/corpse recovery tips, and official Discord integration.index.md,config.ts,Guides.md): Promoted "Quick Start" to the primary action button on the home page, top header navigation, and bottom recirculation include footer across all pages.guides.md): Restructured player guides into progressive learning tiers ("First Hour Survival", "Adventuring & Character Growth", "Class & Race Guides").Spam.md,Prompt.md,Compact.md, andBrief.mdwith official MUME syntax (change spam <field> [on|off],change prompt). Added VitePress tip callout banners to core pages (Basics.md,Combat.md,Death.md,Quest.md,FAQ1.md,FAQ3.md).PR created automatically by Jules for task 13997782053986515008 started by @nschimme
Summary by Sourcery
Restructure the wiki around a progressive Quick Start onboarding experience for new MUME players.
New Features:
Bug Fixes:
Enhancements:
Documentation: