Uh oh!
There was an error while loading. Please reload this page.
Add cp314t build - #212
Conversation
rgommers
commented
Jun 17, 2026
The That seems relatively benign, and is possibly related to the different default for The Windows on Arm jobs show crashes, but on all of https://github.com/MacPython/statsmodels-wheels/actions/runs/27669875530/job/81831635348?pr=212 |
bashtage
commented
Jun 17, 2026
The windows arm failures are expected. They have been failing since they were first started. There appears to be OpenBlas bug(s). These have been reported to NumPy. I agree that the warnings failure is pretty important. The bigger issue is that other parts segfault under free threading when actually run in parallel. But I suppose we can still have a cp314t wheel even if it isn't actually threadsafe. |
kumaraditya303
commented
Jun 30, 2026
The statespace tests segfault when run in parallel because the testa are written in an unsafe way. The class |
bashtage
commented
Jun 30, 2026
I'm happy with more models. Cold you point me to an example where a model is shared? I'm happy to use some tokens to tackle this. |
kumaraditya303
commented
Jun 30, 2026
See https://github.com/statsmodels/statsmodels/blob/cfae27cdd96c2fda81eeac682308092432d211eb/statsmodels/tsa/statespace/tests/test_dynamic_factor.py#L28-L63 During the setup of test it assigns a model to a |
kumaraditya303
commented
Jun 30, 2026
I submitted statsmodels/statsmodels#9877 to fix the |
bashtage
commented
Jul 17, 2026
@copilot please fix the merge conflicts in this pull request. |
bashtage
commented
Jul 17, 2026
I have spent a bit of time getting the test suite to pass on a multi threaded run. The exercise shows that statsmodels is not really threadsafe. There are some pretty agregious practices like adding an attribute during |
There was a problem hiding this comment.
Pull request overview
This PR updates the wheel-build GitHub Actions workflow to include CPython 3.14 free-threaded (cp314t) artifacts, aligning with issue #208’s goal of publishing cp314t wheels to PyPI.
Changes:
- Add
cp314tto the cibuildwheel build matrix. - Switch the Pyodide build target from
cp312tocp313and explicitly constrain Pyodide builds tocp313-*. - Adjust
CIBW_SKIPpatterns (dropping thepp*/PyPy skip).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| include: | ||
| - python: cp312 | ||
| - python: cp313 | ||
| os: ubuntu-latest | ||
| python_impl: Pyodide |
| # No support for pypy, musl, Win32 for 3.10+ | ||
| # Skip musl for 3.8 and 3.9 since no upstream wheels | ||
| CIBW_SKIP: "pp* *-win32 *musllinux_aarch64*" | ||
| CIBW_SKIP: "*-win32 *musllinux_aarch64*" |
| CIBW_PLATFORM: pyodide | ||
| CIBW_BUILD: "cp313-*" | ||
| CIBW_BEFORE_BUILD: 'git submodule foreach git checkout ${{ env.BUILD_COMMIT }}' |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.github/workflows/build-wheels.yml:42
- The env block comments state there is no support for PyPy, but
CIBW_SKIPno longer skipspp*. This makes the workflow configuration internally inconsistent and could allow accidental PyPy builds ifCIBW_BUILDis broadened later. Either restore the PyPy skip (as before) or update the comments to match the intended behavior.
# No support for pypy, musl, Win32 for 3.10+
# Skip musl for 3.8 and 3.9 since no upstream wheels
CIBW_SKIP: "*-win32 *musllinux_aarch64*"
bashtage
commented
Jul 20, 2026
This is going in - will now have overnight cp314t wheels. Thanks for the help. |
Uh oh!
There was an error while loading. Please reload this page.
closes#208