update to electron v34

[khassel]

related to #3593

• electron-rebuild fails in our tests with electron v33 and v34 because nan must be fixed
• there is an open PR from Okt. 24 which is still unmerged
• comment from this issue: You should not ping nan maintainers as they have been quick to point out that they do not support and have no intention to support Electron in the future.
• in above issue a fix is mentioned to get nan running which I have included in this PR to get the tests running
• the currently used electron v32 has end of support 04 Mar 2025
• we don't have to merge this now, we can wait until March for a decision how to progress

[bugsounet]

You should not ping nan maintainers as they have been quick to point out that they do not support and have no intention to support Electron in the future.

Je pense que le test n'est plus nécessaire si le package n'est plus maintenu.
C'est a la team de @electron/rebuild de trouver une solution de remplacement et non a la team de MagicMirror².

Il n'y a donc pas de question a se poser, nous allons pas attendre éternellement !
De plus ce package n'est pas utiliser dans le core de MagicMirror². Il est exclusivement utiliser dans quelques modules tiers.
De plus, node-libgpiod est utiliser exclusivement par moi même.
Je suis capable d'oublier celle-ci et de travailler sans :)

[sdetweil]

does this close #3640?

[khassel]

does this close #3640?

it would (skipping v33)

[bugsounet]

Finally, I would say my last words in English (sorry it will be AGAIN not understandable... huh Sam!):

• node-libgpiod is no longer used.
• Only my MMM-Pir module used it. I just destroyed it.

So it's up to you... electron-rebuild.yaml is really no longer used

Now ask yourself the questions:

• Is bugsounet the only one using electron rebuild and node-libgpiod?
• Another library does not have the same reaction and could therefore "fail" ?
• is electron-rebuild really needed ?

Would it be better to use onoff instead?
Oh no... it doesn't work with the pi anymore :/

Good thinking to you,
All the best for MM² Team!

Everything has an end...

Bye!
@bugsounet

[sdetweil]

anything using GPIO will have troubles
physical buttons, sensors

[khassel]

Searching through the module list of @KristjanESPERANTO these module repositories have the string rebuild inside their package.json:

balassy/MMM-ModuleToggleButton
Bee-Mar/MMM-Simple-Swiper
bugsounet/MMM-GoogleAssistant
cSharpBastard/mmm-nordic-electrical-spot-prices
dancj/MMM-Hover
djey47/MMM-LKY-TIC
framboise-pi/MMM-MyMinecraft
framboise-pi/MMM-MySenseHat
istvanfedak/mmm-miami-transit
JulienPeloton/MMM-tns
MarcLandis/MMM-Buttons
MarcLandis/MMM-PIR-Sensor
MMRIZE/MMM-GoogleTTS
MMRIZE/MMM-Hotword2
PatriceG/MMM-MPR121
ptrbld/MMM-Button
ptrbld/mmm-pins
ptrbld/MMM-Podcast
ralberth/MMM-MinecraftStatus
ralberth/MMM-MysqlQuery
seb-ma/MMM-IT8951
semox/MMM-NearCompliments
shbatm/MMM-KeyBindings
Simon089/MMM-Swipe
tbouron/MMM-FlightTracker
whyjustin/magic-mirror-voice

[sdetweil]

there are others that moved rebuild to postinstall
( i did that)

[khassel]

there are others that moved rebuild to postinstall

and here module repositories from repo list which have the string postinstall inside their package.json and calling a script (and are not in the list above) which maybe contains electron rebuild stuff:

Ax-LED/MMM-Navigate
bugsounet/MMM-FranceInfo
bugsounet/MMM-Freebox
bugsounet/MMM-Glassy
bugsounet/MMM-MeteoFrance
bugsounet/MMM-NetatmoThermostat
bugsounet/MMM-PrixCarburants
bugsounet/MMM-Saint
dekinet/MMM-Soliscloud
eckonator/MMM-YouLess2
MMRIZE/MMM-CountEvents
MMRIZE/MMM-TelegramBot
rubinho101/MMM-01ZM
sdetweil/MMM-Config
shbatm/MMM-RTSPStream
thobach/MMM-Gestures
Tom-Hirschberger/MMM-MQTTbridge
Tom-Hirschberger/MMM-Serial-Notifications
Tom-Hirschberger/MMM-TouchButton
Tom-Hirschberger/MMM-ValuesByNotification

[bugsounet]

Maybe you search something like this ?

oops... Maybe I shouldn't disclose this either?

[khassel]

superseeded by #3733