Skip to content

Drop [project] from pyproject.toml for forward-compatibility - #903

Closed
Rongronggg9 wants to merge 1 commit into
MagicStack:masterfrom
Rongronggg9:fix/pep-621
Closed

Drop [project] from pyproject.toml for forward-compatibility#903
Rongronggg9 wants to merge 1 commit into
MagicStack:masterfrom
Rongronggg9:fix/pep-621

Conversation

@Rongronggg9

Copy link
Copy Markdown
Contributor

#900 (comment)

As @abravalheri advised, it is better to drop the [project] table from pyproject.toml to avoid the future releases of setuptools ignoring the configurations listed in setup.py.

@bszema

Copy link
Copy Markdown

any update on this review?

I have problem with building my docker because of this section.

@Rongronggg9

Rongronggg9 commented May 19, 2022

Copy link
Copy Markdown
ContributorAuthor

@bszema Upgrade setuptools before installing asyncpg should help. However, it is just a temporary workaround as documented in pypa/setuptools#3218.

pip install --no-cache-dir --upgrade pip setuptools wheel

@bszema

Copy link
Copy Markdown

@bszema Upgrade setuptools before installing asyncpg should help. However, it is just a temporary workaround as documented in pypa/setuptools#3218.

pip install --no-cache-dir --upgrade pip setuptools wheel

thanks a lot that helped!

@elprans

Copy link
Copy Markdown
Member

Fixed by #1045

@elpranselprans closed this Oct 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Rongronggg9@bszema@elprans