Skip to content

Add arm64 mac and linux wheels - #954

Merged
elprans merged 2 commits into
MagicStack:masterfrom
ddelange:patch-1
Sep 27, 2022
Merged

Add arm64 mac and linux wheels#954
elprans merged 2 commits into
MagicStack:masterfrom
ddelange:patch-1

Conversation

@ddelange

@ddelangeddelange commented Sep 17, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#870
Fixes#936
Fixes#950

This PR:

image

@ddelangeddelange mentioned this pull request Sep 17, 2022
Closed
@ddelangeddelange mentioned this pull request Sep 17, 2022
Closed
ddelange
ddelange commented Sep 18, 2022
View reviewed changes

@ddelangeddelange left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's anything from my side still, plz ping 🙏

Comment thread.github/workflows/install-postgres.sh
Comment thread.github/workflows/release.yml
CIBW_BUILD: ${{ matrix.build }} # py versions from setup.py -> python_requires
CIBW_SKIP: pp*
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
CIBW_MANYLINUX_AARCH64_IMAGE: manylinux_2_28

@ddelangeddelangeSep 18, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could remove these two completely, defaulting to manylinux_2_21 (which is built on centos RHEL7), also wrt backward compatibility ref giampaolo/psutil#2103 (comment)

Though on centos, CI also has postgres installation script issues (I started out with it), something about a bad GPG key also mentioned on the developer's 3rd party yum repo's issue tracker. Thought about doing a yum search (or smth) to download the exact URL for the respective postgres versions on the official repo.

In the end, I happily accepted gg when I saw the green ticks on CI as it is now.

Martin.Obiols.-.Can.t.stop.laughing.at.this.1255206061159714819.mp4

@elpranselpransSep 27, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try and keep compatibility with 2_21 at least.

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@ddelangeddelangeSep 27, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I think this thread is irrelevant, the current state of this PR (so building on almalinux8) already produces wheels that are backward compatible all the way to 2_17 ref https://github.com/ddelange/asyncpg/actions/runs/3121931647/jobs/5063553875#step:4:950

@ddelangeddelangeSep 27, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elprans I think in this respect we're good to go 👍

@staciax

staciax commented Sep 19, 2022

Copy link
Copy Markdown

hope 🥺

elprans
elprans reviewed Sep 19, 2022
View reviewed changes
Comment thread.github/workflows/release.yml Outdated
@ddelangeddelange mentioned this pull request Sep 20, 2022
Merged
@ddelange
Maximize parallellization (#2)
50277d9
* Maximize parallellization
* Bump cibuildwheel==2.10.2
* Prepare for merge
@ddelange

ddelange commented Sep 27, 2022

Copy link
Copy Markdown
ContributorAuthor

@elprans could you re-run failed CI?

@ddelangeddelange mentioned this pull request Sep 27, 2022
Closed
@elpranselprans mentioned this pull request Sep 27, 2022
Closed
elprans
elprans approved these changes Sep 27, 2022
View reviewed changes

@elpranselprans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for contributing!

@elprans
elprans merged commit 7bd6c49 into MagicStack:masterSep 27, 2022
@mbrav

mbrav commented Sep 28, 2022

Copy link
Copy Markdown

Thank you so much for this merge. I wanted to run a project using asyncpg on a Rpi some time ago but couldn't. Will have to check how it works out.

@staciax

staciax commented Oct 9, 2022

Copy link
Copy Markdown

thanks you so much
now i can running my project in ipad (m1)
<3

elprans added a commit that referenced this pull request Oct 26, 2022
@elprans
asyncpg v0.27.0
925cfe1
Support Python 3.11 and PostgreSQL 15. This release also drops support
for Python 3.6.
Changes
=======
* Add arm64 mac and linux wheels
(by @ddelange in 7bd6c49 for #954)
* Add Python 3.11 to the test matrix
(by @elprans in 5f908e6 for #948)
* Exclude .venv from flake8 (#958)
(by @jparise in 40b16ea for #958)
* Upgrade to flake8 5.0.4 (from 3.9.2) (#961)
(by @jparise in 0e73fec for #961)
* Show an example of a custom Record class (#960)
(by @jparise in 84c99bf for #960)
* Use the exact type name in Record.__repr__ (#959)
(by @jparise in eccdf61 for #959)
* Drop Python 3.6 support (#940)
(by @bryanforbes in bb0cb39 for #940)
* Test on Python 3.11 and PostgreSQL 15, fix workflow deprecations (#968)
(by @elprans in eab7fdf for #968)
@elpranselprans mentioned this pull request Oct 26, 2022
Merged
@ddelangeddelange mentioned this pull request Nov 27, 2022
Closed
This was referenced Jan 20, 2023
Merged
Closed
Merged
@ddelangeddelange mentioned this pull request Apr 4, 2024
Merged
@ddelangeddelange mentioned this pull request Feb 22, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elpranselpranselprans approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please support linux/aarch64 wheel releases Add wheel for aarch64 Reinstate aarch64 builds

4 participants

@ddelange@staciax@mbrav@elprans