Skip to content

Static Type-checking for httptools - #100

Merged
fantix merged 8 commits into
MagicStack:masterfrom
Vizonex:master
Oct 10, 2025
Merged

Static Type-checking for httptools#100
fantix merged 8 commits into
MagicStack:masterfrom
Vizonex:master

Conversation

@Vizonex

Copy link
Copy Markdown
Contributor

I felt the need to add static type-checking to this library in order to help other programmers with using this library. I hope this pull request will help out a few people with using this library.

Comment threadhttptools/parser/url_parser.pyi Outdated
fragment:bytes
userinfo:bytes

def parse_url(url:Union[bytes, bytearray, memoryview, array]) -> URL:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add spaces after colons for type annotations

@Vizonex

Vizonex commented Jul 17, 2024 via email

Copy link
Copy Markdown
ContributorAuthor

@KRRT7

KRRT7 commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

@DABND19 could you take a look? thanks

@DABND19

Copy link
Copy Markdown

@DABND19 could you take a look? thanks

Hi! I am not the maintainer of this repository, I just left my comments on this pull request :)

@Vizonex

Copy link
Copy Markdown
ContributorAuthor

thanks for the help. I was off doing other things that I had forgotten about this completely.

@fantix
fantix merged commit b55f5fe into MagicStack:masterOct 10, 2025
18 checks passed
fantix added a commit that referenced this pull request Oct 10, 2025
Changes
=======
* Modernize packaging and fix CI (#130)
Drop Python 3.8, add Python 3.14
Use Cython 3.1.0
Bump llhttp to 9.3.0
(by @ngoldbaum@Carreau@fantix in 59bf94f for #129)
* Static Type-checking for httptools (#100)
(by @Vizonex@KRRT7 in b55f5fe for #100)
@fantixfantix mentioned this pull request Oct 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Vizonex@KRRT7@DABND19@fantix