Fix loop.getaddrinfo() and tests - #495

Merged
fantix merged 3 commits into
masterfrom
t494-getaddrinfo
Sep 13, 2022
Merged

Fix loop.getaddrinfo() and tests#495
fantix merged 3 commits into
masterfrom
t494-getaddrinfo

Conversation

@fantix

@fantixfantix commented Sep 11, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Closes#494

Per https://www.openwall.com/lists/musl/2013/03/29/13:

it's a bug to assume a certain (libc) implementation has particular properties rather than testing.

So the idea here is to run the libc/libuv getaddrinfo() first when we need to run __static_getaddrinfo_pyaddr() for the first time with both AI_CANONNAME on and off each, and remember if ai_canonname is set or not so that we can do the same in the future calls to __static_getaddrinfo_pyaddr().

Update: uvloop static resolving always honor the AI_CANONNAME flag, while libuv-based resolving is still consistent with the libc impl.

@fantix
fantix requested a review from 1st1September 11, 2022 18:48
@fantix
Consistent loop.getaddrinfo() API
9f5397d
* ai_canonname is different across libc impls (#494)
* AddressFamily and SocketKind can be enums
* Also fixed failing test
1st1
1st1 reviewed Sep 11, 2022
View reviewed changes
Comment threaduvloop/loop.pyx Outdated
@fantix

fantix commented Sep 13, 2022

Copy link
Copy Markdown
MemberAuthor

As Elvis suggested, we should just follow the docs, regardless of how different libc impls are behaving, and tweak the tests to pass.

@fantixfantix changed the title Consistent loop.getaddrinfo() APIFix loop.getaddrinfo() and testsSep 13, 2022
@fantix
fantix merged commit 598b16f into masterSep 13, 2022
@fantix
fantix deleted the t494-getaddrinfo branch September 13, 2022 13:41
fantix added a commit that referenced this pull request Sep 13, 2022
@fantix
uvloop v0.17.0
c4c3f9f
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@fantixfantix mentioned this pull request Sep 13, 2022
Merged
fantix added a commit that referenced this pull request Sep 14, 2022
@fantix
uvloop v0.17.0
afb3268
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@coderabbitaicoderabbitaiBot mentioned this pull request Aug 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent static getaddrinfo() behavior on AI_CANONNAME

2 participants

@fantix@1st1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix loop.getaddrinfo() and tests - #495
Merged
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Sep 13, 2022
Merged
Fix loop.getaddrinfo() and tests#495
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Conversation
@fantix
@fantixfantix
commented
Sep 11, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Closes#494
Per https://www.openwall.com/lists/musl/2013/03/29/13:
it's a bug to assume a certain (libc) implementation has particular properties rather than testing.
So the idea here is to run the libc/libuv getaddrinfo() first when we need to run __static_getaddrinfo_pyaddr() for the first time with both AI_CANONNAME on and off each, and remember if ai_canonname is set or not so that we can do the same in the future calls to __static_getaddrinfo_pyaddr().
Update: uvloop static resolving always honor the AI_CANONNAME flag, while libuv-based resolving is still consistent with the libc impl.
@fantix
fantix
requested a review
from 1st1September 11, 2022 18:48
@fantix
Consistent loop.getaddrinfo() API
9f5397d
* ai_canonname is different across libc impls (#494)
* AddressFamily and SocketKind can be enums
* Also fixed failing test
1st1
1st1
reviewed
Sep 11, 2022
View reviewed changes
Comment threaduvloop/loop.pyx
Outdated

@fantix
fantix
commented
Sep 13, 2022

Copy link


Copy Markdown

MemberAuthor
As Elvis suggested, we should just follow the docs, regardless of how different libc impls are behaving, and tweak the tests to pass.
@fantixfantix
changed the title
Consistent loop.getaddrinfo() APIFix loop.getaddrinfo() and testsSep 13, 2022
@fantix
fantix
merged commit 598b16f
into
masterSep 13, 2022
@fantix
fantix
deleted the

t494-getaddrinfo

branch
September 13, 2022 13:41
fantix added a commit
that referenced
this pull request
Sep 13, 2022
@fantix
uvloop v0.17.0
c4c3f9f
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@fantixfantix
mentioned this pull request
Sep 13, 2022
 Merged

fantix added a commit
that referenced
this pull request
Sep 14, 2022
@fantix
uvloop v0.17.0
afb3268
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent static getaddrinfo() behavior on AI_CANONNAME


2 participants

@fantix@1st1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix loop.getaddrinfo() and tests - #495
Merged
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Sep 13, 2022
Merged
Fix loop.getaddrinfo() and tests#495
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Conversation
@fantix
@fantixfantix
commented
Sep 11, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Closes#494
Per https://www.openwall.com/lists/musl/2013/03/29/13:
it's a bug to assume a certain (libc) implementation has particular properties rather than testing.
So the idea here is to run the libc/libuv getaddrinfo() first when we need to run __static_getaddrinfo_pyaddr() for the first time with both AI_CANONNAME on and off each, and remember if ai_canonname is set or not so that we can do the same in the future calls to __static_getaddrinfo_pyaddr().
Update: uvloop static resolving always honor the AI_CANONNAME flag, while libuv-based resolving is still consistent with the libc impl.
@fantix
fantix
requested a review
from 1st1September 11, 2022 18:48
@fantix
Consistent loop.getaddrinfo() API
9f5397d
* ai_canonname is different across libc impls (#494)
* AddressFamily and SocketKind can be enums
* Also fixed failing test
1st1
1st1
reviewed
Sep 11, 2022
View reviewed changes
Comment threaduvloop/loop.pyx
Outdated

@fantix
fantix
commented
Sep 13, 2022

Copy link


Copy Markdown

MemberAuthor
As Elvis suggested, we should just follow the docs, regardless of how different libc impls are behaving, and tweak the tests to pass.
@fantixfantix
changed the title
Consistent loop.getaddrinfo() APIFix loop.getaddrinfo() and testsSep 13, 2022
@fantix
fantix
merged commit 598b16f
into
masterSep 13, 2022
@fantix
fantix
deleted the

t494-getaddrinfo

branch
September 13, 2022 13:41
fantix added a commit
that referenced
this pull request
Sep 13, 2022
@fantix
uvloop v0.17.0
c4c3f9f
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@fantixfantix
mentioned this pull request
Sep 13, 2022
 Merged

fantix added a commit
that referenced
this pull request
Sep 14, 2022
@fantix
uvloop v0.17.0
afb3268
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent static getaddrinfo() behavior on AI_CANONNAME


2 participants

@fantix@1st1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix loop.getaddrinfo() and tests - #495
Merged
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Sep 13, 2022
Merged
Fix loop.getaddrinfo() and tests#495
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Conversation
@fantix
@fantixfantix
commented
Sep 11, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Closes#494
Per https://www.openwall.com/lists/musl/2013/03/29/13:
it's a bug to assume a certain (libc) implementation has particular properties rather than testing.
So the idea here is to run the libc/libuv getaddrinfo() first when we need to run __static_getaddrinfo_pyaddr() for the first time with both AI_CANONNAME on and off each, and remember if ai_canonname is set or not so that we can do the same in the future calls to __static_getaddrinfo_pyaddr().
Update: uvloop static resolving always honor the AI_CANONNAME flag, while libuv-based resolving is still consistent with the libc impl.
@fantix
fantix
requested a review
from 1st1September 11, 2022 18:48
@fantix
Consistent loop.getaddrinfo() API
9f5397d
* ai_canonname is different across libc impls (#494)
* AddressFamily and SocketKind can be enums
* Also fixed failing test
1st1
1st1
reviewed
Sep 11, 2022
View reviewed changes
Comment threaduvloop/loop.pyx
Outdated

@fantix
fantix
commented
Sep 13, 2022

Copy link


Copy Markdown

MemberAuthor
As Elvis suggested, we should just follow the docs, regardless of how different libc impls are behaving, and tweak the tests to pass.
@fantixfantix
changed the title
Consistent loop.getaddrinfo() APIFix loop.getaddrinfo() and testsSep 13, 2022
@fantix
fantix
merged commit 598b16f
into
masterSep 13, 2022
@fantix
fantix
deleted the

t494-getaddrinfo

branch
September 13, 2022 13:41
fantix added a commit
that referenced
this pull request
Sep 13, 2022
@fantix
uvloop v0.17.0
c4c3f9f
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@fantixfantix
mentioned this pull request
Sep 13, 2022
 Merged

fantix added a commit
that referenced
this pull request
Sep 14, 2022
@fantix
uvloop v0.17.0
afb3268
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent static getaddrinfo() behavior on AI_CANONNAME


2 participants

@fantix@1st1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix loop.getaddrinfo() and tests - #495
Merged
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Sep 13, 2022
Merged
Fix loop.getaddrinfo() and tests#495
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Conversation
@fantix
@fantixfantix
commented
Sep 11, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Closes#494
Per https://www.openwall.com/lists/musl/2013/03/29/13:
it's a bug to assume a certain (libc) implementation has particular properties rather than testing.
So the idea here is to run the libc/libuv getaddrinfo() first when we need to run __static_getaddrinfo_pyaddr() for the first time with both AI_CANONNAME on and off each, and remember if ai_canonname is set or not so that we can do the same in the future calls to __static_getaddrinfo_pyaddr().
Update: uvloop static resolving always honor the AI_CANONNAME flag, while libuv-based resolving is still consistent with the libc impl.
@fantix
fantix
requested a review
from 1st1September 11, 2022 18:48
@fantix
Consistent loop.getaddrinfo() API
9f5397d
* ai_canonname is different across libc impls (#494)
* AddressFamily and SocketKind can be enums
* Also fixed failing test
1st1
1st1
reviewed
Sep 11, 2022
View reviewed changes
Comment threaduvloop/loop.pyx
Outdated

@fantix
fantix
commented
Sep 13, 2022

Copy link


Copy Markdown

MemberAuthor
As Elvis suggested, we should just follow the docs, regardless of how different libc impls are behaving, and tweak the tests to pass.
@fantixfantix
changed the title
Consistent loop.getaddrinfo() APIFix loop.getaddrinfo() and testsSep 13, 2022
@fantix
fantix
merged commit 598b16f
into
masterSep 13, 2022
@fantix
fantix
deleted the

t494-getaddrinfo

branch
September 13, 2022 13:41
fantix added a commit
that referenced
this pull request
Sep 13, 2022
@fantix
uvloop v0.17.0
c4c3f9f
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@fantixfantix
mentioned this pull request
Sep 13, 2022
 Merged

fantix added a commit
that referenced
this pull request
Sep 14, 2022
@fantix
uvloop v0.17.0
afb3268
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent static getaddrinfo() behavior on AI_CANONNAME


2 participants

@fantix@1st1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix loop.getaddrinfo() and tests - #495
Merged
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Sep 13, 2022
Merged
Fix loop.getaddrinfo() and tests#495
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Conversation
@fantix
@fantixfantix
commented
Sep 11, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Closes#494
Per https://www.openwall.com/lists/musl/2013/03/29/13:
it's a bug to assume a certain (libc) implementation has particular properties rather than testing.
So the idea here is to run the libc/libuv getaddrinfo() first when we need to run __static_getaddrinfo_pyaddr() for the first time with both AI_CANONNAME on and off each, and remember if ai_canonname is set or not so that we can do the same in the future calls to __static_getaddrinfo_pyaddr().
Update: uvloop static resolving always honor the AI_CANONNAME flag, while libuv-based resolving is still consistent with the libc impl.
@fantix
fantix
requested a review
from 1st1September 11, 2022 18:48
@fantix
Consistent loop.getaddrinfo() API
9f5397d
* ai_canonname is different across libc impls (#494)
* AddressFamily and SocketKind can be enums
* Also fixed failing test
1st1
1st1
reviewed
Sep 11, 2022
View reviewed changes
Comment threaduvloop/loop.pyx
Outdated

@fantix
fantix
commented
Sep 13, 2022

Copy link


Copy Markdown

MemberAuthor
As Elvis suggested, we should just follow the docs, regardless of how different libc impls are behaving, and tweak the tests to pass.
@fantixfantix
changed the title
Consistent loop.getaddrinfo() APIFix loop.getaddrinfo() and testsSep 13, 2022
@fantix
fantix
merged commit 598b16f
into
masterSep 13, 2022
@fantix
fantix
deleted the

t494-getaddrinfo

branch
September 13, 2022 13:41
fantix added a commit
that referenced
this pull request
Sep 13, 2022
@fantix
uvloop v0.17.0
c4c3f9f
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@fantixfantix
mentioned this pull request
Sep 13, 2022
 Merged

fantix added a commit
that referenced
this pull request
Sep 14, 2022
@fantix
uvloop v0.17.0
afb3268
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent static getaddrinfo() behavior on AI_CANONNAME


2 participants

@fantix@1st1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix loop.getaddrinfo() and tests - #495
Merged
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Sep 13, 2022
Merged
Fix loop.getaddrinfo() and tests#495
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Conversation
@fantix
@fantixfantix
commented
Sep 11, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Closes#494
Per https://www.openwall.com/lists/musl/2013/03/29/13:
it's a bug to assume a certain (libc) implementation has particular properties rather than testing.
So the idea here is to run the libc/libuv getaddrinfo() first when we need to run __static_getaddrinfo_pyaddr() for the first time with both AI_CANONNAME on and off each, and remember if ai_canonname is set or not so that we can do the same in the future calls to __static_getaddrinfo_pyaddr().
Update: uvloop static resolving always honor the AI_CANONNAME flag, while libuv-based resolving is still consistent with the libc impl.
@fantix
fantix
requested a review
from 1st1September 11, 2022 18:48
@fantix
Consistent loop.getaddrinfo() API
9f5397d
* ai_canonname is different across libc impls (#494)
* AddressFamily and SocketKind can be enums
* Also fixed failing test
1st1
1st1
reviewed
Sep 11, 2022
View reviewed changes
Comment threaduvloop/loop.pyx
Outdated

@fantix
fantix
commented
Sep 13, 2022

Copy link


Copy Markdown

MemberAuthor
As Elvis suggested, we should just follow the docs, regardless of how different libc impls are behaving, and tweak the tests to pass.
@fantixfantix
changed the title
Consistent loop.getaddrinfo() APIFix loop.getaddrinfo() and testsSep 13, 2022
@fantix
fantix
merged commit 598b16f
into
masterSep 13, 2022
@fantix
fantix
deleted the

t494-getaddrinfo

branch
September 13, 2022 13:41
fantix added a commit
that referenced
this pull request
Sep 13, 2022
@fantix
uvloop v0.17.0
c4c3f9f
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@fantixfantix
mentioned this pull request
Sep 13, 2022
 Merged

fantix added a commit
that referenced
this pull request
Sep 14, 2022
@fantix
uvloop v0.17.0
afb3268
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent static getaddrinfo() behavior on AI_CANONNAME


2 participants

@fantix@1st1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix loop.getaddrinfo() and tests - #495
Merged
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Sep 13, 2022
Merged
Fix loop.getaddrinfo() and tests#495
fantix merged 3 commits into
masterfrom 
t494-getaddrinfo
Conversation
@fantix
@fantixfantix
commented
Sep 11, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Closes#494
Per https://www.openwall.com/lists/musl/2013/03/29/13:
it's a bug to assume a certain (libc) implementation has particular properties rather than testing.
So the idea here is to run the libc/libuv getaddrinfo() first when we need to run __static_getaddrinfo_pyaddr() for the first time with both AI_CANONNAME on and off each, and remember if ai_canonname is set or not so that we can do the same in the future calls to __static_getaddrinfo_pyaddr().
Update: uvloop static resolving always honor the AI_CANONNAME flag, while libuv-based resolving is still consistent with the libc impl.
@fantix
fantix
requested a review
from 1st1September 11, 2022 18:48
@fantix
Consistent loop.getaddrinfo() API
9f5397d
* ai_canonname is different across libc impls (#494)
* AddressFamily and SocketKind can be enums
* Also fixed failing test
1st1
1st1
reviewed
Sep 11, 2022
View reviewed changes
Comment threaduvloop/loop.pyx
Outdated

@fantix
fantix
commented
Sep 13, 2022

Copy link


Copy Markdown

MemberAuthor
As Elvis suggested, we should just follow the docs, regardless of how different libc impls are behaving, and tweak the tests to pass.
@fantixfantix
changed the title
Consistent loop.getaddrinfo() APIFix loop.getaddrinfo() and testsSep 13, 2022
@fantix
fantix
merged commit 598b16f
into
masterSep 13, 2022
@fantix
fantix
deleted the

t494-getaddrinfo

branch
September 13, 2022 13:41
fantix added a commit
that referenced
this pull request
Sep 13, 2022
@fantix
uvloop v0.17.0
c4c3f9f
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@fantixfantix
mentioned this pull request
Sep 13, 2022
 Merged

fantix added a commit
that referenced
this pull request
Sep 14, 2022
@fantix
uvloop v0.17.0
afb3268
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.
Changes
=======
* Expose uv_loop_t pointer for integration with other C-extensions (#310)
(by @pranavtbhat in b332eb8 for #310)
* Support python 3.11+ (#473)
(by @zeroday0619 in 8e42921 for #473)
* Expose libuv uv_fs_event functionality (#474)
(by @jensbjorgensen@fantix in 74d381e for #474)
* Activate debug mode when `-X dev` is used
(by @jack1142 in 637a77a)
* Expose uv_version() for libuv API compatibility (#491)
(by @fantix in 089f6cb for #491)
* Fix loop.getaddrinfo() and tests (#495)
(by @fantix in 598b16f for #495)
* Bump to libuv 1.43.0
(by @fantix in 94e5e53)
Fixes
=====
* _TransProtPair is no longer defined in asyncio.events
(by @jensbjorgensen in fae5f7f)
* use a TypeVar for asyncio.BaseProtocol (#478)
(by @graingert in 3aacb35 for #478)
* Fix segfault in TimerHandle.when() after cleared
(by @jensbjorgensen in c39afff for #469)
* Avoid self._errpipe_write double close (#466)
(by @graingert in 72140d7 for #466)
* Fix typo in test (#456)
(by @kianmeng in 033d52d for #456)
* Fix potential infinite loop (#446)
(by @kfur in ada43c0 for #446)
* use a stack of self._fds_to_close to prevent double closes (#481)
(by @graingert in 3214cf6 for #481)
* Fix incorrect main thread id value forking from a thread (#453)
(by @horpto@fantix in e7934c8 for #453)
* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
(by @byllyfish in e04637e for #439)
* Queue write only after processing all buffers (#445)
(by @jakirkham@fantix in 9c6ecb6 for #445)
* Drop Python 3.6 support for thread ident
(by @fantix in 9c37930)
* bugfix: write to another transport in resume_writing() fails (#498)
(by @fantix in d2deffe for #498)
Build
=====
* Upgrade GitHub Actions (#477) (#480)
(by @cclauss in fcbf422 for #477, 1008694 for #480)
* typo `same as same`
(by @YoSTEALTH in fedba80)
* setup.py: allow to override extra_compile_args (#443)
(by @giuliobenetti in a130375 for #443)
* Drop hack in setup.py in finalize_options (492)
(by @fantix in 2f1bc83 for #492)
* Fix tests invocation on release CI worklow (#489)
(by @ben9923 in d6a2b59 for #489)
Documentation
=============
* use asyncio.Runner loop_factory on 3.11+ (#472)
(by @graingert in 31ba48c for #472)
* Fix CI badge in docs, remove remaining Travis CI references from docs
(by @Nothing4You in c6901a7)
* Fix typo in README
(by @monosans in 73d7253)
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 11, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@1st11st11st1 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent static getaddrinfo() behavior on AI_CANONNAME


2 participants

@fantix@1st1