Skip to content

fix: changed sub_tile regex - #76

Merged
syncush merged 2 commits into
masterfrom
NivGreenstein-patch-1
Sep 15, 2025
Merged

fix: changed sub_tile regex#76
syncush merged 2 commits into
masterfrom
NivGreenstein-patch-1

Conversation

@NivGreenstein

Copy link
Copy Markdown
Contributor
QuestionAnswer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

Related issues: #XXX , #XXX ...
Closes #XXX ...

Further information:
fixed subtile regex

@NivGreensteinNivGreenstein self-assigned this Jun 8, 2025

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the regex for validating the “Sub tile number” field to allow zero and multi-digit values.

  • Relaxed the numeric pattern to accept 0 and leading zeros.
  • Adjusted schema only; no functional endpoints were added or removed.
Comments suppressed due to low confidence (2)

openapi3.yaml:235

  • [nitpick] Clarify in the description that 0 and values with leading zeros are now valid, so API consumers understand the new allowance.
description: Sub tile number

openapi3.yaml:238

  • Add or update schema validation tests to cover edge cases like "0", "00", and multi-digit inputs to ensure the regex works as intended.
pattern: ^[0-9][0-9]*$

Comment threadopenapi3.yaml

@hadaromerhadaromer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syncush
syncush merged commit 8a066ee into masterSep 15, 2025
@syncush
syncush deleted the NivGreenstein-patch-1 branch September 15, 2025 07:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@NivGreenstein@syncush@hadaromer