Uh oh!
There was an error while loading. Please reload this page.
fix(ingest): build with rust 1.94, unbreaking the deploy - #534
Merged
Conversation
The clippy cleanup (#523) followed the pedantic suggestion to construct Durations with from_mins/from_hours - APIs that need rust >= 1.91. CI tests build with the mise-pinned 1.94.1 and passed, but the Railway Dockerfile and the deploy/probe workflows all build in rust:1.88 images, so every ingest deploy since #523 fails with E0658 duration_constructors (main.rs:1470, :1570, :2181). - Bump rust:1.88 -> rust:1.94-bookworm in the Dockerfile (pinned to bookworm explicitly so the build glibc can't drift past the debian:bookworm-slim runner stage) and in deploy-prd, deploy-stg and aws-probe. - Pin msrv = "1.94" in clippy.toml so suggestion lints can't propose APIs newer than the deploy toolchain again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🍁 Maple PR previewNote Preview resources were removed when this pull request closed. Final commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ingest deploys have failed since #523: the clippy cleanup adopted
Duration::from_mins/from_hours(pedantic suggestion), which need rust ≥ 1.91. CI builds with the mise-pinned 1.94.1 and stayed green, but the Railway Dockerfile and the deploy workflows build inrust:1.88images, so both the GHBuild ingest binarystep and Railway's Dockerfile build die withE0658: use of unstable library feature 'duration_constructors'(main.rs:1470/:1570/:2181). The previous Railway deployment is still serving.rust:1.88→rust:1.94-bookworminapps/ingest/Dockerfile(explicit bookworm pin so build-stage glibc can't drift past thedebian:bookworm-slimrunner stage),deploy-prd.yml,deploy-stg.yml,aws-probe.yml.msrv = "1.94"inclippy.toml, so MSRV-gated suggestion lints can't propose beyond-toolchain APIs again — this is the guard that would have prevented the incident.Verified: ingest tests green (171), clippy zero warnings with the msrv pin,
rust:1.94-bookwormexists on Docker Hub.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.