') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Use assembly loading context to isolate loaded assemblies from AppDomain #714 by boylec · Pull Request #716 · MapsterMapper/Mapster · GitHub
Skip to content

Use assembly loading context to isolate loaded assemblies from AppDomain #714 - #716

Merged
andrerav merged 9 commits into
MapsterMapper:developmentfrom
True-Velocity:fix/isolated-assemblies
Jan 2, 2025
Merged

Use assembly loading context to isolate loaded assemblies from AppDomain #714#716
andrerav merged 9 commits into
MapsterMapper:developmentfrom
True-Velocity:fix/isolated-assemblies

Conversation

@boylec

@boylecboylec commented Jun 15, 2024

Copy link
Copy Markdown
Contributor

Mapster.Tool update to solve issue #714

TL; DR

Replace Assembly.LoadFrom calls with something more robust that prevents assembly/type collisions between the assemblies in the running Mapster.Tool process (such as .NET framework assemblies) and the scanned assemblies - while also preserving the ability to scan for attributes that are in the Mapster assembly (using share Assembly resolution).

See Pertinent MSFT Docs

More detail

Added an AssemblyLoadContext implementation for dynamically loading assemblies when scanning in an isolated way so that they don't have collisions with all of the assemblies loaded by Mapster by default (for example framework assemblies such as System.Text.Json).

The implementation also allows the setting of a subset of assembly names that will be shared with AssemblyLoadContext.Default (the default context that all assemblies are resolved from if no custom ALC were created). Some scanned types need to be owned by the default assembly context such as those from the "Mapster" assembly.

The end result is that we can resolve types from the target assembly being scanned, and we can do things like .GetCustomAttribute() and the attribute will be found because it comes from a shared assembly across the default (runtime) AssemblyLoadContext and the custom one used to avoid collisions.

@boylec

boylec commented Jun 16, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@andrerav what are the chances this can get merged any time soon and released as pre release?

Our org relies on this package and this is a blocker for us.

We can run off of our fork if it's going to be awhile.

Thanks!

@boylec
boylecforce-pushed the fix/isolated-assemblies branch from 9f42a48 to 86fd5c4CompareJune 17, 2024 20:46
andrerav
andrerav requested changes Dec 22, 2024
View reviewed changes
Comment threadsrc/nuget.config Outdated
@boylec

boylec commented Jan 2, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav done and done thanks!

@andrerav
andrerav merged commit 1457dce into MapsterMapper:developmentJan 2, 2025
@andrerav

andrerav commented Jan 2, 2025

Copy link
Copy Markdown
Member

Thank you for this awesome contribution @boylec. If you have some extra time to spare, please update the Wiki to reflect the new API changes.

@boylec

boylec commented Jan 2, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@andrerav as far as I can tell there are no changes to consumer-facing APIs of the library.

It has been a long time since I made this change though, are you seeing something specific?

Also: you're very welcome!

@andrerav

andrerav commented Jan 2, 2025

Copy link
Copy Markdown
Member

Ah, disregard that. I had a brief lapse of reason :)

This was referenced Mar 19, 2026
Merged
Open
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
This was referenced Jun 18, 2026
Closed
Closed
Closed
This was referenced Jun 25, 2026
Closed
Closed
Open
Open
Closed
This was referenced Jul 3, 2026
Closed
Closed
Closed
This was referenced Jul 16, 2026
Merged
Open
Closed
Open
This was referenced Jul 25, 2026
Closed
Open
Closed
Open
Closed
Merged
This was referenced Aug 1, 2026
Closed
Closed
Open
Closed
This was referenced Aug 22, 2026
Closed
Open
Closed
Open
@dependabotdependabotBot mentioned this pull request Aug 31, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreravandreravandrerav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boylec@andrerav