Updated version numbers to 10.0.0-pre01. + net 10 - #841

Merged
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre
Dec 31, 2025
Merged

Updated version numbers to 10.0.0-pre01. + net 10#841
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre

Conversation

@DocSvartz

Copy link
Copy Markdown
Contributor

No description provided.

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS If #622 is relevant?
First step, need to retarget mapster.core and mapster.sourceGenerator to netstandard2.0 and do not change the TFM for these solutions.

@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz added comment on the issue.

Side Note for you: if you link to an issue or PR or similar, did you know that when your current line is a list (-) github will not just link it like you see it now, then show it with:

  • Status of the linked item (open/closed)
  • Title of the issue

I myself favorite to use this, since I get to know this. Perfectly suitable for e.g. "EPIC" Issue lists that are meant to collect multiple issues as links with status on one place. For example:

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS It was more of a short explanation of why two files had different changes than the others and that this is not a misprint. :)

@DocSvartz

DocSvartz commented Dec 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS
Regarding features, this is already a release, I don't plan to add anything.

The only thing I'm thinking about is moving the temporary configuration work into a separate project Mapster.Experemental Mapster.Experimental:

It will be able to accept new features as candidates for the main Mapster project. Let me know if this is a good idea. :)

In relation to:

I wanted to combine the work on these two projects (both would involve changes to the API configuration).
But so far, it's not working out very well.
It will likely be two steps with two API configuration changes. 😒

@stagep

Copy link
Copy Markdown

@docs FYI Experimental is the correct spelling :)

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@stagep yes.
I decided to brush up on how Mapster works again. And it seems I've gone crazy again.🤣 🤪

Comment threadsrc/Mapster.Immutable.Tests/Mapster.Immutable.Tests.csproj Outdated
Comment threadsrc/Mapster.Async.Tests/Mapster.Async.Tests.csproj Outdated
<Version>9.0.0-pre01</Version>
<Version>10.0.0-pre01</Version>
<PackageLicenseUrl>https://github.com/chaowlert/ExpressionDebugger/blob/master/LICENSE</PackageLicenseUrl>
<LangVersion>8.0</LangVersion>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DocSvartz@andrerav Is there a specific reason to use a LangVersion in here?

Comment threadsrc/Mapster.EFCore.Tests/Mapster.EFCore.Tests.csproj Outdated
Comment threadsrc/Mapster.JsonNet/Mapster.JsonNet.csproj
Comment threadsrc/Mapster.Tool.Tests/Mapster.Tool.Tests.csproj Outdated
Comment threadsrc/TemplateTest/TemplateTest.csproj Outdated
@DevTKSS

DevTKSS commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

@DocSvartz@andrerav Seeing all the repeating of Properties here I would like to suggest to:

  • use Directory.Packages.props -> introduce CPM

    • only one place we need to update
    • Configurable along with the Variables of Directory.Build.props if you want to ensure to use specific versions of packages for projects like Source Generators or Test Projects (which by the way are missing the common IsTestProject Tag, which I added as suggestion to this PR directly)
  • use Directory.Build.props

    • Define NuGet Package Information Centrally - e.g. I found this here and copied it to my own Repo + adjusted the Properties (Name, License etc.) I dont use it by now, so adding some other references:

    • source regular Project Props we need repentantly using Variables for example:

      • Directory.Build.props

        <Project>
        <PropertyGroup>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
        <DefaultTargetFrameworks>net10.0;net9.0;net8.0</DefaultTargetFrameworks>
        <Authors>Some Name;Some OtherName</Authors>
        </PropertyGroup>
        </Project>
      • Regular *.csproj

        <ProjectSdk="Microsoft.NET.Sdk">
        <PropertyGroup>
        <TargetFrameworks>$(DefaultTargetFrameworks)</TargetFrameworks>
        <RootNamespace>Mapster</RootNamespace>
        <AssemblyName>Mapster</AssemblyName>
        <Authors>$(Authors)</Authors>
        <OutputType>Library</OutputType>
        </PropertyGroup>
        </Project>
  • Update the Authors Entries?

    Never seen those Names recently and @andrerav mentioned in the discussion, he is the only Maintainer except from @DocSvartz and @stagep (potentially missed one 😄 but you get what I mean hopefully) which I did not see in one of those Lists.

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS

use Directory.Packages.props -> introduce CPM

This already exists.
But there are a number of problems with this:

  1. It just doesn't seem to work due to some properties being overridden in the projects themselves.
  2. If auto-generation is used (benchmark projects), such projects may not build, at least in IDE. Because projects require a signature.

IsTestProject

I've seen issue in NUnit that in certain CI/CD pipelines, tests don't run without it. But tests work for us. Now I'm wondering if the tests will run twice.
@DevTKSS Have you seen any problems associated with this?🤔😅

@DocSvartz
DocSvartzforce-pushed the 10-pre branch 2 times, most recently from 426fcdd to 538f8c9CompareDecember 28, 2025 03:02
@DocSvartz

DocSvartz commented Dec 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS
It's strange that after adding <IsTestProject>true</IsTestProject>, the tests passed, but the build failed.
Try add the Suggested again, but only to one file.

-- Update
Suggested not build
Perhaps some protection against third-party commits is configured in PR 🤔
If I add it myself, the build passes.

Co-authored-by: DevTKSS <info@technische-konstruktion.com>
@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz I did only run tests locally so far and not had to work with signing 🤔 and I am using xUnit v3 for testing which has support for many CI CD testing setups with predelivered worflows/samples

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS If this is important, please move these to separate issues:

This is not entirely related to the version number change and the addition of a new TFM. Moreover, this issues can be resolved independently.

@DocSvartz
DocSvartz removed the request for review from andreravDecember 31, 2025 05:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DocSvartz@DevTKSS@stagep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Updated version numbers to 10.0.0-pre01. + net 10 - #841

Merged
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre
Dec 31, 2025
Merged

Updated version numbers to 10.0.0-pre01. + net 10#841
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre

Conversation

@DocSvartz

Copy link
Copy Markdown
Contributor

No description provided.

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS If #622 is relevant?
First step, need to retarget mapster.core and mapster.sourceGenerator to netstandard2.0 and do not change the TFM for these solutions.

@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz added comment on the issue.

Side Note for you: if you link to an issue or PR or similar, did you know that when your current line is a list (-) github will not just link it like you see it now, then show it with:

  • Status of the linked item (open/closed)
  • Title of the issue

I myself favorite to use this, since I get to know this. Perfectly suitable for e.g. "EPIC" Issue lists that are meant to collect multiple issues as links with status on one place. For example:

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS It was more of a short explanation of why two files had different changes than the others and that this is not a misprint. :)

@DocSvartz

DocSvartz commented Dec 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS
Regarding features, this is already a release, I don't plan to add anything.

The only thing I'm thinking about is moving the temporary configuration work into a separate project Mapster.Experemental Mapster.Experimental:

It will be able to accept new features as candidates for the main Mapster project. Let me know if this is a good idea. :)

In relation to:

I wanted to combine the work on these two projects (both would involve changes to the API configuration).
But so far, it's not working out very well.
It will likely be two steps with two API configuration changes. 😒

@stagep

Copy link
Copy Markdown

@docs FYI Experimental is the correct spelling :)

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@stagep yes.
I decided to brush up on how Mapster works again. And it seems I've gone crazy again.🤣 🤪

Comment threadsrc/Mapster.Immutable.Tests/Mapster.Immutable.Tests.csproj Outdated
Comment threadsrc/Mapster.Async.Tests/Mapster.Async.Tests.csproj Outdated
<Version>9.0.0-pre01</Version>
<Version>10.0.0-pre01</Version>
<PackageLicenseUrl>https://github.com/chaowlert/ExpressionDebugger/blob/master/LICENSE</PackageLicenseUrl>
<LangVersion>8.0</LangVersion>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DocSvartz@andrerav Is there a specific reason to use a LangVersion in here?

Comment threadsrc/Mapster.EFCore.Tests/Mapster.EFCore.Tests.csproj Outdated
Comment threadsrc/Mapster.JsonNet/Mapster.JsonNet.csproj
Comment threadsrc/Mapster.Tool.Tests/Mapster.Tool.Tests.csproj Outdated
Comment threadsrc/TemplateTest/TemplateTest.csproj Outdated
@DevTKSS

DevTKSS commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

@DocSvartz@andrerav Seeing all the repeating of Properties here I would like to suggest to:

  • use Directory.Packages.props -> introduce CPM

    • only one place we need to update
    • Configurable along with the Variables of Directory.Build.props if you want to ensure to use specific versions of packages for projects like Source Generators or Test Projects (which by the way are missing the common IsTestProject Tag, which I added as suggestion to this PR directly)
  • use Directory.Build.props

    • Define NuGet Package Information Centrally - e.g. I found this here and copied it to my own Repo + adjusted the Properties (Name, License etc.) I dont use it by now, so adding some other references:

    • source regular Project Props we need repentantly using Variables for example:

      • Directory.Build.props

        <Project>
        <PropertyGroup>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
        <DefaultTargetFrameworks>net10.0;net9.0;net8.0</DefaultTargetFrameworks>
        <Authors>Some Name;Some OtherName</Authors>
        </PropertyGroup>
        </Project>
      • Regular *.csproj

        <ProjectSdk="Microsoft.NET.Sdk">
        <PropertyGroup>
        <TargetFrameworks>$(DefaultTargetFrameworks)</TargetFrameworks>
        <RootNamespace>Mapster</RootNamespace>
        <AssemblyName>Mapster</AssemblyName>
        <Authors>$(Authors)</Authors>
        <OutputType>Library</OutputType>
        </PropertyGroup>
        </Project>
  • Update the Authors Entries?

    Never seen those Names recently and @andrerav mentioned in the discussion, he is the only Maintainer except from @DocSvartz and @stagep (potentially missed one 😄 but you get what I mean hopefully) which I did not see in one of those Lists.

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS

use Directory.Packages.props -> introduce CPM

This already exists.
But there are a number of problems with this:

  1. It just doesn't seem to work due to some properties being overridden in the projects themselves.
  2. If auto-generation is used (benchmark projects), such projects may not build, at least in IDE. Because projects require a signature.

IsTestProject

I've seen issue in NUnit that in certain CI/CD pipelines, tests don't run without it. But tests work for us. Now I'm wondering if the tests will run twice.
@DevTKSS Have you seen any problems associated with this?🤔😅

@DocSvartz
DocSvartzforce-pushed the 10-pre branch 2 times, most recently from 426fcdd to 538f8c9CompareDecember 28, 2025 03:02
@DocSvartz

DocSvartz commented Dec 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS
It's strange that after adding <IsTestProject>true</IsTestProject>, the tests passed, but the build failed.
Try add the Suggested again, but only to one file.

-- Update
Suggested not build
Perhaps some protection against third-party commits is configured in PR 🤔
If I add it myself, the build passes.

Co-authored-by: DevTKSS <info@technische-konstruktion.com>
@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz I did only run tests locally so far and not had to work with signing 🤔 and I am using xUnit v3 for testing which has support for many CI CD testing setups with predelivered worflows/samples

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS If this is important, please move these to separate issues:

This is not entirely related to the version number change and the addition of a new TFM. Moreover, this issues can be resolved independently.

@DocSvartz
DocSvartz removed the request for review from andreravDecember 31, 2025 05:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DocSvartz@DevTKSS@stagep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Updated version numbers to 10.0.0-pre01. + net 10 - #841

Merged
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre
Dec 31, 2025
Merged

Updated version numbers to 10.0.0-pre01. + net 10#841
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre

Conversation

@DocSvartz

Copy link
Copy Markdown
Contributor

No description provided.

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS If #622 is relevant?
First step, need to retarget mapster.core and mapster.sourceGenerator to netstandard2.0 and do not change the TFM for these solutions.

@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz added comment on the issue.

Side Note for you: if you link to an issue or PR or similar, did you know that when your current line is a list (-) github will not just link it like you see it now, then show it with:

  • Status of the linked item (open/closed)
  • Title of the issue

I myself favorite to use this, since I get to know this. Perfectly suitable for e.g. "EPIC" Issue lists that are meant to collect multiple issues as links with status on one place. For example:

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS It was more of a short explanation of why two files had different changes than the others and that this is not a misprint. :)

@DocSvartz

DocSvartz commented Dec 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS
Regarding features, this is already a release, I don't plan to add anything.

The only thing I'm thinking about is moving the temporary configuration work into a separate project Mapster.Experemental Mapster.Experimental:

It will be able to accept new features as candidates for the main Mapster project. Let me know if this is a good idea. :)

In relation to:

I wanted to combine the work on these two projects (both would involve changes to the API configuration).
But so far, it's not working out very well.
It will likely be two steps with two API configuration changes. 😒

@stagep

Copy link
Copy Markdown

@docs FYI Experimental is the correct spelling :)

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@stagep yes.
I decided to brush up on how Mapster works again. And it seems I've gone crazy again.🤣 🤪

Comment threadsrc/Mapster.Immutable.Tests/Mapster.Immutable.Tests.csproj Outdated
Comment threadsrc/Mapster.Async.Tests/Mapster.Async.Tests.csproj Outdated
<Version>9.0.0-pre01</Version>
<Version>10.0.0-pre01</Version>
<PackageLicenseUrl>https://github.com/chaowlert/ExpressionDebugger/blob/master/LICENSE</PackageLicenseUrl>
<LangVersion>8.0</LangVersion>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DocSvartz@andrerav Is there a specific reason to use a LangVersion in here?

Comment threadsrc/Mapster.EFCore.Tests/Mapster.EFCore.Tests.csproj Outdated
Comment threadsrc/Mapster.JsonNet/Mapster.JsonNet.csproj
Comment threadsrc/Mapster.Tool.Tests/Mapster.Tool.Tests.csproj Outdated
Comment threadsrc/TemplateTest/TemplateTest.csproj Outdated
@DevTKSS

DevTKSS commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

@DocSvartz@andrerav Seeing all the repeating of Properties here I would like to suggest to:

  • use Directory.Packages.props -> introduce CPM

    • only one place we need to update
    • Configurable along with the Variables of Directory.Build.props if you want to ensure to use specific versions of packages for projects like Source Generators or Test Projects (which by the way are missing the common IsTestProject Tag, which I added as suggestion to this PR directly)
  • use Directory.Build.props

    • Define NuGet Package Information Centrally - e.g. I found this here and copied it to my own Repo + adjusted the Properties (Name, License etc.) I dont use it by now, so adding some other references:

    • source regular Project Props we need repentantly using Variables for example:

      • Directory.Build.props

        <Project>
        <PropertyGroup>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
        <DefaultTargetFrameworks>net10.0;net9.0;net8.0</DefaultTargetFrameworks>
        <Authors>Some Name;Some OtherName</Authors>
        </PropertyGroup>
        </Project>
      • Regular *.csproj

        <ProjectSdk="Microsoft.NET.Sdk">
        <PropertyGroup>
        <TargetFrameworks>$(DefaultTargetFrameworks)</TargetFrameworks>
        <RootNamespace>Mapster</RootNamespace>
        <AssemblyName>Mapster</AssemblyName>
        <Authors>$(Authors)</Authors>
        <OutputType>Library</OutputType>
        </PropertyGroup>
        </Project>
  • Update the Authors Entries?

    Never seen those Names recently and @andrerav mentioned in the discussion, he is the only Maintainer except from @DocSvartz and @stagep (potentially missed one 😄 but you get what I mean hopefully) which I did not see in one of those Lists.

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS

use Directory.Packages.props -> introduce CPM

This already exists.
But there are a number of problems with this:

  1. It just doesn't seem to work due to some properties being overridden in the projects themselves.
  2. If auto-generation is used (benchmark projects), such projects may not build, at least in IDE. Because projects require a signature.

IsTestProject

I've seen issue in NUnit that in certain CI/CD pipelines, tests don't run without it. But tests work for us. Now I'm wondering if the tests will run twice.
@DevTKSS Have you seen any problems associated with this?🤔😅

@DocSvartz
DocSvartzforce-pushed the 10-pre branch 2 times, most recently from 426fcdd to 538f8c9CompareDecember 28, 2025 03:02
@DocSvartz

DocSvartz commented Dec 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS
It's strange that after adding <IsTestProject>true</IsTestProject>, the tests passed, but the build failed.
Try add the Suggested again, but only to one file.

-- Update
Suggested not build
Perhaps some protection against third-party commits is configured in PR 🤔
If I add it myself, the build passes.

Co-authored-by: DevTKSS <info@technische-konstruktion.com>
@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz I did only run tests locally so far and not had to work with signing 🤔 and I am using xUnit v3 for testing which has support for many CI CD testing setups with predelivered worflows/samples

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS If this is important, please move these to separate issues:

This is not entirely related to the version number change and the addition of a new TFM. Moreover, this issues can be resolved independently.

@DocSvartz
DocSvartz removed the request for review from andreravDecember 31, 2025 05:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DocSvartz@DevTKSS@stagep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Updated version numbers to 10.0.0-pre01. + net 10 - #841

Merged
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre
Dec 31, 2025
Merged

Updated version numbers to 10.0.0-pre01. + net 10#841
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre

Conversation

@DocSvartz

Copy link
Copy Markdown
Contributor

No description provided.

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS If #622 is relevant?
First step, need to retarget mapster.core and mapster.sourceGenerator to netstandard2.0 and do not change the TFM for these solutions.

@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz added comment on the issue.

Side Note for you: if you link to an issue or PR or similar, did you know that when your current line is a list (-) github will not just link it like you see it now, then show it with:

  • Status of the linked item (open/closed)
  • Title of the issue

I myself favorite to use this, since I get to know this. Perfectly suitable for e.g. "EPIC" Issue lists that are meant to collect multiple issues as links with status on one place. For example:

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS It was more of a short explanation of why two files had different changes than the others and that this is not a misprint. :)

@DocSvartz

DocSvartz commented Dec 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS
Regarding features, this is already a release, I don't plan to add anything.

The only thing I'm thinking about is moving the temporary configuration work into a separate project Mapster.Experemental Mapster.Experimental:

It will be able to accept new features as candidates for the main Mapster project. Let me know if this is a good idea. :)

In relation to:

I wanted to combine the work on these two projects (both would involve changes to the API configuration).
But so far, it's not working out very well.
It will likely be two steps with two API configuration changes. 😒

@stagep

Copy link
Copy Markdown

@docs FYI Experimental is the correct spelling :)

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@stagep yes.
I decided to brush up on how Mapster works again. And it seems I've gone crazy again.🤣 🤪

Comment threadsrc/Mapster.Immutable.Tests/Mapster.Immutable.Tests.csproj Outdated
Comment threadsrc/Mapster.Async.Tests/Mapster.Async.Tests.csproj Outdated
<Version>9.0.0-pre01</Version>
<Version>10.0.0-pre01</Version>
<PackageLicenseUrl>https://github.com/chaowlert/ExpressionDebugger/blob/master/LICENSE</PackageLicenseUrl>
<LangVersion>8.0</LangVersion>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DocSvartz@andrerav Is there a specific reason to use a LangVersion in here?

Comment threadsrc/Mapster.EFCore.Tests/Mapster.EFCore.Tests.csproj Outdated
Comment threadsrc/Mapster.JsonNet/Mapster.JsonNet.csproj
Comment threadsrc/Mapster.Tool.Tests/Mapster.Tool.Tests.csproj Outdated
Comment threadsrc/TemplateTest/TemplateTest.csproj Outdated
@DevTKSS

DevTKSS commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

@DocSvartz@andrerav Seeing all the repeating of Properties here I would like to suggest to:

  • use Directory.Packages.props -> introduce CPM

    • only one place we need to update
    • Configurable along with the Variables of Directory.Build.props if you want to ensure to use specific versions of packages for projects like Source Generators or Test Projects (which by the way are missing the common IsTestProject Tag, which I added as suggestion to this PR directly)
  • use Directory.Build.props

    • Define NuGet Package Information Centrally - e.g. I found this here and copied it to my own Repo + adjusted the Properties (Name, License etc.) I dont use it by now, so adding some other references:

    • source regular Project Props we need repentantly using Variables for example:

      • Directory.Build.props

        <Project>
        <PropertyGroup>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
        <DefaultTargetFrameworks>net10.0;net9.0;net8.0</DefaultTargetFrameworks>
        <Authors>Some Name;Some OtherName</Authors>
        </PropertyGroup>
        </Project>
      • Regular *.csproj

        <ProjectSdk="Microsoft.NET.Sdk">
        <PropertyGroup>
        <TargetFrameworks>$(DefaultTargetFrameworks)</TargetFrameworks>
        <RootNamespace>Mapster</RootNamespace>
        <AssemblyName>Mapster</AssemblyName>
        <Authors>$(Authors)</Authors>
        <OutputType>Library</OutputType>
        </PropertyGroup>
        </Project>
  • Update the Authors Entries?

    Never seen those Names recently and @andrerav mentioned in the discussion, he is the only Maintainer except from @DocSvartz and @stagep (potentially missed one 😄 but you get what I mean hopefully) which I did not see in one of those Lists.

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS

use Directory.Packages.props -> introduce CPM

This already exists.
But there are a number of problems with this:

  1. It just doesn't seem to work due to some properties being overridden in the projects themselves.
  2. If auto-generation is used (benchmark projects), such projects may not build, at least in IDE. Because projects require a signature.

IsTestProject

I've seen issue in NUnit that in certain CI/CD pipelines, tests don't run without it. But tests work for us. Now I'm wondering if the tests will run twice.
@DevTKSS Have you seen any problems associated with this?🤔😅

@DocSvartz
DocSvartzforce-pushed the 10-pre branch 2 times, most recently from 426fcdd to 538f8c9CompareDecember 28, 2025 03:02
@DocSvartz

DocSvartz commented Dec 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS
It's strange that after adding <IsTestProject>true</IsTestProject>, the tests passed, but the build failed.
Try add the Suggested again, but only to one file.

-- Update
Suggested not build
Perhaps some protection against third-party commits is configured in PR 🤔
If I add it myself, the build passes.

Co-authored-by: DevTKSS <info@technische-konstruktion.com>
@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz I did only run tests locally so far and not had to work with signing 🤔 and I am using xUnit v3 for testing which has support for many CI CD testing setups with predelivered worflows/samples

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS If this is important, please move these to separate issues:

This is not entirely related to the version number change and the addition of a new TFM. Moreover, this issues can be resolved independently.

@DocSvartz
DocSvartz removed the request for review from andreravDecember 31, 2025 05:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DocSvartz@DevTKSS@stagep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Updated version numbers to 10.0.0-pre01. + net 10 - #841

Merged
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre
Dec 31, 2025
Merged

Updated version numbers to 10.0.0-pre01. + net 10#841
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre

Conversation

@DocSvartz

Copy link
Copy Markdown
Contributor

No description provided.

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS If #622 is relevant?
First step, need to retarget mapster.core and mapster.sourceGenerator to netstandard2.0 and do not change the TFM for these solutions.

@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz added comment on the issue.

Side Note for you: if you link to an issue or PR or similar, did you know that when your current line is a list (-) github will not just link it like you see it now, then show it with:

  • Status of the linked item (open/closed)
  • Title of the issue

I myself favorite to use this, since I get to know this. Perfectly suitable for e.g. "EPIC" Issue lists that are meant to collect multiple issues as links with status on one place. For example:

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS It was more of a short explanation of why two files had different changes than the others and that this is not a misprint. :)

@DocSvartz

DocSvartz commented Dec 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS
Regarding features, this is already a release, I don't plan to add anything.

The only thing I'm thinking about is moving the temporary configuration work into a separate project Mapster.Experemental Mapster.Experimental:

It will be able to accept new features as candidates for the main Mapster project. Let me know if this is a good idea. :)

In relation to:

I wanted to combine the work on these two projects (both would involve changes to the API configuration).
But so far, it's not working out very well.
It will likely be two steps with two API configuration changes. 😒

@stagep

Copy link
Copy Markdown

@docs FYI Experimental is the correct spelling :)

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@stagep yes.
I decided to brush up on how Mapster works again. And it seems I've gone crazy again.🤣 🤪

Comment threadsrc/Mapster.Immutable.Tests/Mapster.Immutable.Tests.csproj Outdated
Comment threadsrc/Mapster.Async.Tests/Mapster.Async.Tests.csproj Outdated
<Version>9.0.0-pre01</Version>
<Version>10.0.0-pre01</Version>
<PackageLicenseUrl>https://github.com/chaowlert/ExpressionDebugger/blob/master/LICENSE</PackageLicenseUrl>
<LangVersion>8.0</LangVersion>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DocSvartz@andrerav Is there a specific reason to use a LangVersion in here?

Comment threadsrc/Mapster.EFCore.Tests/Mapster.EFCore.Tests.csproj Outdated
Comment threadsrc/Mapster.JsonNet/Mapster.JsonNet.csproj
Comment threadsrc/Mapster.Tool.Tests/Mapster.Tool.Tests.csproj Outdated
Comment threadsrc/TemplateTest/TemplateTest.csproj Outdated
@DevTKSS

DevTKSS commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

@DocSvartz@andrerav Seeing all the repeating of Properties here I would like to suggest to:

  • use Directory.Packages.props -> introduce CPM

    • only one place we need to update
    • Configurable along with the Variables of Directory.Build.props if you want to ensure to use specific versions of packages for projects like Source Generators or Test Projects (which by the way are missing the common IsTestProject Tag, which I added as suggestion to this PR directly)
  • use Directory.Build.props

    • Define NuGet Package Information Centrally - e.g. I found this here and copied it to my own Repo + adjusted the Properties (Name, License etc.) I dont use it by now, so adding some other references:

    • source regular Project Props we need repentantly using Variables for example:

      • Directory.Build.props

        <Project>
        <PropertyGroup>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
        <DefaultTargetFrameworks>net10.0;net9.0;net8.0</DefaultTargetFrameworks>
        <Authors>Some Name;Some OtherName</Authors>
        </PropertyGroup>
        </Project>
      • Regular *.csproj

        <ProjectSdk="Microsoft.NET.Sdk">
        <PropertyGroup>
        <TargetFrameworks>$(DefaultTargetFrameworks)</TargetFrameworks>
        <RootNamespace>Mapster</RootNamespace>
        <AssemblyName>Mapster</AssemblyName>
        <Authors>$(Authors)</Authors>
        <OutputType>Library</OutputType>
        </PropertyGroup>
        </Project>
  • Update the Authors Entries?

    Never seen those Names recently and @andrerav mentioned in the discussion, he is the only Maintainer except from @DocSvartz and @stagep (potentially missed one 😄 but you get what I mean hopefully) which I did not see in one of those Lists.

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS

use Directory.Packages.props -> introduce CPM

This already exists.
But there are a number of problems with this:

  1. It just doesn't seem to work due to some properties being overridden in the projects themselves.
  2. If auto-generation is used (benchmark projects), such projects may not build, at least in IDE. Because projects require a signature.

IsTestProject

I've seen issue in NUnit that in certain CI/CD pipelines, tests don't run without it. But tests work for us. Now I'm wondering if the tests will run twice.
@DevTKSS Have you seen any problems associated with this?🤔😅

@DocSvartz
DocSvartzforce-pushed the 10-pre branch 2 times, most recently from 426fcdd to 538f8c9CompareDecember 28, 2025 03:02
@DocSvartz

DocSvartz commented Dec 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS
It's strange that after adding <IsTestProject>true</IsTestProject>, the tests passed, but the build failed.
Try add the Suggested again, but only to one file.

-- Update
Suggested not build
Perhaps some protection against third-party commits is configured in PR 🤔
If I add it myself, the build passes.

Co-authored-by: DevTKSS <info@technische-konstruktion.com>
@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz I did only run tests locally so far and not had to work with signing 🤔 and I am using xUnit v3 for testing which has support for many CI CD testing setups with predelivered worflows/samples

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS If this is important, please move these to separate issues:

This is not entirely related to the version number change and the addition of a new TFM. Moreover, this issues can be resolved independently.

@DocSvartz
DocSvartz removed the request for review from andreravDecember 31, 2025 05:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DocSvartz@DevTKSS@stagep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Updated version numbers to 10.0.0-pre01. + net 10 - #841

Merged
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre
Dec 31, 2025
Merged

Updated version numbers to 10.0.0-pre01. + net 10#841
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre

Conversation

@DocSvartz

Copy link
Copy Markdown
Contributor

No description provided.

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS If #622 is relevant?
First step, need to retarget mapster.core and mapster.sourceGenerator to netstandard2.0 and do not change the TFM for these solutions.

@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz added comment on the issue.

Side Note for you: if you link to an issue or PR or similar, did you know that when your current line is a list (-) github will not just link it like you see it now, then show it with:

  • Status of the linked item (open/closed)
  • Title of the issue

I myself favorite to use this, since I get to know this. Perfectly suitable for e.g. "EPIC" Issue lists that are meant to collect multiple issues as links with status on one place. For example:

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS It was more of a short explanation of why two files had different changes than the others and that this is not a misprint. :)

@DocSvartz

DocSvartz commented Dec 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS
Regarding features, this is already a release, I don't plan to add anything.

The only thing I'm thinking about is moving the temporary configuration work into a separate project Mapster.Experemental Mapster.Experimental:

It will be able to accept new features as candidates for the main Mapster project. Let me know if this is a good idea. :)

In relation to:

I wanted to combine the work on these two projects (both would involve changes to the API configuration).
But so far, it's not working out very well.
It will likely be two steps with two API configuration changes. 😒

@stagep

Copy link
Copy Markdown

@docs FYI Experimental is the correct spelling :)

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@stagep yes.
I decided to brush up on how Mapster works again. And it seems I've gone crazy again.🤣 🤪

Comment threadsrc/Mapster.Immutable.Tests/Mapster.Immutable.Tests.csproj Outdated
Comment threadsrc/Mapster.Async.Tests/Mapster.Async.Tests.csproj Outdated
<Version>9.0.0-pre01</Version>
<Version>10.0.0-pre01</Version>
<PackageLicenseUrl>https://github.com/chaowlert/ExpressionDebugger/blob/master/LICENSE</PackageLicenseUrl>
<LangVersion>8.0</LangVersion>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DocSvartz@andrerav Is there a specific reason to use a LangVersion in here?

Comment threadsrc/Mapster.EFCore.Tests/Mapster.EFCore.Tests.csproj Outdated
Comment threadsrc/Mapster.JsonNet/Mapster.JsonNet.csproj
Comment threadsrc/Mapster.Tool.Tests/Mapster.Tool.Tests.csproj Outdated
Comment threadsrc/TemplateTest/TemplateTest.csproj Outdated
@DevTKSS

DevTKSS commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

@DocSvartz@andrerav Seeing all the repeating of Properties here I would like to suggest to:

  • use Directory.Packages.props -> introduce CPM

    • only one place we need to update
    • Configurable along with the Variables of Directory.Build.props if you want to ensure to use specific versions of packages for projects like Source Generators or Test Projects (which by the way are missing the common IsTestProject Tag, which I added as suggestion to this PR directly)
  • use Directory.Build.props

    • Define NuGet Package Information Centrally - e.g. I found this here and copied it to my own Repo + adjusted the Properties (Name, License etc.) I dont use it by now, so adding some other references:

    • source regular Project Props we need repentantly using Variables for example:

      • Directory.Build.props

        <Project>
        <PropertyGroup>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
        <DefaultTargetFrameworks>net10.0;net9.0;net8.0</DefaultTargetFrameworks>
        <Authors>Some Name;Some OtherName</Authors>
        </PropertyGroup>
        </Project>
      • Regular *.csproj

        <ProjectSdk="Microsoft.NET.Sdk">
        <PropertyGroup>
        <TargetFrameworks>$(DefaultTargetFrameworks)</TargetFrameworks>
        <RootNamespace>Mapster</RootNamespace>
        <AssemblyName>Mapster</AssemblyName>
        <Authors>$(Authors)</Authors>
        <OutputType>Library</OutputType>
        </PropertyGroup>
        </Project>
  • Update the Authors Entries?

    Never seen those Names recently and @andrerav mentioned in the discussion, he is the only Maintainer except from @DocSvartz and @stagep (potentially missed one 😄 but you get what I mean hopefully) which I did not see in one of those Lists.

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS

use Directory.Packages.props -> introduce CPM

This already exists.
But there are a number of problems with this:

  1. It just doesn't seem to work due to some properties being overridden in the projects themselves.
  2. If auto-generation is used (benchmark projects), such projects may not build, at least in IDE. Because projects require a signature.

IsTestProject

I've seen issue in NUnit that in certain CI/CD pipelines, tests don't run without it. But tests work for us. Now I'm wondering if the tests will run twice.
@DevTKSS Have you seen any problems associated with this?🤔😅

@DocSvartz
DocSvartzforce-pushed the 10-pre branch 2 times, most recently from 426fcdd to 538f8c9CompareDecember 28, 2025 03:02
@DocSvartz

DocSvartz commented Dec 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS
It's strange that after adding <IsTestProject>true</IsTestProject>, the tests passed, but the build failed.
Try add the Suggested again, but only to one file.

-- Update
Suggested not build
Perhaps some protection against third-party commits is configured in PR 🤔
If I add it myself, the build passes.

Co-authored-by: DevTKSS <info@technische-konstruktion.com>
@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz I did only run tests locally so far and not had to work with signing 🤔 and I am using xUnit v3 for testing which has support for many CI CD testing setups with predelivered worflows/samples

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS If this is important, please move these to separate issues:

This is not entirely related to the version number change and the addition of a new TFM. Moreover, this issues can be resolved independently.

@DocSvartz
DocSvartz removed the request for review from andreravDecember 31, 2025 05:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DocSvartz@DevTKSS@stagep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Updated version numbers to 10.0.0-pre01. + net 10 - #841

Merged
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre
Dec 31, 2025
Merged

Updated version numbers to 10.0.0-pre01. + net 10#841
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre

Conversation

@DocSvartz

Copy link
Copy Markdown
Contributor

No description provided.

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS If #622 is relevant?
First step, need to retarget mapster.core and mapster.sourceGenerator to netstandard2.0 and do not change the TFM for these solutions.

@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz added comment on the issue.

Side Note for you: if you link to an issue or PR or similar, did you know that when your current line is a list (-) github will not just link it like you see it now, then show it with:

  • Status of the linked item (open/closed)
  • Title of the issue

I myself favorite to use this, since I get to know this. Perfectly suitable for e.g. "EPIC" Issue lists that are meant to collect multiple issues as links with status on one place. For example:

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS It was more of a short explanation of why two files had different changes than the others and that this is not a misprint. :)

@DocSvartz

DocSvartz commented Dec 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS
Regarding features, this is already a release, I don't plan to add anything.

The only thing I'm thinking about is moving the temporary configuration work into a separate project Mapster.Experemental Mapster.Experimental:

It will be able to accept new features as candidates for the main Mapster project. Let me know if this is a good idea. :)

In relation to:

I wanted to combine the work on these two projects (both would involve changes to the API configuration).
But so far, it's not working out very well.
It will likely be two steps with two API configuration changes. 😒

@stagep

Copy link
Copy Markdown

@docs FYI Experimental is the correct spelling :)

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@stagep yes.
I decided to brush up on how Mapster works again. And it seems I've gone crazy again.🤣 🤪

Comment threadsrc/Mapster.Immutable.Tests/Mapster.Immutable.Tests.csproj Outdated
Comment threadsrc/Mapster.Async.Tests/Mapster.Async.Tests.csproj Outdated
<Version>9.0.0-pre01</Version>
<Version>10.0.0-pre01</Version>
<PackageLicenseUrl>https://github.com/chaowlert/ExpressionDebugger/blob/master/LICENSE</PackageLicenseUrl>
<LangVersion>8.0</LangVersion>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DocSvartz@andrerav Is there a specific reason to use a LangVersion in here?

Comment threadsrc/Mapster.EFCore.Tests/Mapster.EFCore.Tests.csproj Outdated
Comment threadsrc/Mapster.JsonNet/Mapster.JsonNet.csproj
Comment threadsrc/Mapster.Tool.Tests/Mapster.Tool.Tests.csproj Outdated
Comment threadsrc/TemplateTest/TemplateTest.csproj Outdated
@DevTKSS

DevTKSS commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

@DocSvartz@andrerav Seeing all the repeating of Properties here I would like to suggest to:

  • use Directory.Packages.props -> introduce CPM

    • only one place we need to update
    • Configurable along with the Variables of Directory.Build.props if you want to ensure to use specific versions of packages for projects like Source Generators or Test Projects (which by the way are missing the common IsTestProject Tag, which I added as suggestion to this PR directly)
  • use Directory.Build.props

    • Define NuGet Package Information Centrally - e.g. I found this here and copied it to my own Repo + adjusted the Properties (Name, License etc.) I dont use it by now, so adding some other references:

    • source regular Project Props we need repentantly using Variables for example:

      • Directory.Build.props

        <Project>
        <PropertyGroup>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
        <DefaultTargetFrameworks>net10.0;net9.0;net8.0</DefaultTargetFrameworks>
        <Authors>Some Name;Some OtherName</Authors>
        </PropertyGroup>
        </Project>
      • Regular *.csproj

        <ProjectSdk="Microsoft.NET.Sdk">
        <PropertyGroup>
        <TargetFrameworks>$(DefaultTargetFrameworks)</TargetFrameworks>
        <RootNamespace>Mapster</RootNamespace>
        <AssemblyName>Mapster</AssemblyName>
        <Authors>$(Authors)</Authors>
        <OutputType>Library</OutputType>
        </PropertyGroup>
        </Project>
  • Update the Authors Entries?

    Never seen those Names recently and @andrerav mentioned in the discussion, he is the only Maintainer except from @DocSvartz and @stagep (potentially missed one 😄 but you get what I mean hopefully) which I did not see in one of those Lists.

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS

use Directory.Packages.props -> introduce CPM

This already exists.
But there are a number of problems with this:

  1. It just doesn't seem to work due to some properties being overridden in the projects themselves.
  2. If auto-generation is used (benchmark projects), such projects may not build, at least in IDE. Because projects require a signature.

IsTestProject

I've seen issue in NUnit that in certain CI/CD pipelines, tests don't run without it. But tests work for us. Now I'm wondering if the tests will run twice.
@DevTKSS Have you seen any problems associated with this?🤔😅

@DocSvartz
DocSvartzforce-pushed the 10-pre branch 2 times, most recently from 426fcdd to 538f8c9CompareDecember 28, 2025 03:02
@DocSvartz

DocSvartz commented Dec 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS
It's strange that after adding <IsTestProject>true</IsTestProject>, the tests passed, but the build failed.
Try add the Suggested again, but only to one file.

-- Update
Suggested not build
Perhaps some protection against third-party commits is configured in PR 🤔
If I add it myself, the build passes.

Co-authored-by: DevTKSS <info@technische-konstruktion.com>
@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz I did only run tests locally so far and not had to work with signing 🤔 and I am using xUnit v3 for testing which has support for many CI CD testing setups with predelivered worflows/samples

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS If this is important, please move these to separate issues:

This is not entirely related to the version number change and the addition of a new TFM. Moreover, this issues can be resolved independently.

@DocSvartz
DocSvartz removed the request for review from andreravDecember 31, 2025 05:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DocSvartz@DevTKSS@stagep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Updated version numbers to 10.0.0-pre01. + net 10 - #841

Merged
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre
Dec 31, 2025
Merged

Updated version numbers to 10.0.0-pre01. + net 10#841
DocSvartz merged 5 commits into
MapsterMapper:developmentfrom
DocSvartz:10-pre

Conversation

@DocSvartz

Copy link
Copy Markdown
Contributor

No description provided.

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS If #622 is relevant?
First step, need to retarget mapster.core and mapster.sourceGenerator to netstandard2.0 and do not change the TFM for these solutions.

@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz added comment on the issue.

Side Note for you: if you link to an issue or PR or similar, did you know that when your current line is a list (-) github will not just link it like you see it now, then show it with:

  • Status of the linked item (open/closed)
  • Title of the issue

I myself favorite to use this, since I get to know this. Perfectly suitable for e.g. "EPIC" Issue lists that are meant to collect multiple issues as links with status on one place. For example:

@DocSvartz

DocSvartz commented Dec 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS It was more of a short explanation of why two files had different changes than the others and that this is not a misprint. :)

@DocSvartz

DocSvartz commented Dec 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@andrerav@stagep@DevTKSS
Regarding features, this is already a release, I don't plan to add anything.

The only thing I'm thinking about is moving the temporary configuration work into a separate project Mapster.Experemental Mapster.Experimental:

It will be able to accept new features as candidates for the main Mapster project. Let me know if this is a good idea. :)

In relation to:

I wanted to combine the work on these two projects (both would involve changes to the API configuration).
But so far, it's not working out very well.
It will likely be two steps with two API configuration changes. 😒

@stagep

Copy link
Copy Markdown

@docs FYI Experimental is the correct spelling :)

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@stagep yes.
I decided to brush up on how Mapster works again. And it seems I've gone crazy again.🤣 🤪

Comment threadsrc/Mapster.Immutable.Tests/Mapster.Immutable.Tests.csproj Outdated
Comment threadsrc/Mapster.Async.Tests/Mapster.Async.Tests.csproj Outdated
<Version>9.0.0-pre01</Version>
<Version>10.0.0-pre01</Version>
<PackageLicenseUrl>https://github.com/chaowlert/ExpressionDebugger/blob/master/LICENSE</PackageLicenseUrl>
<LangVersion>8.0</LangVersion>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DocSvartz@andrerav Is there a specific reason to use a LangVersion in here?

Comment threadsrc/Mapster.EFCore.Tests/Mapster.EFCore.Tests.csproj Outdated
Comment threadsrc/Mapster.JsonNet/Mapster.JsonNet.csproj
Comment threadsrc/Mapster.Tool.Tests/Mapster.Tool.Tests.csproj Outdated
Comment threadsrc/TemplateTest/TemplateTest.csproj Outdated
@DevTKSS

DevTKSS commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

@DocSvartz@andrerav Seeing all the repeating of Properties here I would like to suggest to:

  • use Directory.Packages.props -> introduce CPM

    • only one place we need to update
    • Configurable along with the Variables of Directory.Build.props if you want to ensure to use specific versions of packages for projects like Source Generators or Test Projects (which by the way are missing the common IsTestProject Tag, which I added as suggestion to this PR directly)
  • use Directory.Build.props

    • Define NuGet Package Information Centrally - e.g. I found this here and copied it to my own Repo + adjusted the Properties (Name, License etc.) I dont use it by now, so adding some other references:

    • source regular Project Props we need repentantly using Variables for example:

      • Directory.Build.props

        <Project>
        <PropertyGroup>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
        <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
        <DefaultTargetFrameworks>net10.0;net9.0;net8.0</DefaultTargetFrameworks>
        <Authors>Some Name;Some OtherName</Authors>
        </PropertyGroup>
        </Project>
      • Regular *.csproj

        <ProjectSdk="Microsoft.NET.Sdk">
        <PropertyGroup>
        <TargetFrameworks>$(DefaultTargetFrameworks)</TargetFrameworks>
        <RootNamespace>Mapster</RootNamespace>
        <AssemblyName>Mapster</AssemblyName>
        <Authors>$(Authors)</Authors>
        <OutputType>Library</OutputType>
        </PropertyGroup>
        </Project>
  • Update the Authors Entries?

    Never seen those Names recently and @andrerav mentioned in the discussion, he is the only Maintainer except from @DocSvartz and @stagep (potentially missed one 😄 but you get what I mean hopefully) which I did not see in one of those Lists.

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS

use Directory.Packages.props -> introduce CPM

This already exists.
But there are a number of problems with this:

  1. It just doesn't seem to work due to some properties being overridden in the projects themselves.
  2. If auto-generation is used (benchmark projects), such projects may not build, at least in IDE. Because projects require a signature.

IsTestProject

I've seen issue in NUnit that in certain CI/CD pipelines, tests don't run without it. But tests work for us. Now I'm wondering if the tests will run twice.
@DevTKSS Have you seen any problems associated with this?🤔😅

@DocSvartz
DocSvartzforce-pushed the 10-pre branch 2 times, most recently from 426fcdd to 538f8c9CompareDecember 28, 2025 03:02
@DocSvartz

DocSvartz commented Dec 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS
It's strange that after adding <IsTestProject>true</IsTestProject>, the tests passed, but the build failed.
Try add the Suggested again, but only to one file.

-- Update
Suggested not build
Perhaps some protection against third-party commits is configured in PR 🤔
If I add it myself, the build passes.

Co-authored-by: DevTKSS <info@technische-konstruktion.com>
@DevTKSS

Copy link
Copy Markdown
Collaborator

@DocSvartz I did only run tests locally so far and not had to work with signing 🤔 and I am using xUnit v3 for testing which has support for many CI CD testing setups with predelivered worflows/samples

@DocSvartz

Copy link
Copy Markdown
ContributorAuthor

@DevTKSS If this is important, please move these to separate issues:

This is not entirely related to the version number change and the addition of a new TFM. Moreover, this issues can be resolved independently.

@DocSvartz
DocSvartz removed the request for review from andreravDecember 31, 2025 05:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DocSvartz@DevTKSS@stagep