Uh oh!
There was an error while loading. Please reload this page.
Update markbind-action to enhance existing features - #1
Conversation
ang-zeyu
left a comment
There was a problem hiding this comment.
Nice work, especially on the recipes.
Formatting wise, should we enclose workflow variables with double backticks for clarity? (e.g. 'gh-pages') Not a huge issue though, if the current looks nicer.
Just a few nits otherwise, mostly on the README:
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ang Ze Yu <angzeyu@gmail.com>
ang-zeyu
left a comment
There was a problem hiding this comment.
For PR deployments (via Surge), the deployment will not be automatically deleted. This may be possible but the user will need to create another action to trigger the deletion on PR merge/close following this instruction. I guess I can create that as a reusable workflow and link the usage here so that users can choose to include that additional step if needed.
Sounds good, let's put up an issue for tracking. (if not attempting anytime soon)
Last few nits:
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jonahtanjz
left a comment
There was a problem hiding this comment.
Nice work @tlylt!
Overall it looks good 👍 Just one suggestion :)
Uh oh!
There was an error while loading. Please reload this page.
tlylt
commented
Mar 28, 2022
@ang-zeyu@jonahtanjz Thanks for checking! I think I have updated all the required stuff (let me know if there are any more issues). For the release plan, according to this guide for Action release management, I think the steps will be:
|
jonahtanjz
left a comment
There was a problem hiding this comment.
LGTM 👍
Let's wait for @ang-zeyu to approve as well :)
ang-zeyu
commented
Mar 28, 2022
Lgtm 👍 Thanks for linking the guide as well! |
tlylt
commented
Mar 28, 2022
Seems like there's a regression possibly to some updates that I did in this PR such that the |
tlylt
commented
Mar 29, 2022
Sorry for the delay. I retested the three cases of baseUrl input and they all seem to work now. I think we are good to proceed with
|
jonahtanjz
commented
Mar 29, 2022
@tlylt Do you have write access to do the tagging and release? Might also want to include a short commit message in the PR description :) |
tlylt
commented
Mar 29, 2022
I have added a commit message. I think I may not have the right to do so (I also don't think I can merge this PR). |
ang-zeyu
commented
Mar 29, 2022
@tlylt you should have permissions now : ) |
Details of this PR has been posted & discussed in the main repo here.
Proposed commit message:
Update markbind-action to enhance existing features
The prerelease markbind-action has certain limitations such
as cannot specify the version of MarkBind to build files or
prevent force-pushing when updating the gh-pages branch.
Let's update it to a composite action and expand on the
existing functionalities to make this action more useful.
New configurations have been included to allow for flexibility
and support more use cases.
Using a composite action also makes it easier to maintain and
reuse existing actions.