Uh oh!
There was an error while loading. Please reload this page.
Make highlighting bold - #1045
Merged
Merged
Conversation
damithc
removed their request for review
February 17, 2020 10:03
damithc
commented
Feb 17, 2020
Contributor
I'm OK with the color. |
nbriannl
approved these changes
Feb 18, 2020
nbriannl
left a comment
Contributor
There was a problem hiding this comment.
A simple CSS change. LGTM.
marvinchin
approved these changes
Feb 18, 2020
Tejas2805
commented
Feb 20, 2020
ContributorAuthor
Hi, any update required for this? |
marvinchin
commented
Feb 20, 2020
Contributor
@Tejas2805 no, it should be good 🙂we will be merging it in shortly. |
Tejas2805 added a commit
to Tejas2805/markbind
that referenced
this pull request
Feb 27, 2020
* 'master' of https://github.com/MarkBind/markbind: Update tests Allow using 'none' footer attribute in frontmatter (MarkBind#1002) Support line numbers for code blocks (MarkBind#991) 2.11.0 Update test files due to changes in PR MarkBind#982 Update vue-strap version to v2.0.1-markbind.36 Make highlighting bold (MarkBind#1045) Support markdown for header attr in dropdown (MarkBind#1029) Add '_site' to the ignored folders in site.json (MarkBind#1046) Use path.join instead of string interpolation (MarkBind#1052) Implement box markdown header attributes parsing (MarkBind#1025) Make the position of top navbar fixed (MarkBind#982) Exclude *.md files from being copied over on build (MarkBind#1010) # Conflicts: # docs/css/main.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Enhancement to an existing feature
Fixes#344
What is the rationale for this request?
The current highlight style is too light. Tweak it to make it stronger so that
it becomes more visible
What changes did you make? (Give an overview)
Changed color of highlighted text to #ff0
Provide some example code that this change will affect:
Is there anything you'd like reviewers to focus on?
N.A.
Testing instructions:
Can check this in Netlify preview
Proposed commit message: (wrap lines at 72 characters)