') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update Test for Version 2.11.0 by nbriannl · Pull Request #1055 · MarkBind/markbind · GitHub
Skip to content

Update Test for Version 2.11.0 - #1055

Merged
marvinchin merged 1 commit into
MarkBind:masterfrom
nbriannl:Update-test-2.11
Feb 26, 2020
Merged

Update Test for Version 2.11.0#1055
marvinchin merged 1 commit into
MarkBind:masterfrom
nbriannl:Update-test-2.11

Conversation

@nbriannl

@nbriannlnbriannl commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [ ] Documentation update
• [ ] Bug fix
• [ ] New feature
• [ ] Enhancement to an existing feature
• [X] Other, please explain: Build is failing due to test file not updated.

What is the rationale for this request?
Build is failing. Updating test reveals one file is not updated.

What changes did you make? (Give an overview)
Update file

Proposed commit message: (wrap lines at 72 characters)

Update expected output for test

@nbriannlnbriannl changed the title Update Test for version 2.11.0Update Test for Version 2.11.0Feb 26, 2020
@marvinchinmarvinchin added this to the v2.11.1 milestone Feb 26, 2020
@yamgent

yamgent commented Feb 26, 2020

Copy link
Copy Markdown
Member

Thanks for spotting this. I am leaving it to @marvinchin to merge so that he can test out his new merging powers. :P

On an unrelated note, this probably should be fixed in the long run by mocking the version number, so that we don't have to update the tests every release (this should be done in a separate PR).

@marvinchin
marvinchin merged commit 74a5b0f into MarkBind:masterFeb 26, 2020
@yamgentyamgent added the pr.CodeMaintenance 🛠 DevOps, refactoring, etc label Mar 3, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
@nbriannlMarvin Chin
Update tests (#1055)
6f2707c
@nbriannl
nbriannl deleted the Update-test-2.11 branch April 16, 2020 09:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@openorcloseopenorcloseopenorclose approved these changes
@marvinchinmarvinchinmarvinchin approved these changes
@ang-zeyuang-zeyuAwaiting requested review from ang-zeyu
@yamgentyamgentAwaiting requested review from yamgent

Assignees

No one assigned

Labels

pr.CodeMaintenance 🛠DevOps, refactoring, etc

Projects

None yet

Milestone

v2.12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nbriannl@yamgent@openorclose@marvinchin