Uh oh!
There was an error while loading. Please reload this page.
Add and organise tests for code blocks - #1143
Merged
Merged
Conversation
openorclose
previously requested changes
Apr 2, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nbriannl
marked this pull request as draft
April 29, 2020 05:43
nbriannlforce-pushed
the
make-tests
branch
3 times, most recently
from
April 29, 2020 06:51
87e2af3 to
6a82ddaComparenbriannl
marked this pull request as ready for review
April 29, 2020 08:49
nbriannl
requested review from
alyip98, ang-zeyu, le0tan, marvinchin, openorclose and yash-chowdharyApril 29, 2020 08:49
ang-zeyu
reviewed
May 2, 2020
| @@ -0,0 +1,15 @@ | |||
| **Test: Boxes** | |||
Contributor
There was a problem hiding this comment.
Definitely see the purpose of the code block tests, what does this cover that componentParserTest misses though?
ContributorAuthor
There was a problem hiding this comment.
Ah, does componentParserTest cover the rendering of markdown inside components?
I'll go check later.
ContributorAuthor
There was a problem hiding this comment.
Ah yeah, I found that it covered. My bad 👍
Contributor
There was a problem hiding this comment.
ok, the code blocks tests looks good 👍
ang-zeyu
approved these changes
May 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [ ] Documentation update
• [ ] Bug fix
• [ ] New feature
• [ ] Enhancement to an existing feature
• [X] Other, please explain: Testing
What is the rationale for this request?
Added more tests than will more comprehensively cover the behaviors of components I've worked on. Particular
Boxes andCode Block, since I've done PRs#1034, #1137, MarkBind/vue-strap#129What changes did you make? (Give an overview)
Added test for Boxes, that are related to MarkBind parsing,The test suite cannot cover VueStrap rendering. VueStrap tests are done via Set up jest snapshot testing for vue-strap vue-strap#146Is there anything you'd like reviewers to focus on?
Not sure other than naming of tests and any coverage I've left out.
Testing instructions:
Check and run tests.
Proposed commit message: (wrap lines at 72 characters)
Add and organise tests for code blocks