Uh oh!
There was an error while loading. Please reload this page.
Rebase reference for static includes that target a div - #115
Merged
Conversation
acjhforce-pushed
the
94-rebase-ref-for-static-includes
branch
from
January 18, 2018 03:40
834a11b to
c9a18bbCompareGisonrg
reviewed
Jan 18, 2018
| }; | ||
| Parser.prototype.includeFile = function (file, cb) { | ||
| Parser.prototype.includeFile = function (file, cb, config) { |
Contributor
There was a problem hiding this comment.
I am thinking about deprecating the callback for the API and use Promise only, and I don't think we are still using callback anywhere in the codebase, so I think it's safe to change to put config after the file parameter here (do a check before you do so) :)
Let's create an issue and get rid of callback in a separate PR.
acjhforce-pushed
the
94-rebase-ref-for-static-includes
branch
from
January 19, 2018 02:00
3e0dcfa to
22cab7eCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#94