Skip to content

Parse popovers for footnotes - #1155

Merged
yamgent merged 2 commits into
MarkBind:masterfrom
openorclose:parse_footnote_popovers
Apr 7, 2020
Merged

Parse popovers for footnotes#1155
yamgent merged 2 commits into
MarkBind:masterfrom
openorclose:parse_footnote_popovers

Conversation

@openorclose

@openorcloseopenorclose commented Mar 28, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [x] Bug fix

What is the rationale for this request?

Fixes#1154

What changes did you make? (Give an overview)

Specifically called the componentParser on the popovers in the footnotes plugin

Provide some example code that this change will affect:

**Normal footnotes:**
Here is a footnote reference,[^1] and another.[^longnote]
​
[^1]: Here is the footnote. Footnotes will appear at the bottom of the page.
​
[^longnote]: Here's one with multiple blocks.
​
Subsequent paragraphs are indented to show that they
belong to the previous footnote.
**Inline footnotes:**
Here is an inline note.^[Inlines notes are easier to write, since
you don't have to pick an identifier and move down to type the
note.]

Is there anything you'd like reviewers to focus on?

This is the simple bug fix for now. Long term solution to fix footnotes inside dynamic panels is still in the works.

Testing instructions:

Check that the popovers appear.

Proposed commit message: (wrap lines at 72 characters)

During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.

@openorclose
Parse popovers for footnotes
65a9233
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
@le0tanle0tan added c.Bug 🐛 p.Medium pr.BugFix 🐛 Fixes correct a programming error/assumption and removed c.Bug 🐛 p.Medium labels Mar 29, 2020
nbriannl
nbriannl reviewed Mar 29, 2020
View reviewed changes
Comment threadtest/functional/test_site/expected/index.html Outdated
you don't have to pick an identifier and move down to type the
note.</p>
</div>
</span>

@nbriannlnbriannlMar 29, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the indents are incorrect, but i assume this is what updatetest generated, so can't really argue with this, can I?

@openorcloseopenorcloseApr 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah..

ang-zeyu
ang-zeyu approved these changes Apr 2, 2020
View reviewed changes

@ang-zeyuang-zeyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ang-zeyuang-zeyu added this to the v2.13.2 milestone Apr 2, 2020
@yamgent

yamgent commented Apr 5, 2020

Copy link
Copy Markdown
Member

@openorclose resolve conflicts

@openorclose
Merge remote-tracking branch 'origin/master' into parse_footnote_popo…
07e21c0
…vers
# Conflicts:
#	test/functional/test_site/expected/index.html
@openorclose

openorclose commented Apr 5, 2020

Copy link
Copy Markdown
ContributorAuthor

@openorclose resolve conflicts

Done!

This was referenced Apr 5, 2020
Closed
Merged
@yamgent
yamgent merged commit 9984374 into MarkBind:masterApr 7, 2020
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Apr 9, 2020
@Tejas2805
Merge branch 'master' ofhttps://github.com/MarkBind/markbind
9792d68
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
Document adding new site content in DG (MarkBind#1153)
Add relative date feature (MarkBind#908)
Use <br> to separate lines of code block (MarkBind#1176)
Parse popovers for footnotes (MarkBind#1155)
Resolve comments
Expand test extensions and fix whitespace checks (MarkBind#1156)
Address comments
Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
Normalize inline puml line ending before hashing (MarkBind#1174)
Update tests (MarkBind#1178)
Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
Fix bug in Search for UG and DG (MarkBind#1147)
Add inline puml support (MarkBind#1100)
Fix hrefs for headings with angular brackets (MarkBind#1089)
Update tests for 2.13.1 (MarkBind#1169)
2.13.1
Update vue-strap version to v2.0.1-markbind.39
Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
2.13.0
Update test files
...
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
@openorcloseMarvin Chin
Parse popovers for footnotes (#1155)
fc3f4c3
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbriannlnbriannlnbriannl left review comments
@yamgentyamgentyamgent approved these changes
@ang-zeyuang-zeyuang-zeyu approved these changes

Assignees

No one assigned

Labels

pr.BugFix 🐛Fixes correct a programming error/assumption

Projects

None yet

Milestone

v2.14.0

Development

Successfully merging this pull request may close these issues.

Footnotes don't show popovers

5 participants

@openorclose@yamgent@ang-zeyu@nbriannl@le0tan
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Parse popovers for footnotes by openorclose · Pull Request #1155 · MarkBind/markbind · GitHub
Skip to content
Parse popovers for footnotes - #1155
Merged
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Apr 7, 2020
Merged
Parse popovers for footnotes#1155
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Conversation
@openorclose
@openorcloseopenorclose
commented
Mar 28, 2020

Copy link


Copy Markdown

Contributor
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
Fixes#1154
What changes did you make? (Give an overview)
Specifically called the componentParser on the popovers in the footnotes plugin
Provide some example code that this change will affect:
**Normal footnotes:**
Here is a footnote reference,[^1] and another.[^longnote]
​
[^1]: Here is the footnote. Footnotes will appear at the bottom of the page.
​
[^longnote]: Here's one with multiple blocks.
​
Subsequent paragraphs are indented to show that they
belong to the previous footnote.
**Inline footnotes:**
Here is an inline note.^[Inlines notes are easier to write, since
you don't have to pick an identifier and move down to type the
note.]
Is there anything you'd like reviewers to focus on?
This is the simple bug fix for now. Long term solution to fix footnotes inside dynamic panels is still in the works.
Testing instructions:
Check that the popovers appear.
Proposed commit message: (wrap lines at 72 characters)
During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.

@openorclose
Parse popovers for footnotes
65a9233
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
@le0tanle0tan
added

c.Bug 🐛

p.Medium

pr.BugFix 🐛
Fixes correct a programming error/assumption
and removed

c.Bug 🐛

p.Medium

labels
Mar 29, 2020
nbriannl
nbriannl
reviewed
Mar 29, 2020
View reviewed changes
Comment threadtest/functional/test_site/expected/index.html
Outdated

you don't have to pick an identifier and move down to type the
note.</p>
 </div>
 </span>
@nbriannlnbriannlMar 29, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the indents are incorrect, but i assume this is what updatetest generated, so can't really argue with this, can I?
@openorcloseopenorcloseApr 2, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah..
ang-zeyu
ang-zeyu
approved these changes
Apr 2, 2020
View reviewed changes
@ang-zeyuang-zeyu
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
@ang-zeyuang-zeyu
added this to the v2.13.2 milestone
Apr 2, 2020
@yamgent
yamgent
commented
Apr 5, 2020

Copy link


Copy Markdown

Member
@openorclose resolve conflicts
@openorclose
Merge remote-tracking branch 'origin/master' into parse_footnote_popo…
07e21c0
…vers
# Conflicts:
#	test/functional/test_site/expected/index.html
@openorclose
openorclose
commented
Apr 5, 2020

Copy link


Copy Markdown

ContributorAuthor
@openorclose resolve conflicts
Done!

This was referenced Apr 5, 2020

Closed

 Merged

@yamgent
yamgent
merged commit 9984374
into
MarkBind:masterApr 7, 2020
Tejas2805 added a commit
to Tejas2805/markbind
that referenced
this pull request
Apr 9, 2020
@Tejas2805
Merge branch 'master' ofhttps://github.com/MarkBind/markbind
9792d68
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
Document adding new site content in DG (MarkBind#1153)
Add relative date feature (MarkBind#908)
Use <br> to separate lines of code block (MarkBind#1176)
Parse popovers for footnotes (MarkBind#1155)
Resolve comments
Expand test extensions and fix whitespace checks (MarkBind#1156)
Address comments
Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
Normalize inline puml line ending before hashing (MarkBind#1174)
Update tests (MarkBind#1178)
Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
Fix bug in Search for UG and DG (MarkBind#1147)
Add inline puml support (MarkBind#1100)
Fix hrefs for headings with angular brackets (MarkBind#1089)
Update tests for 2.13.1 (MarkBind#1169)
2.13.1
Update vue-strap version to v2.0.1-markbind.39
Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
2.13.0
Update test files
...
marvinchin pushed a commit
that referenced
this pull request
Apr 10, 2020
@openorcloseMarvin Chin
Parse popovers for footnotes (#1155)
fc3f4c3
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nbriannlnbriannlnbriannl left review comments
@yamgentyamgentyamgent approved these changes
@ang-zeyuang-zeyuang-zeyu approved these changes

Assignees


No one assigned


Labels

pr.BugFix 🐛Fixes correct a programming error/assumption

Projects


None yet


Milestone

v2.14.0

Development

Successfully merging this pull request may close these issues.

Footnotes don't show popovers


5 participants

@openorclose@yamgent@ang-zeyu@nbriannl@le0tan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Parse popovers for footnotes by openorclose · Pull Request #1155 · MarkBind/markbind · GitHub
Skip to content
Parse popovers for footnotes - #1155
Merged
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Apr 7, 2020
Merged
Parse popovers for footnotes#1155
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Conversation
@openorclose
@openorcloseopenorclose
commented
Mar 28, 2020

Copy link


Copy Markdown

Contributor
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
Fixes#1154
What changes did you make? (Give an overview)
Specifically called the componentParser on the popovers in the footnotes plugin
Provide some example code that this change will affect:
**Normal footnotes:**
Here is a footnote reference,[^1] and another.[^longnote]
​
[^1]: Here is the footnote. Footnotes will appear at the bottom of the page.
​
[^longnote]: Here's one with multiple blocks.
​
Subsequent paragraphs are indented to show that they
belong to the previous footnote.
**Inline footnotes:**
Here is an inline note.^[Inlines notes are easier to write, since
you don't have to pick an identifier and move down to type the
note.]
Is there anything you'd like reviewers to focus on?
This is the simple bug fix for now. Long term solution to fix footnotes inside dynamic panels is still in the works.
Testing instructions:
Check that the popovers appear.
Proposed commit message: (wrap lines at 72 characters)
During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.

@openorclose
Parse popovers for footnotes
65a9233
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
@le0tanle0tan
added

c.Bug 🐛

p.Medium

pr.BugFix 🐛
Fixes correct a programming error/assumption
and removed

c.Bug 🐛

p.Medium

labels
Mar 29, 2020
nbriannl
nbriannl
reviewed
Mar 29, 2020
View reviewed changes
Comment threadtest/functional/test_site/expected/index.html
Outdated

you don't have to pick an identifier and move down to type the
note.</p>
 </div>
 </span>
@nbriannlnbriannlMar 29, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the indents are incorrect, but i assume this is what updatetest generated, so can't really argue with this, can I?
@openorcloseopenorcloseApr 2, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah..
ang-zeyu
ang-zeyu
approved these changes
Apr 2, 2020
View reviewed changes
@ang-zeyuang-zeyu
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
@ang-zeyuang-zeyu
added this to the v2.13.2 milestone
Apr 2, 2020
@yamgent
yamgent
commented
Apr 5, 2020

Copy link


Copy Markdown

Member
@openorclose resolve conflicts
@openorclose
Merge remote-tracking branch 'origin/master' into parse_footnote_popo…
07e21c0
…vers
# Conflicts:
#	test/functional/test_site/expected/index.html
@openorclose
openorclose
commented
Apr 5, 2020

Copy link


Copy Markdown

ContributorAuthor
@openorclose resolve conflicts
Done!

This was referenced Apr 5, 2020

Closed

 Merged

@yamgent
yamgent
merged commit 9984374
into
MarkBind:masterApr 7, 2020
Tejas2805 added a commit
to Tejas2805/markbind
that referenced
this pull request
Apr 9, 2020
@Tejas2805
Merge branch 'master' ofhttps://github.com/MarkBind/markbind
9792d68
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
Document adding new site content in DG (MarkBind#1153)
Add relative date feature (MarkBind#908)
Use <br> to separate lines of code block (MarkBind#1176)
Parse popovers for footnotes (MarkBind#1155)
Resolve comments
Expand test extensions and fix whitespace checks (MarkBind#1156)
Address comments
Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
Normalize inline puml line ending before hashing (MarkBind#1174)
Update tests (MarkBind#1178)
Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
Fix bug in Search for UG and DG (MarkBind#1147)
Add inline puml support (MarkBind#1100)
Fix hrefs for headings with angular brackets (MarkBind#1089)
Update tests for 2.13.1 (MarkBind#1169)
2.13.1
Update vue-strap version to v2.0.1-markbind.39
Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
2.13.0
Update test files
...
marvinchin pushed a commit
that referenced
this pull request
Apr 10, 2020
@openorcloseMarvin Chin
Parse popovers for footnotes (#1155)
fc3f4c3
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nbriannlnbriannlnbriannl left review comments
@yamgentyamgentyamgent approved these changes
@ang-zeyuang-zeyuang-zeyu approved these changes

Assignees


No one assigned


Labels

pr.BugFix 🐛Fixes correct a programming error/assumption

Projects


None yet


Milestone

v2.14.0

Development

Successfully merging this pull request may close these issues.

Footnotes don't show popovers


5 participants

@openorclose@yamgent@ang-zeyu@nbriannl@le0tan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Parse popovers for footnotes by openorclose · Pull Request #1155 · MarkBind/markbind · GitHub
Skip to content
Parse popovers for footnotes - #1155
Merged
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Apr 7, 2020
Merged
Parse popovers for footnotes#1155
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Conversation
@openorclose
@openorcloseopenorclose
commented
Mar 28, 2020

Copy link


Copy Markdown

Contributor
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
Fixes#1154
What changes did you make? (Give an overview)
Specifically called the componentParser on the popovers in the footnotes plugin
Provide some example code that this change will affect:
**Normal footnotes:**
Here is a footnote reference,[^1] and another.[^longnote]
​
[^1]: Here is the footnote. Footnotes will appear at the bottom of the page.
​
[^longnote]: Here's one with multiple blocks.
​
Subsequent paragraphs are indented to show that they
belong to the previous footnote.
**Inline footnotes:**
Here is an inline note.^[Inlines notes are easier to write, since
you don't have to pick an identifier and move down to type the
note.]
Is there anything you'd like reviewers to focus on?
This is the simple bug fix for now. Long term solution to fix footnotes inside dynamic panels is still in the works.
Testing instructions:
Check that the popovers appear.
Proposed commit message: (wrap lines at 72 characters)
During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.

@openorclose
Parse popovers for footnotes
65a9233
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
@le0tanle0tan
added

c.Bug 🐛

p.Medium

pr.BugFix 🐛
Fixes correct a programming error/assumption
and removed

c.Bug 🐛

p.Medium

labels
Mar 29, 2020
nbriannl
nbriannl
reviewed
Mar 29, 2020
View reviewed changes
Comment threadtest/functional/test_site/expected/index.html
Outdated

you don't have to pick an identifier and move down to type the
note.</p>
 </div>
 </span>
@nbriannlnbriannlMar 29, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the indents are incorrect, but i assume this is what updatetest generated, so can't really argue with this, can I?
@openorcloseopenorcloseApr 2, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah..
ang-zeyu
ang-zeyu
approved these changes
Apr 2, 2020
View reviewed changes
@ang-zeyuang-zeyu
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
@ang-zeyuang-zeyu
added this to the v2.13.2 milestone
Apr 2, 2020
@yamgent
yamgent
commented
Apr 5, 2020

Copy link


Copy Markdown

Member
@openorclose resolve conflicts
@openorclose
Merge remote-tracking branch 'origin/master' into parse_footnote_popo…
07e21c0
…vers
# Conflicts:
#	test/functional/test_site/expected/index.html
@openorclose
openorclose
commented
Apr 5, 2020

Copy link


Copy Markdown

ContributorAuthor
@openorclose resolve conflicts
Done!

This was referenced Apr 5, 2020

Closed

 Merged

@yamgent
yamgent
merged commit 9984374
into
MarkBind:masterApr 7, 2020
Tejas2805 added a commit
to Tejas2805/markbind
that referenced
this pull request
Apr 9, 2020
@Tejas2805
Merge branch 'master' ofhttps://github.com/MarkBind/markbind
9792d68
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
Document adding new site content in DG (MarkBind#1153)
Add relative date feature (MarkBind#908)
Use <br> to separate lines of code block (MarkBind#1176)
Parse popovers for footnotes (MarkBind#1155)
Resolve comments
Expand test extensions and fix whitespace checks (MarkBind#1156)
Address comments
Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
Normalize inline puml line ending before hashing (MarkBind#1174)
Update tests (MarkBind#1178)
Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
Fix bug in Search for UG and DG (MarkBind#1147)
Add inline puml support (MarkBind#1100)
Fix hrefs for headings with angular brackets (MarkBind#1089)
Update tests for 2.13.1 (MarkBind#1169)
2.13.1
Update vue-strap version to v2.0.1-markbind.39
Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
2.13.0
Update test files
...
marvinchin pushed a commit
that referenced
this pull request
Apr 10, 2020
@openorcloseMarvin Chin
Parse popovers for footnotes (#1155)
fc3f4c3
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nbriannlnbriannlnbriannl left review comments
@yamgentyamgentyamgent approved these changes
@ang-zeyuang-zeyuang-zeyu approved these changes

Assignees


No one assigned


Labels

pr.BugFix 🐛Fixes correct a programming error/assumption

Projects


None yet


Milestone

v2.14.0

Development

Successfully merging this pull request may close these issues.

Footnotes don't show popovers


5 participants

@openorclose@yamgent@ang-zeyu@nbriannl@le0tan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Parse popovers for footnotes by openorclose · Pull Request #1155 · MarkBind/markbind · GitHub
Skip to content
Parse popovers for footnotes - #1155
Merged
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Apr 7, 2020
Merged
Parse popovers for footnotes#1155
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Conversation
@openorclose
@openorcloseopenorclose
commented
Mar 28, 2020

Copy link


Copy Markdown

Contributor
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
Fixes#1154
What changes did you make? (Give an overview)
Specifically called the componentParser on the popovers in the footnotes plugin
Provide some example code that this change will affect:
**Normal footnotes:**
Here is a footnote reference,[^1] and another.[^longnote]
​
[^1]: Here is the footnote. Footnotes will appear at the bottom of the page.
​
[^longnote]: Here's one with multiple blocks.
​
Subsequent paragraphs are indented to show that they
belong to the previous footnote.
**Inline footnotes:**
Here is an inline note.^[Inlines notes are easier to write, since
you don't have to pick an identifier and move down to type the
note.]
Is there anything you'd like reviewers to focus on?
This is the simple bug fix for now. Long term solution to fix footnotes inside dynamic panels is still in the works.
Testing instructions:
Check that the popovers appear.
Proposed commit message: (wrap lines at 72 characters)
During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.

@openorclose
Parse popovers for footnotes
65a9233
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
@le0tanle0tan
added

c.Bug 🐛

p.Medium

pr.BugFix 🐛
Fixes correct a programming error/assumption
and removed

c.Bug 🐛

p.Medium

labels
Mar 29, 2020
nbriannl
nbriannl
reviewed
Mar 29, 2020
View reviewed changes
Comment threadtest/functional/test_site/expected/index.html
Outdated

you don't have to pick an identifier and move down to type the
note.</p>
 </div>
 </span>
@nbriannlnbriannlMar 29, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the indents are incorrect, but i assume this is what updatetest generated, so can't really argue with this, can I?
@openorcloseopenorcloseApr 2, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah..
ang-zeyu
ang-zeyu
approved these changes
Apr 2, 2020
View reviewed changes
@ang-zeyuang-zeyu
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
@ang-zeyuang-zeyu
added this to the v2.13.2 milestone
Apr 2, 2020
@yamgent
yamgent
commented
Apr 5, 2020

Copy link


Copy Markdown

Member
@openorclose resolve conflicts
@openorclose
Merge remote-tracking branch 'origin/master' into parse_footnote_popo…
07e21c0
…vers
# Conflicts:
#	test/functional/test_site/expected/index.html
@openorclose
openorclose
commented
Apr 5, 2020

Copy link


Copy Markdown

ContributorAuthor
@openorclose resolve conflicts
Done!

This was referenced Apr 5, 2020

Closed

 Merged

@yamgent
yamgent
merged commit 9984374
into
MarkBind:masterApr 7, 2020
Tejas2805 added a commit
to Tejas2805/markbind
that referenced
this pull request
Apr 9, 2020
@Tejas2805
Merge branch 'master' ofhttps://github.com/MarkBind/markbind
9792d68
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
Document adding new site content in DG (MarkBind#1153)
Add relative date feature (MarkBind#908)
Use <br> to separate lines of code block (MarkBind#1176)
Parse popovers for footnotes (MarkBind#1155)
Resolve comments
Expand test extensions and fix whitespace checks (MarkBind#1156)
Address comments
Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
Normalize inline puml line ending before hashing (MarkBind#1174)
Update tests (MarkBind#1178)
Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
Fix bug in Search for UG and DG (MarkBind#1147)
Add inline puml support (MarkBind#1100)
Fix hrefs for headings with angular brackets (MarkBind#1089)
Update tests for 2.13.1 (MarkBind#1169)
2.13.1
Update vue-strap version to v2.0.1-markbind.39
Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
2.13.0
Update test files
...
marvinchin pushed a commit
that referenced
this pull request
Apr 10, 2020
@openorcloseMarvin Chin
Parse popovers for footnotes (#1155)
fc3f4c3
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nbriannlnbriannlnbriannl left review comments
@yamgentyamgentyamgent approved these changes
@ang-zeyuang-zeyuang-zeyu approved these changes

Assignees


No one assigned


Labels

pr.BugFix 🐛Fixes correct a programming error/assumption

Projects


None yet


Milestone

v2.14.0

Development

Successfully merging this pull request may close these issues.

Footnotes don't show popovers


5 participants

@openorclose@yamgent@ang-zeyu@nbriannl@le0tan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Parse popovers for footnotes by openorclose · Pull Request #1155 · MarkBind/markbind · GitHub
Skip to content
Parse popovers for footnotes - #1155
Merged
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Apr 7, 2020
Merged
Parse popovers for footnotes#1155
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Conversation
@openorclose
@openorcloseopenorclose
commented
Mar 28, 2020

Copy link


Copy Markdown

Contributor
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
Fixes#1154
What changes did you make? (Give an overview)
Specifically called the componentParser on the popovers in the footnotes plugin
Provide some example code that this change will affect:
**Normal footnotes:**
Here is a footnote reference,[^1] and another.[^longnote]
​
[^1]: Here is the footnote. Footnotes will appear at the bottom of the page.
​
[^longnote]: Here's one with multiple blocks.
​
Subsequent paragraphs are indented to show that they
belong to the previous footnote.
**Inline footnotes:**
Here is an inline note.^[Inlines notes are easier to write, since
you don't have to pick an identifier and move down to type the
note.]
Is there anything you'd like reviewers to focus on?
This is the simple bug fix for now. Long term solution to fix footnotes inside dynamic panels is still in the works.
Testing instructions:
Check that the popovers appear.
Proposed commit message: (wrap lines at 72 characters)
During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.

@openorclose
Parse popovers for footnotes
65a9233
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
@le0tanle0tan
added

c.Bug 🐛

p.Medium

pr.BugFix 🐛
Fixes correct a programming error/assumption
and removed

c.Bug 🐛

p.Medium

labels
Mar 29, 2020
nbriannl
nbriannl
reviewed
Mar 29, 2020
View reviewed changes
Comment threadtest/functional/test_site/expected/index.html
Outdated

you don't have to pick an identifier and move down to type the
note.</p>
 </div>
 </span>
@nbriannlnbriannlMar 29, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the indents are incorrect, but i assume this is what updatetest generated, so can't really argue with this, can I?
@openorcloseopenorcloseApr 2, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah..
ang-zeyu
ang-zeyu
approved these changes
Apr 2, 2020
View reviewed changes
@ang-zeyuang-zeyu
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
@ang-zeyuang-zeyu
added this to the v2.13.2 milestone
Apr 2, 2020
@yamgent
yamgent
commented
Apr 5, 2020

Copy link


Copy Markdown

Member
@openorclose resolve conflicts
@openorclose
Merge remote-tracking branch 'origin/master' into parse_footnote_popo…
07e21c0
…vers
# Conflicts:
#	test/functional/test_site/expected/index.html
@openorclose
openorclose
commented
Apr 5, 2020

Copy link


Copy Markdown

ContributorAuthor
@openorclose resolve conflicts
Done!

This was referenced Apr 5, 2020

Closed

 Merged

@yamgent
yamgent
merged commit 9984374
into
MarkBind:masterApr 7, 2020
Tejas2805 added a commit
to Tejas2805/markbind
that referenced
this pull request
Apr 9, 2020
@Tejas2805
Merge branch 'master' ofhttps://github.com/MarkBind/markbind
9792d68
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
Document adding new site content in DG (MarkBind#1153)
Add relative date feature (MarkBind#908)
Use <br> to separate lines of code block (MarkBind#1176)
Parse popovers for footnotes (MarkBind#1155)
Resolve comments
Expand test extensions and fix whitespace checks (MarkBind#1156)
Address comments
Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
Normalize inline puml line ending before hashing (MarkBind#1174)
Update tests (MarkBind#1178)
Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
Fix bug in Search for UG and DG (MarkBind#1147)
Add inline puml support (MarkBind#1100)
Fix hrefs for headings with angular brackets (MarkBind#1089)
Update tests for 2.13.1 (MarkBind#1169)
2.13.1
Update vue-strap version to v2.0.1-markbind.39
Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
2.13.0
Update test files
...
marvinchin pushed a commit
that referenced
this pull request
Apr 10, 2020
@openorcloseMarvin Chin
Parse popovers for footnotes (#1155)
fc3f4c3
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nbriannlnbriannlnbriannl left review comments
@yamgentyamgentyamgent approved these changes
@ang-zeyuang-zeyuang-zeyu approved these changes

Assignees


No one assigned


Labels

pr.BugFix 🐛Fixes correct a programming error/assumption

Projects


None yet


Milestone

v2.14.0

Development

Successfully merging this pull request may close these issues.

Footnotes don't show popovers


5 participants

@openorclose@yamgent@ang-zeyu@nbriannl@le0tan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Parse popovers for footnotes by openorclose · Pull Request #1155 · MarkBind/markbind · GitHub
Skip to content
Parse popovers for footnotes - #1155
Merged
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Apr 7, 2020
Merged
Parse popovers for footnotes#1155
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Conversation
@openorclose
@openorcloseopenorclose
commented
Mar 28, 2020

Copy link


Copy Markdown

Contributor
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
Fixes#1154
What changes did you make? (Give an overview)
Specifically called the componentParser on the popovers in the footnotes plugin
Provide some example code that this change will affect:
**Normal footnotes:**
Here is a footnote reference,[^1] and another.[^longnote]
​
[^1]: Here is the footnote. Footnotes will appear at the bottom of the page.
​
[^longnote]: Here's one with multiple blocks.
​
Subsequent paragraphs are indented to show that they
belong to the previous footnote.
**Inline footnotes:**
Here is an inline note.^[Inlines notes are easier to write, since
you don't have to pick an identifier and move down to type the
note.]
Is there anything you'd like reviewers to focus on?
This is the simple bug fix for now. Long term solution to fix footnotes inside dynamic panels is still in the works.
Testing instructions:
Check that the popovers appear.
Proposed commit message: (wrap lines at 72 characters)
During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.

@openorclose
Parse popovers for footnotes
65a9233
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
@le0tanle0tan
added

c.Bug 🐛

p.Medium

pr.BugFix 🐛
Fixes correct a programming error/assumption
and removed

c.Bug 🐛

p.Medium

labels
Mar 29, 2020
nbriannl
nbriannl
reviewed
Mar 29, 2020
View reviewed changes
Comment threadtest/functional/test_site/expected/index.html
Outdated

you don't have to pick an identifier and move down to type the
note.</p>
 </div>
 </span>
@nbriannlnbriannlMar 29, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the indents are incorrect, but i assume this is what updatetest generated, so can't really argue with this, can I?
@openorcloseopenorcloseApr 2, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah..
ang-zeyu
ang-zeyu
approved these changes
Apr 2, 2020
View reviewed changes
@ang-zeyuang-zeyu
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
@ang-zeyuang-zeyu
added this to the v2.13.2 milestone
Apr 2, 2020
@yamgent
yamgent
commented
Apr 5, 2020

Copy link


Copy Markdown

Member
@openorclose resolve conflicts
@openorclose
Merge remote-tracking branch 'origin/master' into parse_footnote_popo…
07e21c0
…vers
# Conflicts:
#	test/functional/test_site/expected/index.html
@openorclose
openorclose
commented
Apr 5, 2020

Copy link


Copy Markdown

ContributorAuthor
@openorclose resolve conflicts
Done!

This was referenced Apr 5, 2020

Closed

 Merged

@yamgent
yamgent
merged commit 9984374
into
MarkBind:masterApr 7, 2020
Tejas2805 added a commit
to Tejas2805/markbind
that referenced
this pull request
Apr 9, 2020
@Tejas2805
Merge branch 'master' ofhttps://github.com/MarkBind/markbind
9792d68
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
Document adding new site content in DG (MarkBind#1153)
Add relative date feature (MarkBind#908)
Use <br> to separate lines of code block (MarkBind#1176)
Parse popovers for footnotes (MarkBind#1155)
Resolve comments
Expand test extensions and fix whitespace checks (MarkBind#1156)
Address comments
Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
Normalize inline puml line ending before hashing (MarkBind#1174)
Update tests (MarkBind#1178)
Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
Fix bug in Search for UG and DG (MarkBind#1147)
Add inline puml support (MarkBind#1100)
Fix hrefs for headings with angular brackets (MarkBind#1089)
Update tests for 2.13.1 (MarkBind#1169)
2.13.1
Update vue-strap version to v2.0.1-markbind.39
Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
2.13.0
Update test files
...
marvinchin pushed a commit
that referenced
this pull request
Apr 10, 2020
@openorcloseMarvin Chin
Parse popovers for footnotes (#1155)
fc3f4c3
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nbriannlnbriannlnbriannl left review comments
@yamgentyamgentyamgent approved these changes
@ang-zeyuang-zeyuang-zeyu approved these changes

Assignees


No one assigned


Labels

pr.BugFix 🐛Fixes correct a programming error/assumption

Projects


None yet


Milestone

v2.14.0

Development

Successfully merging this pull request may close these issues.

Footnotes don't show popovers


5 participants

@openorclose@yamgent@ang-zeyu@nbriannl@le0tan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Parse popovers for footnotes by openorclose · Pull Request #1155 · MarkBind/markbind · GitHub
Skip to content
Parse popovers for footnotes - #1155
Merged
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Apr 7, 2020
Merged
Parse popovers for footnotes#1155
yamgent merged 2 commits into
MarkBind:masterfrom 
openorclose:parse_footnote_popovers
Conversation
@openorclose
@openorcloseopenorclose
commented
Mar 28, 2020

Copy link


Copy Markdown

Contributor
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
Fixes#1154
What changes did you make? (Give an overview)
Specifically called the componentParser on the popovers in the footnotes plugin
Provide some example code that this change will affect:
**Normal footnotes:**
Here is a footnote reference,[^1] and another.[^longnote]
​
[^1]: Here is the footnote. Footnotes will appear at the bottom of the page.
​
[^longnote]: Here's one with multiple blocks.
​
Subsequent paragraphs are indented to show that they
belong to the previous footnote.
**Inline footnotes:**
Here is an inline note.^[Inlines notes are easier to write, since
you don't have to pick an identifier and move down to type the
note.]
Is there anything you'd like reviewers to focus on?
This is the simple bug fix for now. Long term solution to fix footnotes inside dynamic panels is still in the works.
Testing instructions:
Check that the popovers appear.
Proposed commit message: (wrap lines at 72 characters)
During the migration to bootstrap-vue, popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.

@openorclose
Parse popovers for footnotes
65a9233
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
@le0tanle0tan
added

c.Bug 🐛

p.Medium

pr.BugFix 🐛
Fixes correct a programming error/assumption
and removed

c.Bug 🐛

p.Medium

labels
Mar 29, 2020
nbriannl
nbriannl
reviewed
Mar 29, 2020
View reviewed changes
Comment threadtest/functional/test_site/expected/index.html
Outdated

you don't have to pick an identifier and move down to type the
note.</p>
 </div>
 </span>
@nbriannlnbriannlMar 29, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the indents are incorrect, but i assume this is what updatetest generated, so can't really argue with this, can I?
@openorcloseopenorcloseApr 2, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah..
ang-zeyu
ang-zeyu
approved these changes
Apr 2, 2020
View reviewed changes
@ang-zeyuang-zeyu
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
@ang-zeyuang-zeyu
added this to the v2.13.2 milestone
Apr 2, 2020
@yamgent
yamgent
commented
Apr 5, 2020

Copy link


Copy Markdown

Member
@openorclose resolve conflicts
@openorclose
Merge remote-tracking branch 'origin/master' into parse_footnote_popo…
07e21c0
…vers
# Conflicts:
#	test/functional/test_site/expected/index.html
@openorclose
openorclose
commented
Apr 5, 2020

Copy link


Copy Markdown

ContributorAuthor
@openorclose resolve conflicts
Done!

This was referenced Apr 5, 2020

Closed

 Merged

@yamgent
yamgent
merged commit 9984374
into
MarkBind:masterApr 7, 2020
Tejas2805 added a commit
to Tejas2805/markbind
that referenced
this pull request
Apr 9, 2020
@Tejas2805
Merge branch 'master' ofhttps://github.com/MarkBind/markbind
9792d68
* 'master' of https://github.com/MarkBind/markbind: (41 commits)
Document adding new site content in DG (MarkBind#1153)
Add relative date feature (MarkBind#908)
Use <br> to separate lines of code block (MarkBind#1176)
Parse popovers for footnotes (MarkBind#1155)
Resolve comments
Expand test extensions and fix whitespace checks (MarkBind#1156)
Address comments
Upgrade js-beautify and provide option to turn it off (MarkBind#1116)
Normalize inline puml line ending before hashing (MarkBind#1174)
Update tests (MarkBind#1178)
Remove fixed bugs from test\functional\test_site\bugs\index.md` (MarkBind#1148)
Fix bug in Search for UG and DG (MarkBind#1147)
Add inline puml support (MarkBind#1100)
Fix hrefs for headings with angular brackets (MarkBind#1089)
Update tests for 2.13.1 (MarkBind#1169)
2.13.1
Update vue-strap version to v2.0.1-markbind.39
Fix fontawsome icons don't show underlines to indicate modal/tooltip (MarkBind#1133)
2.13.0
Update test files
...
marvinchin pushed a commit
that referenced
this pull request
Apr 10, 2020
@openorcloseMarvin Chin
Parse popovers for footnotes (#1155)
fc3f4c3
During the migration to bootstrap-vue,
popovers had to be parsed into bootstrap-vue syntax.
This is done before the plugins stage, where footnotes are implemented, so the popovers don't work there.
Let's add the parsing of popovers to the footnotes plugin to solve this.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nbriannlnbriannlnbriannl left review comments
@yamgentyamgentyamgent approved these changes
@ang-zeyuang-zeyuang-zeyu approved these changes

Assignees


No one assigned


Labels

pr.BugFix 🐛Fixes correct a programming error/assumption

Projects


None yet


Milestone

v2.14.0

Development

Successfully merging this pull request may close these issues.

Footnotes don't show popovers


5 participants

@openorclose@yamgent@ang-zeyu@nbriannl@le0tan