Skip to content

Standardise code style and remove eslint disables - #1180

Merged
ang-zeyu merged 1 commit into
MarkBind:masterfrom
ang-zeyu:clean-eslint
Apr 10, 2020
Merged

Standardise code style and remove eslint disables#1180
ang-zeyu merged 1 commit into
MarkBind:masterfrom
ang-zeyu:clean-eslint

Conversation

@ang-zeyu

@ang-zeyuang-zeyu commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [x] Other, please explain:

What is the rationale for this request?

What changes did you make? (Give an overview)

Example of style regression fixed

$('modal').remove();$('panel').remove();// to$('modal').remove();$('panel').remove();

Is there anything you'd like reviewers to focus on?
na

Testing instructions:
na

Proposed commit message: (wrap lines at 72 characters)
Standardise code style and remove eslint disables

@openorclose

Copy link
Copy Markdown
Contributor

I don't think we should need to go in and manually fix styling? If it's accepted by eslint, that should be good enough.

Too much time will be spent on commenting about code style in PRs otherwise.

That being said, it's good that some of the unnecessary eslint disables are removed.

@ang-zeyu

Copy link
Copy Markdown
ContributorAuthor

I don't think we should need to go in and manually fix styling? If it's accepted by eslint, that should be good enough.

Too much time will be spent on commenting about code style in PRs otherwise.

That being said, it's good that some of the unnecessary eslint disables are removed.

Most of the style regressions were rather awkward, you could refer here #979 (review)
I think its always good to keep the code more readable especially for future developers

Too much time will be spent on commenting about code style in PRs otherwise.

Yes, this PR is specifically made for reverting the unintended code style changes though 😁

@yamgentyamgent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the cleanup looks pretty good 👍

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase your PR 🙂

@nbriannlnbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ang-zeyu
ang-zeyu merged commit da8c0f5 into MarkBind:masterApr 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ang-zeyu@openorclose@yamgent@nbriannl