You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change the checks for mobile navigation menus to require links to be present
Flourish the documentation a little more so this note is clearer
Anything you'd like to highlight / discuss:
na
Testing instructions:
8 cases, all testable in the formattingContents.md / any other page with both site + page nav:
(also in snapshot tests)
// Edit layouts/userGuide.md to have:
// Case 1 & 2
// **with** and **without** wrapping id="site-nav"
// mobile nav menu button does not show up
<site-nav>
no links here
</site-nav>
// Cases 3 & 4
// Case 3 (with) also testable with a simple <a /> tag
// **with** and **without** wrapping id="site-nav"
// mobile nav menu button shows up
<site-nav>
* [**Getting Started**]({{baseUrl}}/userGuide/gettingStarted.html)
</site-nav>
// Cases 5 & 6
// Case 5 (with) also testable with a simple <a /> tag
// **with** and **without** wrapping id="page-nav"
// mobile page nav button shows up
{{ pageNav }}
// Cases 7 & 8
// Case // **with** and **without** wrapping id="page-nav"
// mobile page nav button does not show up
{{ pageNav }} // however, erase all headings in formattingContents.md
Proposed commit message: (wrap lines at 72 characters)
Hide mobile navigation menus if there are no links
Checklist: ☑️
Updated the documentation for feature additions and enhancements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Anything you'd like to highlight / discuss:
na
Testing instructions:
8 cases, all testable in the
formattingContents.md/ any other page with both site + page nav:(also in snapshot tests)
// Edit
layouts/userGuide.mdto have:Proposed commit message: (wrap lines at 72 characters)
Hide mobile navigation menus if there are no links
Checklist: ☑️