Uh oh!
There was an error while loading. Please reload this page.
Migrate Site/index.js to TypeScript - #2270
Conversation
478bbd5 to
0f12a21Compare
raysonkoh
left a comment
There was a problem hiding this comment.
Thanks for the hardwork! Added some preliminary comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
9584d6b to
c598c07Comparec598c07 to
1cd8034CompareUh oh!
There was an error while loading. Please reload this page.
1cd8034 to
614999eCompareUh oh!
There was an error while loading. Please reload this page.
ang-zeyu
commented
Jul 23, 2023
@tlylt as it will be quite a bit of work to undo the revert while keeping track of new PRs editing the file #2308 (comment), I suggest adding a small follow up comment on top that prohibits any changes to this file until this is fixed (and bumping the priority). The alternative is letting a portion of the typescript migration work go to waste (also an ok approach). |
What is the purpose of this pull request?
Part of #1913
Overview of changes:
Migrates Site/index.js to TS
Anything you'd like to highlight/discuss:
If we want to refactor how the methods at the end of Site/index.js are handled, I'd suggest we do a separate refactor of these methods after migrating this file to TS. Rationale of having these methods defined with
Site.prototype: see #979Testing instructions:
N/A
Proposed commit message: (wrap lines at 72 characters)
(rebase commit)
Checklist: ☑️