Skip to content

Migrate Site/index.js to TypeScript - #2270

Merged
jovyntls merged 2 commits into
MarkBind:masterfrom
jovyntls:ts-migrate-site-indexjs
Apr 15, 2023
Merged

Migrate Site/index.js to TypeScript#2270
jovyntls merged 2 commits into
MarkBind:masterfrom
jovyntls:ts-migrate-site-indexjs

Conversation

@jovyntls

@jovyntlsjovyntls commented Apr 8, 2023

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Part of #1913

Overview of changes:
Migrates Site/index.js to TS

Anything you'd like to highlight/discuss:
If we want to refactor how the methods at the end of Site/index.js are handled, I'd suggest we do a separate refactor of these methods after migrating this file to TS. Rationale of having these methods defined with Site.prototype: see #979

Testing instructions:
N/A

Proposed commit message: (wrap lines at 72 characters)
(rebase commit)


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@jovyntls
jovyntlsforce-pushed the ts-migrate-site-indexjs branch 2 times, most recently from 478bbd5 to 0f12a21CompareApril 10, 2023 06:54
@jovyntls
jovyntls requested a review from a teamApril 10, 2023 10:36

@raysonkohraysonkoh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hardwork! Added some preliminary comments.

Comment threadpackages/core/src/Site/index.ts
Comment threadpackages/core/src/Site/index.ts Outdated
Comment threadpackages/core/src/Site/index.ts
Comment threadpackages/core/src/Site/index.ts Outdated
Comment threadpackages/core/src/Site/index.ts Outdated
Comment threadpackages/core/src/Site/index.ts
Comment threadpackages/core/src/Site/index.ts Outdated
Comment threadpackages/core/src/Site/index.ts
@jovyntls
jovyntlsforce-pushed the ts-migrate-site-indexjs branch 2 times, most recently from 9584d6b to c598c07CompareApril 13, 2023 01:52
@lhw-1lhw-1 mentioned this pull request Apr 14, 2023
13 tasks
@jovyntls
jovyntlsforce-pushed the ts-migrate-site-indexjs branch from c598c07 to 1cd8034CompareApril 14, 2023 08:20

@raysonkohraysonkoh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jovyntls!

Comment threadpackages/core/src/Site/index.ts Outdated
@jovyntls
jovyntlsforce-pushed the ts-migrate-site-indexjs branch from 1cd8034 to 614999eCompareApril 14, 2023 15:18
Comment threadpackages/core/src/Site/index.ts

@tlylttlylt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jovyntls for this 💪, have taken a brief look and LGTM.

@tlylttlylt added this to the v4.1.1 milestone Apr 14, 2023
@jovyntls
jovyntls merged commit 63ed852 into MarkBind:masterApr 15, 2023
@jovyntls
jovyntls deleted the ts-migrate-site-indexjs branch April 15, 2023 10:25
@ang-zeyu

Copy link
Copy Markdown
Contributor

@tlylt as it will be quite a bit of work to undo the revert while keeping track of new PRs editing the file #2308 (comment), I suggest adding a small follow up comment on top that prohibits any changes to this file until this is fixed (and bumping the priority).

The alternative is letting a portion of the typescript migration work go to waste (also an ok approach).
I'll leave this up to you.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jovyntls@ang-zeyu@raysonkoh@tlylt