Fix anchors for panel headers by jamos-tay · Pull Request #454 · MarkBind/markbind

jamos-tay · 2018-10-15T11:43:19Z

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

What is the rationale for this request?

Anchors were not being generated for panel headers, and in a previous version do not redirect to the page when clicked.

What changes did you make? (Give an overview)

Anchors should now be generated for panel headers correctly.

The panel headers are stored in the panel's header attribute and rendered by vue, so headings weren't being picked up by Page. I worked around this by checking all panels for the header attribute and adding the anchor html there.

As for the links not working previously (see #442 (comment)), I added some code to setup.js to manually redirect the page when an anchor is clicked, it seems to be working as expected now.

jamos-tay · 2018-10-15T12:38:18Z

The tests are passing locally on my machine (windows) but for some reason Travis seems to be failing.

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /. Here's a diff (expected | actual):

Could I get some help on this?

nicholaschuayunzhi · 2018-10-16T22:52:32Z

 }

- if (isDiff(part) && !insidePath) {
+ if (isDiff(part) && !insidePath && !isPathSeparatorDiff(part.value)) {


The change here allows for this situation to pass:
expected.html
<div> \ </div>
actual.html
<div> / <div>

nicholaschuayunzhi · 2018-10-16T22:55:17Z

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /.

The reason is because Travis is running a unix env and the path separator generated will be / whereas on Windows, it will be \.

As for the diff that is being shown, I would think my diffing code will account for that and not trigger an error. Sorry about that 🙏. I will help to look into the matter.

Also see my comment about your fix!

nicholaschuayunzhi · 2018-10-16T23:22:59Z

I found the bug:

its found in endsWithOpeningTag in diffHTML

The fragment that causes this is (note i've formatted it for readability)

<panel header="## Panel with src from another Markbind site header<a class='fa fa-anchor' href='#panel-with-src-from-another-markbind-site-header'></a>" src="/test_site
+/-\
sub_site/index._include_.html" expanded=""></panel>

To decide if the diff \ is found in a path, it checks if the diff

is within a path - checking if there is a preceding src=" (yes)
fragment is within a html tag
- here i check if i find a > or < first.
  - if < is found its within a html tag - diff is in path
  - if > is found assume not within html tag - diff is not in path (and this is incorrect for the case above)

Would a good solution be to check the parity of the < and > ?

jamos-tay · 2018-10-17T08:22:51Z

@nicholaschuayunzhi Nice! I'll go ahead and remove that line. Will wait for your PR to be merged first.

nicholaschuayunzhi · 2018-10-18T15:17:36Z

@jamos-tay The fix has been merged to master, you can go ahead and rebase on master and also drop commits d6e6851 and eb2f83a

jamos-tay · 2018-10-18T15:48:23Z

Sure, updated 👍

yamgent · 2018-10-20T11:03:10Z

Seems OK, but user-usability wise, I actually expected the anchor to have appeared when the mouse is inside the panel's header box, but as of now you must hover the mouse inside the header text in order to reveal it.

jamos-tay · 2018-10-24T13:49:15Z

Yeah... the dimensions of the header seems to be different for headers in panels.

I'll try and find a fix

jamos-tay · 2018-10-30T17:09:18Z

@yamgent Hey, think it should be fixed now.

There's still a minor nit where the anchor will disappear if the user hovers over the header text first, then moves the mouse right until the empty space (basically mouseleave gets triggered for the header), but fixing it would be quite troublesome and I think it's small enough to ignore.

yamgent

Awesome 👍

Just one minor nit left:

jamos-tay · 2018-11-05T05:27:12Z

Changes made

jamos-tay · 2018-10-15T11:43:19Z

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

Fixes#442

What is the rationale for this request?

Anchors were not being generated for panel headers, and in a previous version do not redirect to the page when clicked.

What changes did you make? (Give an overview)

Anchors should now be generated for panel headers correctly.

The panel headers are stored in the panel's header attribute and rendered by vue, so headings weren't being picked up by Page. I worked around this by checking all panels for the header attribute and adding the anchor html there.

As for the links not working previously (see #442 (comment)), I added some code to setup.js to manually redirect the page when an anchor is clicked, it seems to be working as expected now.

jamos-tay · 2018-10-15T12:38:18Z

The tests are passing locally on my machine (windows) but for some reason Travis seems to be failing.

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /. Here's a diff (expected | actual):

Could I get some help on this?

nicholaschuayunzhi · 2018-10-16T22:52:32Z

 }

- if (isDiff(part) && !insidePath) {
+ if (isDiff(part) && !insidePath && !isPathSeparatorDiff(part.value)) {


The change here allows for this situation to pass:
expected.html
<div> \ </div>
actual.html
<div> / <div>

nicholaschuayunzhi · 2018-10-16T22:55:17Z

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /.

The reason is because Travis is running a unix env and the path separator generated will be / whereas on Windows, it will be \.

As for the diff that is being shown, I would think my diffing code will account for that and not trigger an error. Sorry about that 🙏. I will help to look into the matter.

Also see my comment about your fix!

nicholaschuayunzhi · 2018-10-16T23:22:59Z

I found the bug:

its found in endsWithOpeningTag in diffHTML

The fragment that causes this is (note i've formatted it for readability)

<panel header="## Panel with src from another Markbind site header<a class='fa fa-anchor' href='#panel-with-src-from-another-markbind-site-header'></a>" src="/test_site
+/-\
sub_site/index._include_.html" expanded=""></panel>

To decide if the diff \ is found in a path, it checks if the diff

is within a path - checking if there is a preceding src=" (yes)
fragment is within a html tag
- here i check if i find a > or < first.
  - if < is found its within a html tag - diff is in path
  - if > is found assume not within html tag - diff is not in path (and this is incorrect for the case above)

Would a good solution be to check the parity of the < and > ?

jamos-tay · 2018-10-17T08:22:51Z

@nicholaschuayunzhi Nice! I'll go ahead and remove that line. Will wait for your PR to be merged first.

nicholaschuayunzhi · 2018-10-18T15:17:36Z

@jamos-tay The fix has been merged to master, you can go ahead and rebase on master and also drop commits d6e6851 and eb2f83a

jamos-tay · 2018-10-18T15:48:23Z

Sure, updated 👍

yamgent · 2018-10-20T11:03:10Z

Seems OK, but user-usability wise, I actually expected the anchor to have appeared when the mouse is inside the panel's header box, but as of now you must hover the mouse inside the header text in order to reveal it.

jamos-tay · 2018-10-24T13:49:15Z

Yeah... the dimensions of the header seems to be different for headers in panels.

I'll try and find a fix

jamos-tay · 2018-10-30T17:09:18Z

@yamgent Hey, think it should be fixed now.

There's still a minor nit where the anchor will disappear if the user hovers over the header text first, then moves the mouse right until the empty space (basically mouseleave gets triggered for the header), but fixing it would be quite troublesome and I think it's small enough to ignore.

yamgent

Awesome 👍

Just one minor nit left:

jamos-tay · 2018-11-05T05:27:12Z

Changes made

jamos-tay · 2018-10-15T11:43:19Z

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

Fixes#442

What is the rationale for this request?

Anchors were not being generated for panel headers, and in a previous version do not redirect to the page when clicked.

What changes did you make? (Give an overview)

Anchors should now be generated for panel headers correctly.

The panel headers are stored in the panel's header attribute and rendered by vue, so headings weren't being picked up by Page. I worked around this by checking all panels for the header attribute and adding the anchor html there.

As for the links not working previously (see #442 (comment)), I added some code to setup.js to manually redirect the page when an anchor is clicked, it seems to be working as expected now.

jamos-tay · 2018-10-15T12:38:18Z

The tests are passing locally on my machine (windows) but for some reason Travis seems to be failing.

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /. Here's a diff (expected | actual):

Could I get some help on this?

nicholaschuayunzhi · 2018-10-16T22:52:32Z

 }

- if (isDiff(part) && !insidePath) {
+ if (isDiff(part) && !insidePath && !isPathSeparatorDiff(part.value)) {


The change here allows for this situation to pass:
expected.html
<div> \ </div>
actual.html
<div> / <div>

nicholaschuayunzhi · 2018-10-16T22:55:17Z

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /.

The reason is because Travis is running a unix env and the path separator generated will be / whereas on Windows, it will be \.

As for the diff that is being shown, I would think my diffing code will account for that and not trigger an error. Sorry about that 🙏. I will help to look into the matter.

Also see my comment about your fix!

nicholaschuayunzhi · 2018-10-16T23:22:59Z

I found the bug:

its found in endsWithOpeningTag in diffHTML

The fragment that causes this is (note i've formatted it for readability)

<panel header="## Panel with src from another Markbind site header<a class='fa fa-anchor' href='#panel-with-src-from-another-markbind-site-header'></a>" src="/test_site
+/-\
sub_site/index._include_.html" expanded=""></panel>

To decide if the diff \ is found in a path, it checks if the diff

is within a path - checking if there is a preceding src=" (yes)
fragment is within a html tag
- here i check if i find a > or < first.
  - if < is found its within a html tag - diff is in path
  - if > is found assume not within html tag - diff is not in path (and this is incorrect for the case above)

Would a good solution be to check the parity of the < and > ?

jamos-tay · 2018-10-17T08:22:51Z

@nicholaschuayunzhi Nice! I'll go ahead and remove that line. Will wait for your PR to be merged first.

nicholaschuayunzhi · 2018-10-18T15:17:36Z

@jamos-tay The fix has been merged to master, you can go ahead and rebase on master and also drop commits d6e6851 and eb2f83a

jamos-tay · 2018-10-18T15:48:23Z

Sure, updated 👍

yamgent · 2018-10-20T11:03:10Z

Seems OK, but user-usability wise, I actually expected the anchor to have appeared when the mouse is inside the panel's header box, but as of now you must hover the mouse inside the header text in order to reveal it.

jamos-tay · 2018-10-24T13:49:15Z

Yeah... the dimensions of the header seems to be different for headers in panels.

I'll try and find a fix

jamos-tay · 2018-10-30T17:09:18Z

@yamgent Hey, think it should be fixed now.

There's still a minor nit where the anchor will disappear if the user hovers over the header text first, then moves the mouse right until the empty space (basically mouseleave gets triggered for the header), but fixing it would be quite troublesome and I think it's small enough to ignore.

yamgent

Awesome 👍

Just one minor nit left:

jamos-tay · 2018-11-05T05:27:12Z

Changes made

jamos-tay · 2018-10-15T11:43:19Z

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

Fixes#442

What is the rationale for this request?

Anchors were not being generated for panel headers, and in a previous version do not redirect to the page when clicked.

What changes did you make? (Give an overview)

Anchors should now be generated for panel headers correctly.

The panel headers are stored in the panel's header attribute and rendered by vue, so headings weren't being picked up by Page. I worked around this by checking all panels for the header attribute and adding the anchor html there.

As for the links not working previously (see #442 (comment)), I added some code to setup.js to manually redirect the page when an anchor is clicked, it seems to be working as expected now.

jamos-tay · 2018-10-15T12:38:18Z

The tests are passing locally on my machine (windows) but for some reason Travis seems to be failing.

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /. Here's a diff (expected | actual):

Could I get some help on this?

nicholaschuayunzhi · 2018-10-16T22:52:32Z

 }

- if (isDiff(part) && !insidePath) {
+ if (isDiff(part) && !insidePath && !isPathSeparatorDiff(part.value)) {


The change here allows for this situation to pass:
expected.html
<div> \ </div>
actual.html
<div> / <div>

nicholaschuayunzhi · 2018-10-16T22:55:17Z

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /.

The reason is because Travis is running a unix env and the path separator generated will be / whereas on Windows, it will be \.

As for the diff that is being shown, I would think my diffing code will account for that and not trigger an error. Sorry about that 🙏. I will help to look into the matter.

Also see my comment about your fix!

nicholaschuayunzhi · 2018-10-16T23:22:59Z

I found the bug:

its found in endsWithOpeningTag in diffHTML

The fragment that causes this is (note i've formatted it for readability)

<panel header="## Panel with src from another Markbind site header<a class='fa fa-anchor' href='#panel-with-src-from-another-markbind-site-header'></a>" src="/test_site
+/-\
sub_site/index._include_.html" expanded=""></panel>

To decide if the diff \ is found in a path, it checks if the diff

is within a path - checking if there is a preceding src=" (yes)
fragment is within a html tag
- here i check if i find a > or < first.
  - if < is found its within a html tag - diff is in path
  - if > is found assume not within html tag - diff is not in path (and this is incorrect for the case above)

Would a good solution be to check the parity of the < and > ?

jamos-tay · 2018-10-17T08:22:51Z

@nicholaschuayunzhi Nice! I'll go ahead and remove that line. Will wait for your PR to be merged first.

nicholaschuayunzhi · 2018-10-18T15:17:36Z

@jamos-tay The fix has been merged to master, you can go ahead and rebase on master and also drop commits d6e6851 and eb2f83a

jamos-tay · 2018-10-18T15:48:23Z

Sure, updated 👍

yamgent · 2018-10-20T11:03:10Z

Seems OK, but user-usability wise, I actually expected the anchor to have appeared when the mouse is inside the panel's header box, but as of now you must hover the mouse inside the header text in order to reveal it.

jamos-tay · 2018-10-24T13:49:15Z

Yeah... the dimensions of the header seems to be different for headers in panels.

I'll try and find a fix

jamos-tay · 2018-10-30T17:09:18Z

@yamgent Hey, think it should be fixed now.

There's still a minor nit where the anchor will disappear if the user hovers over the header text first, then moves the mouse right until the empty space (basically mouseleave gets triggered for the header), but fixing it would be quite troublesome and I think it's small enough to ignore.

yamgent

Awesome 👍

Just one minor nit left:

jamos-tay · 2018-11-05T05:27:12Z

Changes made

jamos-tay · 2018-10-15T11:43:19Z

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

Fixes#442

What is the rationale for this request?

Anchors were not being generated for panel headers, and in a previous version do not redirect to the page when clicked.

What changes did you make? (Give an overview)

Anchors should now be generated for panel headers correctly.

The panel headers are stored in the panel's header attribute and rendered by vue, so headings weren't being picked up by Page. I worked around this by checking all panels for the header attribute and adding the anchor html there.

As for the links not working previously (see #442 (comment)), I added some code to setup.js to manually redirect the page when an anchor is clicked, it seems to be working as expected now.

jamos-tay · 2018-10-15T12:38:18Z

The tests are passing locally on my machine (windows) but for some reason Travis seems to be failing.

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /. Here's a diff (expected | actual):

Could I get some help on this?

nicholaschuayunzhi · 2018-10-16T22:52:32Z

 }

- if (isDiff(part) && !insidePath) {
+ if (isDiff(part) && !insidePath && !isPathSeparatorDiff(part.value)) {


The change here allows for this situation to pass:
expected.html
<div> \ </div>
actual.html
<div> / <div>

nicholaschuayunzhi · 2018-10-16T22:55:17Z

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /.

The reason is because Travis is running a unix env and the path separator generated will be / whereas on Windows, it will be \.

As for the diff that is being shown, I would think my diffing code will account for that and not trigger an error. Sorry about that 🙏. I will help to look into the matter.

Also see my comment about your fix!

nicholaschuayunzhi · 2018-10-16T23:22:59Z

I found the bug:

its found in endsWithOpeningTag in diffHTML

The fragment that causes this is (note i've formatted it for readability)

<panel header="## Panel with src from another Markbind site header<a class='fa fa-anchor' href='#panel-with-src-from-another-markbind-site-header'></a>" src="/test_site
+/-\
sub_site/index._include_.html" expanded=""></panel>

To decide if the diff \ is found in a path, it checks if the diff

is within a path - checking if there is a preceding src=" (yes)
fragment is within a html tag
- here i check if i find a > or < first.
  - if < is found its within a html tag - diff is in path
  - if > is found assume not within html tag - diff is not in path (and this is incorrect for the case above)

Would a good solution be to check the parity of the < and > ?

jamos-tay · 2018-10-17T08:22:51Z

@nicholaschuayunzhi Nice! I'll go ahead and remove that line. Will wait for your PR to be merged first.

nicholaschuayunzhi · 2018-10-18T15:17:36Z

@jamos-tay The fix has been merged to master, you can go ahead and rebase on master and also drop commits d6e6851 and eb2f83a

jamos-tay · 2018-10-18T15:48:23Z

Sure, updated 👍

yamgent · 2018-10-20T11:03:10Z

Seems OK, but user-usability wise, I actually expected the anchor to have appeared when the mouse is inside the panel's header box, but as of now you must hover the mouse inside the header text in order to reveal it.

jamos-tay · 2018-10-24T13:49:15Z

Yeah... the dimensions of the header seems to be different for headers in panels.

I'll try and find a fix

jamos-tay · 2018-10-30T17:09:18Z

@yamgent Hey, think it should be fixed now.

There's still a minor nit where the anchor will disappear if the user hovers over the header text first, then moves the mouse right until the empty space (basically mouseleave gets triggered for the header), but fixing it would be quite troublesome and I think it's small enough to ignore.

yamgent

Awesome 👍

Just one minor nit left:

jamos-tay · 2018-11-05T05:27:12Z

Changes made

jamos-tay · 2018-10-15T11:43:19Z

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

Fixes#442

What is the rationale for this request?

Anchors were not being generated for panel headers, and in a previous version do not redirect to the page when clicked.

What changes did you make? (Give an overview)

Anchors should now be generated for panel headers correctly.

The panel headers are stored in the panel's header attribute and rendered by vue, so headings weren't being picked up by Page. I worked around this by checking all panels for the header attribute and adding the anchor html there.

As for the links not working previously (see #442 (comment)), I added some code to setup.js to manually redirect the page when an anchor is clicked, it seems to be working as expected now.

jamos-tay · 2018-10-15T12:38:18Z

The tests are passing locally on my machine (windows) but for some reason Travis seems to be failing.

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /. Here's a diff (expected | actual):

Could I get some help on this?

nicholaschuayunzhi · 2018-10-16T22:52:32Z

 }

- if (isDiff(part) && !insidePath) {
+ if (isDiff(part) && !insidePath && !isPathSeparatorDiff(part.value)) {


The change here allows for this situation to pass:
expected.html
<div> \ </div>
actual.html
<div> / <div>

nicholaschuayunzhi · 2018-10-16T22:55:17Z

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /.

The reason is because Travis is running a unix env and the path separator generated will be / whereas on Windows, it will be \.

As for the diff that is being shown, I would think my diffing code will account for that and not trigger an error. Sorry about that 🙏. I will help to look into the matter.

Also see my comment about your fix!

nicholaschuayunzhi · 2018-10-16T23:22:59Z

I found the bug:

its found in endsWithOpeningTag in diffHTML

The fragment that causes this is (note i've formatted it for readability)

<panel header="## Panel with src from another Markbind site header<a class='fa fa-anchor' href='#panel-with-src-from-another-markbind-site-header'></a>" src="/test_site
+/-\
sub_site/index._include_.html" expanded=""></panel>

To decide if the diff \ is found in a path, it checks if the diff

is within a path - checking if there is a preceding src=" (yes)
fragment is within a html tag
- here i check if i find a > or < first.
  - if < is found its within a html tag - diff is in path
  - if > is found assume not within html tag - diff is not in path (and this is incorrect for the case above)

Would a good solution be to check the parity of the < and > ?

jamos-tay · 2018-10-17T08:22:51Z

@nicholaschuayunzhi Nice! I'll go ahead and remove that line. Will wait for your PR to be merged first.

nicholaschuayunzhi · 2018-10-18T15:17:36Z

@jamos-tay The fix has been merged to master, you can go ahead and rebase on master and also drop commits d6e6851 and eb2f83a

jamos-tay · 2018-10-18T15:48:23Z

Sure, updated 👍

yamgent · 2018-10-20T11:03:10Z

Seems OK, but user-usability wise, I actually expected the anchor to have appeared when the mouse is inside the panel's header box, but as of now you must hover the mouse inside the header text in order to reveal it.

jamos-tay · 2018-10-24T13:49:15Z

Yeah... the dimensions of the header seems to be different for headers in panels.

I'll try and find a fix

jamos-tay · 2018-10-30T17:09:18Z

@yamgent Hey, think it should be fixed now.

There's still a minor nit where the anchor will disappear if the user hovers over the header text first, then moves the mouse right until the empty space (basically mouseleave gets triggered for the header), but fixing it would be quite troublesome and I think it's small enough to ignore.

yamgent

Awesome 👍

Just one minor nit left:

jamos-tay · 2018-11-05T05:27:12Z

Changes made

jamos-tay · 2018-10-15T11:43:19Z

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

Fixes#442

What is the rationale for this request?

Anchors were not being generated for panel headers, and in a previous version do not redirect to the page when clicked.

What changes did you make? (Give an overview)

Anchors should now be generated for panel headers correctly.

The panel headers are stored in the panel's header attribute and rendered by vue, so headings weren't being picked up by Page. I worked around this by checking all panels for the header attribute and adding the anchor html there.

As for the links not working previously (see #442 (comment)), I added some code to setup.js to manually redirect the page when an anchor is clicked, it seems to be working as expected now.

jamos-tay · 2018-10-15T12:38:18Z

The tests are passing locally on my machine (windows) but for some reason Travis seems to be failing.

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /. Here's a diff (expected | actual):

Could I get some help on this?

nicholaschuayunzhi · 2018-10-16T22:52:32Z

 }

- if (isDiff(part) && !insidePath) {
+ if (isDiff(part) && !insidePath && !isPathSeparatorDiff(part.value)) {


The change here allows for this situation to pass:
expected.html
<div> \ </div>
actual.html
<div> / <div>

nicholaschuayunzhi · 2018-10-16T22:55:17Z

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /.

The reason is because Travis is running a unix env and the path separator generated will be / whereas on Windows, it will be \.

As for the diff that is being shown, I would think my diffing code will account for that and not trigger an error. Sorry about that 🙏. I will help to look into the matter.

Also see my comment about your fix!

nicholaschuayunzhi · 2018-10-16T23:22:59Z

I found the bug:

its found in endsWithOpeningTag in diffHTML

The fragment that causes this is (note i've formatted it for readability)

<panel header="## Panel with src from another Markbind site header<a class='fa fa-anchor' href='#panel-with-src-from-another-markbind-site-header'></a>" src="/test_site
+/-\
sub_site/index._include_.html" expanded=""></panel>

To decide if the diff \ is found in a path, it checks if the diff

is within a path - checking if there is a preceding src=" (yes)
fragment is within a html tag
- here i check if i find a > or < first.
  - if < is found its within a html tag - diff is in path
  - if > is found assume not within html tag - diff is not in path (and this is incorrect for the case above)

Would a good solution be to check the parity of the < and > ?

jamos-tay · 2018-10-17T08:22:51Z

@nicholaschuayunzhi Nice! I'll go ahead and remove that line. Will wait for your PR to be merged first.

nicholaschuayunzhi · 2018-10-18T15:17:36Z

@jamos-tay The fix has been merged to master, you can go ahead and rebase on master and also drop commits d6e6851 and eb2f83a

jamos-tay · 2018-10-18T15:48:23Z

Sure, updated 👍

yamgent · 2018-10-20T11:03:10Z

Seems OK, but user-usability wise, I actually expected the anchor to have appeared when the mouse is inside the panel's header box, but as of now you must hover the mouse inside the header text in order to reveal it.

jamos-tay · 2018-10-24T13:49:15Z

Yeah... the dimensions of the header seems to be different for headers in panels.

I'll try and find a fix

jamos-tay · 2018-10-30T17:09:18Z

@yamgent Hey, think it should be fixed now.

There's still a minor nit where the anchor will disappear if the user hovers over the header text first, then moves the mouse right until the empty space (basically mouseleave gets triggered for the header), but fixing it would be quite troublesome and I think it's small enough to ignore.

yamgent

Awesome 👍

Just one minor nit left:

jamos-tay · 2018-11-05T05:27:12Z

Changes made

jamos-tay · 2018-10-15T11:43:19Z

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

Fixes#442

What is the rationale for this request?

Anchors were not being generated for panel headers, and in a previous version do not redirect to the page when clicked.

What changes did you make? (Give an overview)

Anchors should now be generated for panel headers correctly.

The panel headers are stored in the panel's header attribute and rendered by vue, so headings weren't being picked up by Page. I worked around this by checking all panels for the header attribute and adding the anchor html there.

As for the links not working previously (see #442 (comment)), I added some code to setup.js to manually redirect the page when an anchor is clicked, it seems to be working as expected now.

jamos-tay · 2018-10-15T12:38:18Z

The tests are passing locally on my machine (windows) but for some reason Travis seems to be failing.

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /. Here's a diff (expected | actual):

Could I get some help on this?

nicholaschuayunzhi · 2018-10-16T22:52:32Z

 }

- if (isDiff(part) && !insidePath) {
+ if (isDiff(part) && !insidePath && !isPathSeparatorDiff(part.value)) {


The change here allows for this situation to pass:
expected.html
<div> \ </div>
actual.html
<div> / <div>

nicholaschuayunzhi · 2018-10-16T22:55:17Z

Somehow when rendered on Travis the block of code I added causes the src attribute of panels to change, all the \ are converted to /.

The reason is because Travis is running a unix env and the path separator generated will be / whereas on Windows, it will be \.

As for the diff that is being shown, I would think my diffing code will account for that and not trigger an error. Sorry about that 🙏. I will help to look into the matter.

Also see my comment about your fix!

nicholaschuayunzhi · 2018-10-16T23:22:59Z

I found the bug:

its found in endsWithOpeningTag in diffHTML

The fragment that causes this is (note i've formatted it for readability)

<panel header="## Panel with src from another Markbind site header<a class='fa fa-anchor' href='#panel-with-src-from-another-markbind-site-header'></a>" src="/test_site
+/-\
sub_site/index._include_.html" expanded=""></panel>

To decide if the diff \ is found in a path, it checks if the diff

is within a path - checking if there is a preceding src=" (yes)
fragment is within a html tag
- here i check if i find a > or < first.
  - if < is found its within a html tag - diff is in path
  - if > is found assume not within html tag - diff is not in path (and this is incorrect for the case above)

Would a good solution be to check the parity of the < and > ?

jamos-tay · 2018-10-17T08:22:51Z

@nicholaschuayunzhi Nice! I'll go ahead and remove that line. Will wait for your PR to be merged first.

nicholaschuayunzhi · 2018-10-18T15:17:36Z

@jamos-tay The fix has been merged to master, you can go ahead and rebase on master and also drop commits d6e6851 and eb2f83a

jamos-tay · 2018-10-18T15:48:23Z

Sure, updated 👍

yamgent · 2018-10-20T11:03:10Z

Seems OK, but user-usability wise, I actually expected the anchor to have appeared when the mouse is inside the panel's header box, but as of now you must hover the mouse inside the header text in order to reveal it.

jamos-tay · 2018-10-24T13:49:15Z

Yeah... the dimensions of the header seems to be different for headers in panels.

I'll try and find a fix

jamos-tay · 2018-10-30T17:09:18Z

@yamgent Hey, think it should be fixed now.

There's still a minor nit where the anchor will disappear if the user hovers over the header text first, then moves the mouse right until the empty space (basically mouseleave gets triggered for the header), but fixing it would be quite troublesome and I think it's small enough to ignore.

yamgent

Awesome 👍

Just one minor nit left:

jamos-tay · 2018-11-05T05:27:12Z

Changes made

jamos-tay force-pushed the anchor-in-panel branch 3 times, most recently from e45d2b9 to c002fc2Compare October 15, 2018 12:35

jamos-tay force-pushed the anchor-in-panel branch from 2eafdb6 to eb2f83aCompare October 15, 2018 12:46

nicholaschuayunzhi reviewed Oct 16, 2018
View reviewed changes

nicholaschuayunzhi mentioned this pull request Oct 17, 2018
Account for closing html tags during diff #455
Merged

Fix anchors in panel headings
1d248c4

jamos-tay force-pushed the anchor-in-panel branch from d6e6851 to 1d248c4Compare October 18, 2018 15:45

Make hover apply to wrapper
fa3be99

yamgent self-requested a review October 31, 2018 03:04

yamgent reviewed Nov 2, 2018
View reviewed changes

Comment threadtest/test_site/expected/markbind/js/setup.js

Replace setup file in expected
bc74909

yamgent approved these changes Nov 5, 2018
View reviewed changes

yamgent added this to the v1.14.1 milestone Nov 6, 2018

yamgent merged commit 91cdc98 into MarkBind:masterNov 6, 2018

jamos-tay force-pushed the anchor-in-panel branch 3 times, most recently from e45d2b9 to c002fc2Compare October 15, 2018 12:35

jamos-tay force-pushed the anchor-in-panel branch from 2eafdb6 to eb2f83aCompare October 15, 2018 12:46

nicholaschuayunzhi reviewed Oct 16, 2018
View reviewed changes

nicholaschuayunzhi mentioned this pull request Oct 17, 2018
Account for closing html tags during diff #455
Merged

Fix anchors in panel headings
1d248c4

jamos-tay force-pushed the anchor-in-panel branch from d6e6851 to 1d248c4Compare October 18, 2018 15:45

Make hover apply to wrapper
fa3be99

yamgent self-requested a review October 31, 2018 03:04

yamgent reviewed Nov 2, 2018
View reviewed changes

Comment threadtest/test_site/expected/markbind/js/setup.js

Replace setup file in expected
bc74909

yamgent approved these changes Nov 5, 2018
View reviewed changes

yamgent added this to the v1.14.1 milestone Nov 6, 2018

yamgent merged commit 91cdc98 into MarkBind:masterNov 6, 2018

jamos-tay force-pushed the anchor-in-panel branch 3 times, most recently from e45d2b9 to c002fc2Compare October 15, 2018 12:35

jamos-tay force-pushed the anchor-in-panel branch from 2eafdb6 to eb2f83aCompare October 15, 2018 12:46

nicholaschuayunzhi reviewed Oct 16, 2018
View reviewed changes

nicholaschuayunzhi mentioned this pull request Oct 17, 2018
Account for closing html tags during diff #455
Merged

Fix anchors in panel headings
1d248c4

jamos-tay force-pushed the anchor-in-panel branch from d6e6851 to 1d248c4Compare October 18, 2018 15:45

Make hover apply to wrapper
fa3be99

yamgent self-requested a review October 31, 2018 03:04

yamgent reviewed Nov 2, 2018
View reviewed changes

Comment threadtest/test_site/expected/markbind/js/setup.js

Replace setup file in expected
bc74909

yamgent approved these changes Nov 5, 2018
View reviewed changes

yamgent added this to the v1.14.1 milestone Nov 6, 2018

yamgent merged commit 91cdc98 into MarkBind:masterNov 6, 2018

jamos-tay force-pushed the anchor-in-panel branch 3 times, most recently from e45d2b9 to c002fc2Compare October 15, 2018 12:35

jamos-tay force-pushed the anchor-in-panel branch from 2eafdb6 to eb2f83aCompare October 15, 2018 12:46

nicholaschuayunzhi reviewed Oct 16, 2018
View reviewed changes

nicholaschuayunzhi mentioned this pull request Oct 17, 2018
Account for closing html tags during diff #455
Merged

Fix anchors in panel headings
1d248c4

jamos-tay force-pushed the anchor-in-panel branch from d6e6851 to 1d248c4Compare October 18, 2018 15:45

Make hover apply to wrapper
fa3be99

yamgent self-requested a review October 31, 2018 03:04

yamgent reviewed Nov 2, 2018
View reviewed changes

Comment threadtest/test_site/expected/markbind/js/setup.js

Replace setup file in expected
bc74909

yamgent approved these changes Nov 5, 2018
View reviewed changes

yamgent added this to the v1.14.1 milestone Nov 6, 2018

yamgent merged commit 91cdc98 into MarkBind:masterNov 6, 2018

jamos-tay force-pushed the anchor-in-panel branch 3 times, most recently from e45d2b9 to c002fc2Compare October 15, 2018 12:35

jamos-tay force-pushed the anchor-in-panel branch from 2eafdb6 to eb2f83aCompare October 15, 2018 12:46

nicholaschuayunzhi reviewed Oct 16, 2018
View reviewed changes

nicholaschuayunzhi mentioned this pull request Oct 17, 2018
Account for closing html tags during diff #455
Merged

Fix anchors in panel headings
1d248c4

jamos-tay force-pushed the anchor-in-panel branch from d6e6851 to 1d248c4Compare October 18, 2018 15:45

Make hover apply to wrapper
fa3be99

yamgent self-requested a review October 31, 2018 03:04

yamgent reviewed Nov 2, 2018
View reviewed changes

Comment threadtest/test_site/expected/markbind/js/setup.js

Replace setup file in expected
bc74909

yamgent approved these changes Nov 5, 2018
View reviewed changes

yamgent added this to the v1.14.1 milestone Nov 6, 2018

yamgent merged commit 91cdc98 into MarkBind:masterNov 6, 2018

jamos-tay force-pushed the anchor-in-panel branch 3 times, most recently from e45d2b9 to c002fc2Compare October 15, 2018 12:35

jamos-tay force-pushed the anchor-in-panel branch from 2eafdb6 to eb2f83aCompare October 15, 2018 12:46

nicholaschuayunzhi reviewed Oct 16, 2018
View reviewed changes

nicholaschuayunzhi mentioned this pull request Oct 17, 2018
Account for closing html tags during diff #455
Merged

Fix anchors in panel headings
1d248c4

jamos-tay force-pushed the anchor-in-panel branch from d6e6851 to 1d248c4Compare October 18, 2018 15:45

Make hover apply to wrapper
fa3be99

yamgent self-requested a review October 31, 2018 03:04

yamgent reviewed Nov 2, 2018
View reviewed changes

Comment threadtest/test_site/expected/markbind/js/setup.js

Replace setup file in expected
bc74909

yamgent approved these changes Nov 5, 2018
View reviewed changes

yamgent added this to the v1.14.1 milestone Nov 6, 2018

yamgent merged commit 91cdc98 into MarkBind:masterNov 6, 2018

jamos-tay force-pushed the anchor-in-panel branch 3 times, most recently from e45d2b9 to c002fc2Compare October 15, 2018 12:35

jamos-tay force-pushed the anchor-in-panel branch from 2eafdb6 to eb2f83aCompare October 15, 2018 12:46

nicholaschuayunzhi reviewed Oct 16, 2018
View reviewed changes

nicholaschuayunzhi mentioned this pull request Oct 17, 2018
Account for closing html tags during diff #455
Merged

Fix anchors in panel headings
1d248c4

jamos-tay force-pushed the anchor-in-panel branch from d6e6851 to 1d248c4Compare October 18, 2018 15:45

Make hover apply to wrapper
fa3be99

yamgent self-requested a review October 31, 2018 03:04

yamgent reviewed Nov 2, 2018
View reviewed changes

Comment threadtest/test_site/expected/markbind/js/setup.js

Replace setup file in expected
bc74909

yamgent approved these changes Nov 5, 2018
View reviewed changes

yamgent added this to the v1.14.1 milestone Nov 6, 2018

yamgent merged commit 91cdc98 into MarkBind:masterNov 6, 2018

jamos-tay force-pushed the anchor-in-panel branch 3 times, most recently from e45d2b9 to c002fc2Compare October 15, 2018 12:35

jamos-tay force-pushed the anchor-in-panel branch from 2eafdb6 to eb2f83aCompare October 15, 2018 12:46

nicholaschuayunzhi reviewed Oct 16, 2018
View reviewed changes

nicholaschuayunzhi mentioned this pull request Oct 17, 2018
Account for closing html tags during diff #455
Merged

Fix anchors in panel headings
1d248c4

jamos-tay force-pushed the anchor-in-panel branch from d6e6851 to 1d248c4Compare October 18, 2018 15:45

Make hover apply to wrapper
fa3be99

yamgent self-requested a review October 31, 2018 03:04

yamgent reviewed Nov 2, 2018
View reviewed changes

Comment threadtest/test_site/expected/markbind/js/setup.js

Replace setup file in expected
bc74909

yamgent approved these changes Nov 5, 2018
View reviewed changes

yamgent added this to the v1.14.1 milestone Nov 6, 2018

yamgent merged commit 91cdc98 into MarkBind:masterNov 6, 2018

Uh oh!

Conversation

jamos-tay commented Oct 15, 2018

Uh oh!

jamos-tay commented Oct 15, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicholaschuayunzhiOct 16, 2018

Choose a reason for hiding this comment

Uh oh!

nicholaschuayunzhi commented Oct 16, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicholaschuayunzhi commented Oct 16, 2018

Uh oh!

jamos-tay commented Oct 17, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicholaschuayunzhi commented Oct 18, 2018

Uh oh!

jamos-tay commented Oct 18, 2018

Uh oh!

yamgent commented Oct 20, 2018

Uh oh!

jamos-tay commented Oct 24, 2018

Uh oh!

jamos-tay commented Oct 30, 2018

Uh oh!

yamgent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jamos-tay commented Nov 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jamos-tay commented Oct 15, 2018

Uh oh!

jamos-tay commented Oct 15, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicholaschuayunzhiOct 16, 2018

Choose a reason for hiding this comment

Uh oh!

nicholaschuayunzhi commented Oct 16, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicholaschuayunzhi commented Oct 16, 2018

Uh oh!

jamos-tay commented Oct 17, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicholaschuayunzhi commented Oct 18, 2018

Uh oh!

jamos-tay commented Oct 18, 2018

Uh oh!

yamgent commented Oct 20, 2018

Uh oh!

jamos-tay commented Oct 24, 2018

Uh oh!

jamos-tay commented Oct 30, 2018

Uh oh!

yamgent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jamos-tay commented Nov 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

jamos-tay commented Oct 15, 2018•
edited
Loading

nicholaschuayunzhi commented Oct 16, 2018•
edited
Loading

jamos-tay commented Oct 17, 2018•
edited
Loading

jamos-tay commented Oct 15, 2018•
edited
Loading

nicholaschuayunzhi commented Oct 16, 2018•
edited
Loading

jamos-tay commented Oct 17, 2018•
edited
Loading

jamos-tay commented Oct 15, 2018•
edited
Loading

nicholaschuayunzhi commented Oct 16, 2018•
edited
Loading

jamos-tay commented Oct 17, 2018•
edited
Loading

jamos-tay commented Oct 15, 2018•
edited
Loading