Swap layout override priority

[jamos-tay]

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Other, please explain: Changing behavior of existing feature

Follow up from #467

What is the rationale for this request?

Swap the priority of loading layouts, site.json takes precedence over front matter instead of the other way around.

Added test to match.

[acjh]

I believe that was done to customize the layout for a page. The change still has to support that.

[jamos-tay]

How should it be specified though? I'm worried while this change might be more 'correct' but we end up lose some functionality.

If the user wants to customize the page then he should probably not use globs in the site.json

[acjh]

Oh, it's already customizable in site.json.

[jamos-tay]

Updated

[yamgent]

In site.json, no layout is specified.
In the frontmatter, testLayout is specified.
The final output still uses default instead of testLayout.

That doesn't seem right. 😕

[damithc]

It feels like the default should have the lowest priority.

[jamos-tay]

My bad, fixed it, there was some issue with the glob layouts

[jamos-tay]

Updated and Rebased

[yamgent]

@jamos-tay The documentation needs to be updated.

[jamos-tay]

Updated and rebased on master

[yamgent]

Please squash the commits.

[jamos-tay]

Squashed and rebased

[jamos-tay]

Updated

[nicholaschuayunzhi]

I have a diff when doing file compare for siteData.json. Red is expected, and green is what markbind generated.

{
"headings": {
- "uses-a-site.json-layout%2C-overriding-front-matter": "Uses a site.json layout, overriding front matter"+ "uses-a-site-json-layout-overriding-front-matter": "Uses a site.json layout, overriding front matter"
},
"title": "Hello World",
"head": "overwriteLayoutHead.md",
"layout": "testLayout",
"src": "testLayoutsOverride.md"
},

Want to clarify if the line in the expected file is correct.

[acjh]

I believe expected needs to be updated for #578.

[yamgent]

@nicholaschuayunzhi thanks for spotting the error, my apologies for the error, I didn't re-run the tests when merging this PR.

The fix is now available on the master branch, in commit f02c338.