Uh oh!
There was an error while loading. Please reload this page.
Add multiple test site support - #588
Conversation
0bb6ec4 to
60345ebCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
9acda71 to
67b5db4CompareRebased, updated I placed all the |
yamgent
left a comment
There was a problem hiding this comment.
I placed all the
test_siterelated changes in a separate commit, so you should just have to look at theAdd multiple test site functionalitycommit for review
Thanks a lot, that makes the reviewing process much easier. 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
67b5db4 to
97bdcd3Comparejamos-tay
commented
Jan 25, 2019
Rebased, updated |
yamgent
left a comment
There was a problem hiding this comment.
LGTM. As you mention, you will remove test_site_2 right?
jamos-tay
commented
Jan 27, 2019
Yup, removed it |
f38593a to
ede3281Compareede3281 to
ac11ce2Comparejamos-tay
commented
Jan 28, 2019
Rebased to fix conflicts |
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] New feature
Fixes#574
What is the rationale for this request?
Some features, such as tagging, must be tested on different sites since the test cases are mutually exclusive.
What changes did you make? (Give an overview)
Allow support for any number of test sites.
Revamped test directory structure:
Creating a new test site:
test/functionalmarkbind initin the folder, write test site as per normalexpecteddirectory within the folder and populate with expected filestest.sh
test.bat
Note: Ensure
expecteddirectory is ignored (Addexpected/*to the site.json ignore), and that nosrcorglobmatches any of the expected files (the default glob**/*.+(md|mbd)causes some problems)Is there anything you'd like reviewers to focus on?
The current
test_site_2folder is just there to show the feature works, it stores a fresh init site. Will remove before merge. No edits made to test_site, except for removing 3 lines from the site.jsonHow do we want to organize the tests? For example, say we have:
We could do something like this: