Skip to content

Update UG with minimum required Node version - #953

Merged
yamgent merged 5 commits into
MarkBind:masterfrom
hcwong:docs/update-node-ug
Dec 16, 2019
Merged

Update UG with minimum required Node version#953
yamgent merged 5 commits into
MarkBind:masterfrom
hcwong:docs/update-node-ug

Conversation

@hcwong

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [x] Documentation update

Fixes#848.

What is the rationale for this request?
Markbind had issues with old Node versions as stated in 7.2.0

What changes did you make? (Give an overview)
Just added an additional line in the user guide.

Proposed commit message: (wrap lines at 72 characters)
Update UG with minimum Node version

Comment threaddocs/userGuide/gettingStarted.md Outdated
%%{{ icon_ticked }}%% a basic knowledge of [Markdown](https://www.markdownguide.org/basic-syntax/) and [HTML](https://www.w3schools.com/html/) syntax<br>
%%{{ icon_ticked }}%% a basic knowledge of running CLI commands<br>
%%{{ icon_ticked }}%% a recent version of [npm](https://www.npmjs.com/get-npm) installed
%%{{ icon_ticked }}%% [Node.js](https://nodejs.org) v10.13.0 or higher installed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we need a <br> on the line before.

@yamgentyamgent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yamgentyamgent added this to the v2.7.1 milestone Dec 16, 2019
@yamgent
yamgent merged commit dea0559 into MarkBind:masterDec 16, 2019
@acjhacjh mentioned this pull request Mar 3, 2020
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve user guide to include required minimum node version

3 participants

@hcwong@yamgent@acjh