Skip to content

add teleport option support to checkpoint - #76

Closed
alan67160 wants to merge 1 commit into
MartenM:masterfrom
alan67160:patch-1
Closed

add teleport option support to checkpoint#76
alan67160 wants to merge 1 commit into
MartenM:masterfrom
alan67160:patch-1

Conversation

@alan67160

Copy link
Copy Markdown
Contributor

allow PluginUtils.fromString() accept loc without yaw and pitch

allow PluginUtils.fromString() accept loc without yaw and pitch
@MartenM

Copy link
Copy Markdown
Owner

Wouldn't this effectively set the location to yaw and pitch 0 0?

@alan67160

Copy link
Copy Markdown
ContributorAuthor

sorry that was a mistake. I'm trying to keep the viewing angle, so I think removing the pitch and yaw will do it, but the truth is not.
so maybe changing the following line will do the work?
src/main/java/nl/martenm/servertutorialplus/points/ServerTutorialPoint.java#L103
by adding a check on that line
if pitch and yaw no provided in the config file then clone the player pitch and yaw to target location?

@MartenM

Copy link
Copy Markdown
Owner

Creating an argument for points that teleport which could be (keepYawPitch) could be a thing.
Although to be honest, teleporting to a spot and not resetting the yaw and pitch might confuse players.

@alan67160

alan67160 commented Sep 28, 2023

Copy link
Copy Markdown
ContributorAuthor

let me give you a reasonable example
checkpoint will teleport player after player arrived the checkpoint
I am using checkpoint to create a path guidance and sending a message to you in every checkpoint to look like on talking to you right by your side
in that case the player constantly change the view

@MartenM

Copy link
Copy Markdown
Owner

let me give you a reasonable example checkpoint will teleport player after player arrived the checkpoint I am using checkpoint to create a path guidance and sending a message to you in every checkpoint to look like on talking to you right by your side in that case the player constantly change the view

Wouldn't disabling the teleport on the checkpoint make more sense? That's already possible.

@alan67160

Copy link
Copy Markdown
ContributorAuthor

I have already tried it to disable the teleport but it still teleport

tutorials:
t1:
stats:
plays: 13invisible: falsepermission: falseblock-chat: falseblocks-commands: falserewards: []command-whitelist: []points:
'6':
type: CHECKPOINTlocation: plot 37.5 97.5 2.5 1.91 -5.11time: 0.5locplayer: falselocview: falseteleport: falsemessages: []commands:
- custom_events_delaymsg 0.5 %player_name% <&a教學喵蟲&f> GoGo!!animation: CIRCLEcolour: 244 153 0distance: 1.0repeatActionbar: truedrawguide: trueguidecolour: 244 244 244

(0 to 5 was removed as it doesn't related)

@alan67160

alan67160 commented Sep 28, 2023

Copy link
Copy Markdown
ContributorAuthor

on github I only see the teleport argument loaded for ClickBlockPoint

ClickBlockPoint.java
src/main/java/nl/martenm/servertutorialplus/points/custom/ClickBlockPoint.java#L129

CheckPoint.java
src/main/java/nl/martenm/servertutorialplus/points/custom/CheckPoint.java#L171

@MartenM

Copy link
Copy Markdown
Owner

You should try to edit these things in-game using the commands. It will tell you if something is available or not.
If what you said is true, a PR that enables this for the checkpoint would be better :)

@alan67160
alan67160 deleted the patch-1 branch September 29, 2023 04:33
@alan67160alan67160 changed the title Update PluginUtils.javaadd teleport option support to checkpointSep 29, 2023
@alan67160

Copy link
Copy Markdown
ContributorAuthor

moved to #77

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alan67160@MartenM