GitHub build ci - #577
Conversation
b4b02a0 to
2ce512dComparefindNextStep
commented
Feb 20, 2020
for issue #534 |
XVilka
commented
Feb 22, 2020
Would be nice to run the tests too. |
findNextStep
commented
Feb 23, 2020
test-index in ccls seem to need clang-6 but I can`t work out with mac, can you help with that? |
XVilka
commented
Feb 25, 2020
Will check later, yes |
b299069 to
de800ebCompare
xerrni
left a comment
There was a problem hiding this comment.
Please also correct commit message from "add github ci integrated" to something more verbose like:
Add github CI integration.
CI will be responsible for compiling source code and code formatting.
| - name: clone submodule | ||
| run: git submodule update --init --recursive | ||
| - name: cmake generate | ||
| run: cmake -H. -Bbuild/Debug |
There was a problem hiding this comment.
cmake -H. -Bbuild/Debug -DCMAKE_BUILD_TYPE=Debug| - name: cmake generate | ||
| run: cmake -H. -Bbuild/Debug | ||
| - name: make | ||
| run: make -C build/Debug -j |
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: install depend | ||
| run: sudo apt install clang libclang-9-dev |
There was a problem hiding this comment.
DEBIAN_FRONTEND="noninteractive" sudo apt -y install clang libclang-9-dev| - name: clone submodule | ||
| run: git submodule update --init --recursive | ||
| - name: cmake generate | ||
| run: cmake -H. -Bbuild/Debug -DClang_DIR=/usr/local/opt/llvm/lib/cmake/clang -DLLVM_DIR=/usr/local/opt/llvm/lib/cmake |
There was a problem hiding this comment.
cmake -H. -Bbuild/Debug -DClang_DIR=/usr/local/opt/llvm/lib/cmake/clang -DLLVM_DIR=/usr/local/opt/llvm -DCMAKE_BUILD_TYPE=DebugThere was a problem hiding this comment.
Also you may wrap this line so it wont be exceed 120 characters.
| - name: cmake generate | ||
| run: cmake -H. -Bbuild/Debug -DClang_DIR=/usr/local/opt/llvm/lib/cmake/clang -DLLVM_DIR=/usr/local/opt/llvm/lib/cmake | ||
| - name: make | ||
| run: make -C build/Debug -j |
46eb5a3 to
11c9884CompareCI will be responsible for compiling source code and code formatting.
5d35dbe to
a4e7b93ComparefindNextStep
commented
Jul 4, 2020
all suggest has accepted |
7818055 to
99f0b40CompareTrass3r
commented
Jul 11, 2020
Imo you should do Release builds instead to be able to publish them. |
xerrni
commented
Jul 13, 2020
@Trass3r@findNextStep |
a33231a to
cb08df4Compareee29996 to
feb153aCompare94ba2b3 to
c018bceCompareEndle
commented
Mar 22, 2024
How about adding a basic Github CI at the beginning, and try to add further CI workflows in further PRs? IHMO a working CI could not only run unit tests, but also be an example of how to build and install this project, as a supplement of the docs. I'd like to take over this PR if it has been stalled |
db890d4 to
cc13cedComparee403622 to
cfc7c02Compare49cbf37 to
aca8280Compare
add github ci integrated
include
I format some code for clang-format ci check