[GCP-5388] Storage: Blob.exists() does not work within Batch context - #1
[GCP-5388] Storage: Blob.exists() does not work within Batch context#1IlyaFaer wants to merge 5 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sumit-ql
commented
Aug 3, 2019
Overall, solution looks good, just couple of comments related to test coverage:
|
| os.path.join("docs", ""), | ||
| os.path.join("docs", "_build", "html", ""), | ||
| ) No newline at end of file | ||
| ) |
There was a problem hiding this comment.
Is there any changes in nox file, if not, please remove this file from the the PR.
emar-kar
left a comment
There was a problem hiding this comment.
LGTM.
Checked noxfile chgs and as I see there was a correction to pass black session.
mf2199
commented
Aug 5, 2019
@emar-kar You probably meant, |
IlyaFaer
commented
Aug 7, 2019
@mf2199, @emar-kar, @sumit-ql, I think we have some problems with our |
IPR: 5388
Not very beautiful (that's how I see), but looks like it's the only easy solution. For now,
exists()don't do requests while in batch context. It only adds request into list, which will be processed on exiting batch context. Soexists()returnsTrueafter adding request into batch list, but it doesn't wait for requests to be processed. I've added object to pass it as target object into request (it will bind future request to this object) and to get result after exiting context