Skip to content

pkg_resources replaced with importlib.resources + change to github workflow main.yaml file - #22

Draft
dnearing wants to merge 3 commits into
mainfrom
core_test1
Draft

pkg_resources replaced with importlib.resources + change to github workflow main.yaml file#22
dnearing wants to merge 3 commits into
mainfrom
core_test1

Conversation

@dnearing

@dnearingdnearing commented Sep 10, 2024

Copy link
Copy Markdown
Collaborator

Replaces pkg_resources with importlib.resources in some mkidcore files. Closes issue #9. Also made a simple edit to .github/workflows/main.yaml. That change closes issue #23.

@codecov

codecovBot commented Sep 11, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.81%. Comparing base (fbcdf38) to head (554e937).

Files with missing linesPatch %Lines
mkidcore/objects.py50.00%2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #22 +/- ##
==========================================
- Coverage 33.87% 33.81% -0.06% 
==========================================
Files 12 12 Lines 1656 1653 -3 ==========================================
- Hits 561 559 -2 + Misses 1095 1094 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnearingdnearing changed the title pkg_resources replaced with importlib.resourcespkg_resources replaced with importlib.resources + change to github workflow main.yaml fileSep 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dnearing