Skip to content

CI's E2E test step has never run — GITHUB_CLIENT_ID/GITHUB_CLIENT_SECRET have never been configured as repository secrets #164

Description

@chonilius

.github/workflows/ci.yml's "Run E2E Tests (Conditional)" step:

if [ -z "$GITHUB_CLIENT_ID" ] || [ -z "$GITHUB_CLIENT_SECRET" ]; then
  echo "WARNING: Skipping E2E tests because external GitHub OAuth secrets are not configured..."
else
  npm run test:e2e
fi

gh secret list -R MergeFi/backend returns zero configured repository secrets. This means GITHUB_CLIENT_ID/GITHUB_CLIENT_SECRET have never been set, and this condition has been true on every single CI run since this workflow was introduced — npm run test:e2e has never executed in CI. The step exits 0 either way (the else branch is simply never reached), so this doesn't fail the pipeline or show up as anything other than a warning line buried in a green build — a PR could merge with a fully broken e2e-spec.ts file and CI would report success. See the companion issue for why gating on these secrets isn't even the right condition in the first place — none of the actual e2e specs use them.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workinghelp wantedExtra attention is neededtestingTesting/QA infrastructurevery hardVery difficult task, expert-level effort required

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions