fix: CI push trigger, webhook_events indexes, batched team-split insert, distinct release method names (#156, #149, #150, #159) - #223
Merged
Conversation
…, distinct release method names MergeFi#156 - add a push: branches: [main] trigger to ci.yml so commits landing on main by any path (admin bypass, misconfigured protection) still run the secret scan / lint / build / tests. MergeFi#149 - index the append-only webhook_events table: composite (eventType, status) and (status, receivedAt) via @Index + migration 1784900000000. MergeFi#150 - TeamsService.create / updateSplits now issue one batched splitRepo.save([...]) (inside TypeORM's implicit transaction) instead of N concurrent single-row saves. MergeFi#159 - EscrowService.releasePartial() invokes 'release_partial', not the same 'release' method name release() uses with a different arg count. Also collapses the duplicated imports/decls in escrow.service.spec.ts from an earlier main merge.
|
@stephanieoghenemega-eng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@stephanieoghenemega-eng is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #156
Resolves #149
Resolves #150
Resolves #159
#156 — CI also runs on push to
mainci.yml'son:had onlypull_request: [main]— a direct push tomain(admin bypass, misconfigured/not-yet-enabled branch protection) ran through none of the pipeline, including the secret scan. Added apush: branches: [main]trigger alongside it.#149 — index the
webhook_eventsaudit tableIt's append-only and never pruned (unlike
IdempotencyKey), yet onlydeliveryIdwas indexed. Added@Indexon(eventType, status)and(status, receivedAt)plus migration1784900000000— covering per-type breakdowns and the "recent FAILED events" query.#150 — batch the team-split insert
TeamsService.create(andupdateSplits) issued oneINSERTper member viaPromise.all(map(splitRepo.save(...)))— N round-trips, N independently-committing statements (a mid-way failure left a partial split set). Replaced with a singlesplitRepo.save(members.map(create)), which batches and runs inside TypeORM's implicit transaction.#159 — distinct on-chain method names for
releasevs partial releaserelease()calledsoroban.invoke('release', [ref, addr])(2 args) andreleasePartial()calledsoroban.invoke('release', [ref, addr, amount])(3 args) — same method name, different arity, un-caught at the backend layer.releasePartial()now invokes'release_partial', so a contract implementer isn't left guessing which arg shape'release'is authoritative.Incidental
escrow.service.spec.tshad duplicatedentities/enumsimports and twopaymentRepodeclarations from an earliermainmerge (1b58a30) that failstsc— collapsed to one set.Branched on current
main(c0ff5ff). Not built locally.