Skip to content

V2 endpoints for user and access management - #231

Merged
MarcelGeo merged 11 commits into
masterfrom
v2_endpoints_for_user_and_access_management
Feb 24, 2025
Merged

V2 endpoints for user and access management#231
MarcelGeo merged 11 commits into
masterfrom
v2_endpoints_for_user_and_access_management

Conversation

@harminius

@harminiusharminius commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

resolves#227

Implement v2 endpoints for creating user and CRUD on workspace and project roles.

varmar05
varmar05 requested changes Feb 14, 2025
View reviewed changes
Comment threadmergin/client.py
Comment threadmergin/client.py Outdated
Comment threadmergin/client.py Outdated
Comment threadmergin/client.py Outdated
Comment threadmergin/client.py Outdated
Comment threadmergin/test/test_client.py Outdated
Comment threadmergin/test/test_client.py Outdated
@tomasMizeratomasMizera mentioned this pull request Feb 14, 2025
Closed
@harminius
Address reviews
c92a145
- add project and workspace role enums
- add optional username to create_user
- remove redudant arguments from delete() method
- add tests for failures - permission issue, duplicate call, editor limit hit
MarcelGeo
MarcelGeo reviewed Feb 17, 2025
View reviewed changes

@MarcelGeoMarcelGeo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice..

  • one suggest for methods add_user_permissions_to_project,remove_user_permissions_from_project - we can add there message that this function will be deprecated in next major release 1.0.0 ?

  • could we use new introduced methods also in tests e.g for test_editor_push and similar?

Comment threadmergin/client.py Outdated
Comment threadmergin/client.py
Comment threadmergin/client.py Outdated
Comment threadmergin/test/test_client.py Outdated
@MarcelGeo
MarcelGeo merged commit c33f4a9 into masterFeb 24, 2025
@MarcelGeo
MarcelGeo deleted the v2_endpoints_for_user_and_access_management branch February 24, 2025 10:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcelGeoMarcelGeoMarcelGeo approved these changes
@varmar05varmar05varmar05 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement /v2 endpoints for user and access management

3 participants

@harminius@MarcelGeo@varmar05