Radaer api ukca side - part two initialisation by alanjhewitt · Pull Request #45 · MetOffice/ukca

Alan J Hewitt (alanjhewitt) · 2026-08-11T13:49:21Z

PR Summary

This change allows users to change the GLOMAP setting (i_mode_setup) that is passed to RADAER.

Sci/Tech Reviewer: Mohit Dalvi (@mcdalvi)
Code Reviewer: Pierre Siddall (@Pierre-siddall)

This development increases the flexibility of RADAER so that when called from LFRic_apps parent with setting GLOMAP_MODE_UKCA RADAER will run with the setting of i_mode_setup.

When called from LFRic_apps parent with setting GLOMAP_MODE_CLIMATOLOGY RADAER will run with the fixed setting of SUBCOCSSDU_7mode. This preserves the existing functionality but replaces hard coded settings in radaer_kernel_mod.

When called from LFRic_apps parent with setting GLOMAP_MODE_DUST_AND_CLIM UKCA will run with fixed setting DUonly_2modes and RADAER will run with the fixed setting of SUBCOCSSDU_7mode. This preserves the existing functionality but replaces hard coded settings in radaer_kernel_mod.

Lists used by radaer_kernel_mod are SAVED and stored in UKCA modules
n_ukca_mode and n_ukca_cpnt used by radaer_kernel_mod are SAVED and stored in UKCA modules.

linked Radaer api la side - part two initialisation lfric_apps#698
linked MetOffice/um/pull/130

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

I have performed a self-review of my own code
My code follows the project's style guidelines
Comments have been included that aid understanding and enhance the readability of the code
My changes generate no new warnings

Testing

I have tested this change locally, using the UKCA rose-stem suite
If shared files have been modified, I have run the UM and LFRic Apps rose stem suites
If any tests fail (rose-stem or CI) the reason is understood and acceptable (eg. kgo changes)
I have added tests to cover new functionality as appropriate (eg. system tests, unit tests, etc.)

I have run UKCA box model test with suite u-dr481

trac.log

From vanilla UM branch with only change dependencies.yaml pointing at this UKCA branch
https://github.com/alanjhewitt/um/tree/radaer_api_um_side_5

Test Suite Results - um - radaer_api_um_side_5/run1

Suite Information

Item	Value
Suite Name	radaer_api_um_side_5/run1
Suite User	alan.j.hewitt
Workflow Start	2026-09-01T11:22:13
Groups Run	developer', 'ukca

Dependency	Reference	Main Like
casim	MetOffice/casim@2026.07.1	True
jules	MetOffice/jules@2026.07.1	True
moci	MetOffice/moci@2026.07.1	True
mule	MetOffice/mule@2026.07.1	True
shumlib	MetOffice/shumlib@2026.07.1	True
socrates	MetOffice/socrates@2026.07.1	True
SimSys_Scripts	MetOffice/SimSys_Scripts@2026.07.1	True
ukca	alanjhewitt/ukca@radaer_api_ukca_side_5	True
um	alanjhewitt/um@radaer_api_um_side_5	False
um_aux	MetOffice/um_aux@2026.07.1	True
um_meta	MetOffice/um_meta@2026.07.1	True

Approvals

Code Owners

Section	Owner	Deputy	State
boundary_layer	adrianlock	paulburns	Pending
admin	SSD Team	--	Pending
stash	roddysharp	ericaneininger	Pending
bin	SSD Team	--	Pending
rose_stem	jamesbruten	roddysharp	Pending
top_level	jenniferhickson	samclarkegreen	Pending
rose-meta.conf	owner_of_related_section	--	Pending
upgrade_macros	ericaneininger	jamesbruten	Pending
Unknown	U	n	Pending

Config Owners

No UM Config Owners Required

Task Information

✅ succeeded tasks - 1306

Test Suite Results - lfric_apps - BoB_radaer_api_la_side_5x/run1

Suite Information

Item	Value
Suite Name	BoB_radaer_api_la_side_5x/run1
Suite User	alan.j.hewitt
Workflow Start	2026-08-28T09:38:33
Groups Run	all

Dependency	Reference	Main Like
casim	MetOffice/casim@2026.07.1	True
jules	MetOffice/jules@2026.07.1	True
lfric_apps	alanjhewitt/lfric_apps@BoB_radaer_api_la_side_5x	False
lfric_core	MetOffice/lfric_core@60fc29a	True
moci	MetOffice/moci@2026.07.1	True
SimSys_Scripts	MetOffice/SimSys_Scripts@77a5166	True
socrates	MetOffice/socrates@2026.07.1	True
socrates-spectral	MetOffice/socrates-spectral@2026.07.1	True
ukca	alanjhewitt/ukca@radaer_api_ukca_side_5	True

Task Information

✅ succeeded tasks - 1602

Security Considerations

I have reviewed my changes for potential security issues
Sensitive data is properly handled (if applicable)
Authentication and authorisation are properly implemented (if applicable)

Performance Impact

Performance of the code has been considered and, if applicable, suitable
performance measurements have been conducted

AI Assistance and Attribution

Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Sci/Tech Review

I understand this area of code and the changes being added
The proposed changes correspond to the pull request description
Documentation is sufficient (do documentation papers need updating)
Sufficient testing has been completed (UM as well as LFRIC)

Please alert the code reviewer via a tag when you have approved the SR

Code Review

All dependencies have been resolved
Related Issues have been properly linked and addressed
CLA compliance has been confirmed
Code quality standards have been met
Tests are adequate and have passed
Documentation is complete and accurate
Security considerations have been addressed
Performance impact is acceptable

Alan J Hewitt (alanjhewitt) · 2026-08-25T17:17:52Z

Hi Mohit,

this development is now ready for SciTech review.

Alan

Mohit Dalvi (mcdalvi) · 2026-08-27T09:10:59Z

+! Purpose:
+! To save structure ukca_radaer_lfric
+!
+! ---------------------------------------------------------------------


Could ukca_radaer_lfric be declared in the 'struct_mod' itself, avoiding the need for this module? The ukca_radaer_lfric_struct_mod will need to be accessed by calling/ downstream routines in any case.
If module is to be retained: check copyright statement (should be LICENCE file) and add ownership details

I updated the copyright statement. It would probably be fine to move it into struct_mod but i was a bit wary of creating a circular calling tree, so i put this separately.

Mohit Dalvi (mcdalvi) · 2026-08-27T09:12:10Z

+INTEGER(KIND=jpim), PARAMETER :: zhook_in = 0
+INTEGER(KIND=jpim), PARAMETER :: zhook_out = 1
+REAL(KIND=jprb) :: zhook_handle
+CHARACTER(LEN=*), PARAMETER :: RoutineName='UKCA_RADAER_LFRIC_INIT'


Correct the RoutineName

Mohit Dalvi (mcdalvi) · 2026-08-27T09:14:20Z

+! Code description:
+! Language: FORTRAN 90
+! This code is written to UMDP3 programming standards.
+!


Check copyright statement (should be LICENCE file).

Mohit Dalvi (mcdalvi) · 2026-08-27T09:20:49Z

+
+IF (lhook) CALL dr_hook(ModuleName//':'//RoutineName,zhook_out,zhook_handle)
+END SUBROUTINE allocate_radaer_lfric_struct
+


Does the structure/ instance stay in memory throughout, or is there a need for a 'deallocate' routine?

This is the initialisation step and these values are needed every run time step. I guess I could deallocate them at he end of the run, but we wouldnt need to free up the extra memory by then.

Alan J Hewitt (alanjhewitt) · 2026-09-01T13:07:20Z

The UM dependencies.yaml file needs updating as a linked PR

https://github.com/MetOffice/um/pull/130

Mohit Dalvi (mcdalvi)

Sci-tech Review passed

Pierre Siddall (Pierre-siddall)

Hi Alan J Hewitt (@alanjhewitt), once again this looks good just a couple of small changes regarding the names of two variable to make them slightly clearer to understand, then I'll be happy to approve and put this PR into testing along with it's linked PRs.

Pierre Siddall (Pierre-siddall) · 2026-09-04T07:41:33Z

+INTEGER :: i, j
+
+! In-loop copy of mode names
+CHARACTER(LEN=7) :: this_name


Maybe this variable would be more informative if it was named like this ?
Suggested change
CHARACTER(LEN=7) ::this_name
CHARACTER(LEN=7) ::mode_name

Pierre Siddall (Pierre-siddall) · 2026-09-04T07:42:36Z

+CHARACTER(LEN=7) :: this_name
+
+! In-loop mode type
+INTEGER :: this_type


Similarly to the previous comment renaming the variable here would be more informative.
Suggested change
INTEGER::this_type
INTEGER::mode_type

Alan J Hewitt (alanjhewitt) added 2 commits August 11, 2026 11:37

This could let radaer have a different i_mode_setup to ukca
c013064

pipework to populate ukca_radaer structure
b55e95d

Alan J Hewitt (alanjhewitt) self-assigned this Aug 11, 2026

Alan J Hewitt (alanjhewitt) added this to the Autumn 2026 milestone Aug 11, 2026

Alan J Hewitt (alanjhewitt) added the Linked Apps This PR is linked to a MetOffice/lfric_apps PR label Aug 11, 2026

Alan J Hewitt (alanjhewitt) mentioned this pull request Aug 11, 2026
Radaer api ukca side - part two initialisation #44
Closed
26 tasks

Alan J Hewitt (alanjhewitt) added 3 commits August 12, 2026 12:21

Needed more UM repository functionality
b8840ee

Fixing build errors
1054a38

More build errors
7e84066

Alan J Hewitt (alanjhewitt) mentioned this pull request Aug 13, 2026
Radaer api la side - part two initialisation MetOffice/lfric_apps#698
Open
28 tasks

Alan J Hewitt (alanjhewitt) added 3 commits August 14, 2026 14:49

didnt declare ereport
d828455

Needed by LFRic_apps
7eca4d8

Allocatable lists used by radaer kernel
5fed92b

github-actionsBot added the cla-modified The CLA has been modified as part of this PR - added by GA label Aug 24, 2026

Alan J Hewitt (alanjhewitt) added 6 commits August 24, 2026 17:10

call new ukca module
8e0f14c

Replace hard coded settings with calculated values
d98da23

tidy
fae9033

l_sustrat is a namelist option now
3d281a4

pointers were looking in wrong structure
d30ba8e

Dont need pointers here
ff8947f

Alan J Hewitt (alanjhewitt) requested a review from Mohit Dalvi (mcdalvi)August 25, 2026 17:03

Applied code styling
558a140

Alan J Hewitt (alanjhewitt) marked this pull request as ready for review August 25, 2026 17:16

Mohit Dalvi (mcdalvi) reviewed Aug 27, 2026
View reviewed changes

Alan J Hewitt (alanjhewitt) added 2 commits August 27, 2026 15:11

Scitech - Mohit suggested changes
a1ab8e6

Merge branch 'MetOffice:main' into radaer_api_ukca_side_5
a6369ba

github-actionsBot removed the cla-modified The CLA has been modified as part of this PR - added by GA label Sep 1, 2026

Updated code owner information in new modules
310df29

Alan J Hewitt (alanjhewitt) added the Linked UM This PR is linked to a MetOffice/um PR label Sep 1, 2026

Alan J Hewitt (alanjhewitt) requested a review from Pierre Siddall (Pierre-siddall)September 1, 2026 13:10

Mohit Dalvi (mcdalvi) self-requested a review September 1, 2026 13:18

Mohit Dalvi (mcdalvi) approved these changes Sep 1, 2026
View reviewed changes

Pierre Siddall (Pierre-siddall) reviewed Sep 4, 2026
View reviewed changes

code reviewer suggested change
545b660

Navigation Menu

Uh oh!

Radaer api ukca side - part two initialisation - #45

Radaer api ukca side - part two initialisation#45
Alan J Hewitt (alanjhewitt) wants to merge 19 commits into
MetOffice:mainfrom
alanjhewitt:radaer_api_ukca_side_5

Alan J Hewitt (alanjhewitt) commented Aug 11, 2026•
edited by mcdalvi
Loading

Uh oh!

Alan J Hewitt (alanjhewitt) commented Aug 25, 2026

Uh oh!

Mohit Dalvi (mcdalvi)Aug 27, 2026

Uh oh!

Alan J Hewitt (alanjhewitt)Aug 27, 2026

Uh oh!

Mohit Dalvi (mcdalvi)Aug 27, 2026

Uh oh!

Mohit Dalvi (mcdalvi)Aug 27, 2026

Uh oh!

Mohit Dalvi (mcdalvi)Aug 27, 2026

Uh oh!

Alan J Hewitt (alanjhewitt)Aug 27, 2026

Uh oh!

Alan J Hewitt (alanjhewitt) commented Sep 1, 2026

Uh oh!

Mohit Dalvi (mcdalvi) left a comment

Uh oh!

Pierre Siddall (Pierre-siddall) left a comment

Uh oh!

Pierre Siddall (Pierre-siddall)Sep 4, 2026

Uh oh!

Pierre Siddall (Pierre-siddall)Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		IF (lhook) CALL dr_hook(ModuleName//':'//RoutineName,zhook_out,zhook_handle)
		END SUBROUTINE allocate_radaer_lfric_struct

Uh oh!

Conversation

Alan J Hewitt (alanjhewitt) commented Aug 11, 2026• edited by mcdalvi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Code Quality Checklist

Testing

trac.log

Test Suite Results - um - radaer_api_um_side_5/run1

Suite Information

Approvals

Code Owners

Config Owners

Task Information

Test Suite Results - lfric_apps - BoB_radaer_api_la_side_5x/run1

Suite Information

Task Information

Security Considerations

Performance Impact

AI Assistance and Attribution

Documentation

Sci/Tech Review

Code Review

Uh oh!

Alan J Hewitt (alanjhewitt) commented Aug 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alan J Hewitt (alanjhewitt) commented Sep 1, 2026

Uh oh!

Mohit Dalvi (mcdalvi) left a comment

Choose a reason for hiding this comment

Uh oh!

Pierre Siddall (Pierre-siddall) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Alan J Hewitt (alanjhewitt) commented Aug 11, 2026•
edited by mcdalvi
Loading