Uh oh!
There was an error while loading. Please reload this page.
8.1.0 - #170
Conversation
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Typically the second number gets bumped if there is a new feature, but this seems like a fix to me. If that's the case then perhaps this version should be 8.0.2 instead of 8.1.0. (You will need to recreate this PR if that's the case) Ignore this, sorry!
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
| ## [8.1.0] | ||
| ### Changed | ||
| - Allow deserializing vaults with unrecognized keyrings ([#169](https://github.com/MetaMask/KeyringController/pull/169)) | ||
| - When deserializing a vault with an unrecognized keyring, the controller will no longer crash. The unrecogized keyring vault data will be preserved in the vault for future use, but will otherwise be ignored. |
There was a problem hiding this comment.
To confirm, was the unrecognized keyring only found using MV3? If so, could we update this description to indicate this is a non-issue for manifest v2?
There was a problem hiding this comment.
This change is not particular for MV3, this will work for any keyring type not supported.
mcmire
left a comment
There was a problem hiding this comment.
LGTM other than one little thing.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
This is the release candidate for version 8.1.0.