Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

devDeps: ethereumjs-wallet@^1.0.2 -> @ethereumjs/wallet@^2.0.0 - #263

Merged
legobeat merged 1 commit into
MetaMask:mainfrom
legobeat:devDeps-ethereumjs-wallet
Sep 12, 2023
Merged

devDeps: ethereumjs-wallet@^1.0.2 -> @ethereumjs/wallet@^2.0.0#263
legobeat merged 1 commit into
MetaMask:mainfrom
legobeat:devDeps-ethereumjs-wallet

Conversation

@legobeat

@legobeatlegobeat commented Sep 10, 2023

Copy link
Copy Markdown
Contributor

Description

Use modern version of @ethereumjs/wallet for testing purposes (for tests, that is. This PR is for real).

Unblocks

Changes

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security

Copy link
Copy Markdown

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages:ethereumjs-wallet@1.0.2

@legobeat
legobeatforce-pushed the devDeps-ethereumjs-wallet branch from e5fd03f to 94b1399CompareSeptember 10, 2023 03:34
@legobeatlegobeat mentioned this pull request Sep 10, 2023
Merged
15 tasks
@legobeat
legobeatforce-pushed the devDeps-ethereumjs-wallet branch from 94b1399 to 2dd557eCompareSeptember 10, 2023 03:40
@legobeat
legobeatforce-pushed the devDeps-ethereumjs-wallet branch from 2dd557e to c089d62CompareSeptember 10, 2023 03:55
@legobeat
legobeat marked this pull request as ready for review September 10, 2023 03:55
@legobeat
legobeat requested a review from a team as a code ownerSeptember 10, 2023 03:55
This was referenced Sep 10, 2023
Merged

@mikespositomikesposito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat
legobeat merged commit e4c6e2a into MetaMask:mainSep 12, 2023
@legobeat
legobeat deleted the devDeps-ethereumjs-wallet branch September 12, 2023 08:55
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat@mikesposito