Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

deps: @metamask/obs-store@^8.1.0->^9.0.0 - #303

Closed
legobeat wants to merge 1 commit into
MetaMask:mainfrom
legobeat:deps-obs-store
Closed

deps: @metamask/obs-store@^8.1.0->^9.0.0#303
legobeat wants to merge 1 commit into
MetaMask:mainfrom
legobeat:deps-obs-store

Conversation

@legobeat

@legobeatlegobeat commented Nov 22, 2023

Copy link
Copy Markdown
Contributor

Description

  • removes dependency on readable-stream@2

Changes

  • BREAKING: Update @metamask/obs-store from ^8.1.0 to ^9.0.0
    • Switch to readable-stream@^3.6.2 for streams

References

Blocking

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security

Copy link
Copy Markdown

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

PackagesVersionNew capabilitiesTransitivesSizePublisher
@metamask/obs-store8.1.0...9.0.0None+1/-938.9 kB

@socket-security

socket-securityBot commented Nov 22, 2023

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/safe-event-emitter@3.0.0, @metamask/obs-store@9.0.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor
    @SocketSecurity ignore @metamask/safe-event-emitter@3.0.0
    @SocketSecurity ignore @metamask/obs-store@9.0.0
    

    @legobeat
    legobeatforce-pushed the deps-obs-store branch 2 times, most recently from 13806f4 to 98d720bCompareNovember 22, 2023 13:26
    - removes dependency on readable-stream@2
    @legobeat
    legobeat marked this pull request as ready for review November 22, 2023 13:27
    @legobeat
    legobeat requested a review from a team as a code ownerNovember 22, 2023 13:27
    @legobeatlegobeat added the type-dependencies Pull requests that update a dependency file label Nov 22, 2023
    @legobeat

    Copy link
    Copy Markdown
    ContributorAuthor

    Closed in favor of #306 (where the typescript interface change has been ported over)

    Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

    Labels

    type-dependenciesPull requests that update a dependency file

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @legobeat