Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

BREAKING: Increase minimum node version to 18 - #366

Merged
legobeat merged 1 commit into
MetaMask:mainfrom
legobeat:node-18
Apr 22, 2024
Merged

BREAKING: Increase minimum node version to 18#366
legobeat merged 1 commit into
MetaMask:mainfrom
legobeat:node-18

Conversation

@legobeat

@legobeatlegobeat commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

Description

  • Remove support for major Node.js versions 16,17,19
  • Update recommended Node version in readme
  • ci: bump default version from 16 to 18
  • ci: remove node-version 16 from matrix

Changes

  • BREAKING: Drop support for Node.js versions 16, 17, 19

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@legobeatlegobeat changed the title BREAKING: incrase minimum node version to 18BREAKING: Increase minimum node version to 18Mar 5, 2024
@legobeat
legobeat marked this pull request as ready for review March 5, 2024 07:56
@legobeat
legobeat requested a review from a team as a code ownerMarch 5, 2024 07:56
@legobeat
legobeatforce-pushed the node-18 branch 2 times, most recently from 7bc4f25 to 7f8581fCompareMarch 5, 2024 08:04
@legobeat
legobeat merged commit 05b963c into MetaMask:mainApr 22, 2024
@mcmire

Copy link
Copy Markdown
Contributor

I don't think we were planning another major release of this package as it's in maintenance mode and has been replaced by @metamask/keyring-controller. Do we think this is necessary from a security perspective though?

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat@mcmire@mikesposito